Title: [247699] trunk/Source/WebCore
Revision
247699
Author
pvol...@apple.com
Date
2019-07-22 13:24:05 -0700 (Mon, 22 Jul 2019)

Log Message

Prewarmed font does not find any matches
https://bugs.webkit.org/show_bug.cgi?id=200007

Reviewed by Brent Fulgham.

Prewarming the font name 'SF Pro Text' does not find any matches. The font name ".SF NS Text/Display"
should be used instead. Also add 'Lucida Grande' to the list of prewarmed font, since it is used as
fallback font in many cases.

No new tests, covered by existing tests.

* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::fontFamiliesForPrewarming):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (247698 => 247699)


--- trunk/Source/WebCore/ChangeLog	2019-07-22 20:03:05 UTC (rev 247698)
+++ trunk/Source/WebCore/ChangeLog	2019-07-22 20:24:05 UTC (rev 247699)
@@ -1,3 +1,19 @@
+2019-07-22  Per Arne Vollan  <pvol...@apple.com>
+
+        Prewarmed font does not find any matches
+        https://bugs.webkit.org/show_bug.cgi?id=200007
+
+        Reviewed by Brent Fulgham.
+
+        Prewarming the font name 'SF Pro Text' does not find any matches. The font name ".SF NS Text/Display"
+        should be used instead. Also add 'Lucida Grande' to the list of prewarmed font, since it is used as
+        fallback font in many cases.
+
+        No new tests, covered by existing tests.
+
+        * platform/graphics/cocoa/FontCacheCoreText.cpp:
+        (WebCore::fontFamiliesForPrewarming):
+
 2019-07-22  Youenn Fablet  <you...@apple.com>
 
         Make sure the player underlying volume is correctly set after creating a new player

Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp (247698 => 247699)


--- trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp	2019-07-22 20:03:05 UTC (rev 247698)
+++ trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp	2019-07-22 20:24:05 UTC (rev 247699)
@@ -1652,10 +1652,12 @@
 static Vector<String>& fontFamiliesForPrewarming()
 {
     static NeverDestroyed<Vector<String>> families = std::initializer_list<String> {
+        ".SF NS Text"_s,
+        ".SF NS Display"_s,
         "Arial"_s,
         "Helvetica"_s,
         "Helvetica Neue"_s,
-        "SF Pro Text"_s,
+        "Lucida Grande"_s,
         "Times"_s,
         "Times New Roman"_s,
     };
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to