Title: [248735] trunk/Source/WebInspectorUI
Revision
248735
Author
drou...@apple.com
Date
2019-08-15 12:13:21 -0700 (Thu, 15 Aug 2019)

Log Message

Web Inspector: Layers: background of 3D area doesn't update when transitioning to/from Dark mode
https://bugs.webkit.org/show_bug.cgi?id=200775

Reviewed by Ross Kirsling.

* UserInterface/Views/Layers3DContentView.js:
(WI.Layers3DContentView.prototype.initialLayout):
Add a `matchMedia` listener for `(prefers-color-scheme: dark)` and update the clear color
of the WebGL renderer whenever it changes.

* UserInterface/Views/ErrorObjectView.css:
(@media (prefers-color-scheme: dark)): Added.
(@media (prefers-dark-interface)): Deleted.
* UserInterface/Views/SourcesNavigationSidebarPanel.css:
(@media (prefers-color-scheme: dark)): Added.
(@media (prefers-dark-interface)): Deleted.
Drive-by: replace older `prefers-dark-interface` with modern `prefers-color-scheme: dark`.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (248734 => 248735)


--- trunk/Source/WebInspectorUI/ChangeLog	2019-08-15 18:41:53 UTC (rev 248734)
+++ trunk/Source/WebInspectorUI/ChangeLog	2019-08-15 19:13:21 UTC (rev 248735)
@@ -1,3 +1,23 @@
+2019-08-15  Devin Rousso  <drou...@apple.com>
+
+        Web Inspector: Layers: background of 3D area doesn't update when transitioning to/from Dark mode
+        https://bugs.webkit.org/show_bug.cgi?id=200775
+
+        Reviewed by Ross Kirsling.
+
+        * UserInterface/Views/Layers3DContentView.js:
+        (WI.Layers3DContentView.prototype.initialLayout):
+        Add a `matchMedia` listener for `(prefers-color-scheme: dark)` and update the clear color
+        of the WebGL renderer whenever it changes.
+
+        * UserInterface/Views/ErrorObjectView.css:
+        (@media (prefers-color-scheme: dark)): Added.
+        (@media (prefers-dark-interface)): Deleted.
+        * UserInterface/Views/SourcesNavigationSidebarPanel.css:
+        (@media (prefers-color-scheme: dark)): Added.
+        (@media (prefers-dark-interface)): Deleted.
+        Drive-by: replace older `prefers-dark-interface` with modern `prefers-color-scheme: dark`.
+
 2019-08-15  Joseph Pecoraro  <pecor...@apple.com>
 
         Web Inspector: Update Esprima to trunk (minor fixes)

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.css (248734 => 248735)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.css	2019-08-15 18:41:53 UTC (rev 248734)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.css	2019-08-15 19:13:21 UTC (rev 248735)
@@ -53,7 +53,7 @@
     color: hsla(0, 0%, 0%, 0.2);
 }
 
-@media (prefers-dark-interface) {
+@media (prefers-color-scheme: dark) {
     .error-object-link-container {
         color: var(--text-color-secondary);
     }

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js (248734 => 248735)


--- trunk/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js	2019-08-15 18:41:53 UTC (rev 248734)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Layers3DContentView.js	2019-08-15 19:13:21 UTC (rev 248735)
@@ -144,10 +144,14 @@
         super.initialLayout();
 
         this._renderer = new THREE.WebGLRenderer({antialias: true});
-        const backgroundColor = window.getComputedStyle(document.documentElement).getPropertyValue("--background-color-content").trim();
-        this._renderer.setClearColor(backgroundColor);
         this._renderer.setSize(this.element.offsetWidth, this.element.offsetHeight);
 
+        let updateBackground = () => {
+            this._renderer.setClearColor(window.getComputedStyle(this.element).getPropertyValue("--background-color-content").trim());
+        };
+        window.matchMedia("(prefers-color-scheme: dark)").addListener(updateBackground);
+        updateBackground();
+
         this._camera = new THREE.PerspectiveCamera(45, this.element.offsetWidth / this.element.offsetHeight, 1, 100000);
 
         this._controls = new THREE.OrbitControls(this._camera, this._renderer.domElement);

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css (248734 => 248735)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css	2019-08-15 18:41:53 UTC (rev 248734)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css	2019-08-15 19:13:21 UTC (rev 248735)
@@ -137,7 +137,7 @@
     content: url(../Images/TypeObject.svg);
 }
 
-@media (prefers-dark-interface) {
+@media (prefers-color-scheme: dark) {
     .sidebar > .panel.navigation.sources > .content > .warning-banner {
         color: var(--yellow-highlight-text-color);
         background-color: var(--yellow-highlight-background-color);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to