Title: [248758] trunk/Source/WebInspectorUI
- Revision
- 248758
- Author
- drou...@apple.com
- Date
- 2019-08-15 19:08:29 -0700 (Thu, 15 Aug 2019)
Log Message
Web Inspector: REGRESSION(r244268): "Show Scope Chain on pause" setting has no effect
https://bugs.webkit.org/show_bug.cgi?id=200797
Reviewed by Joseph Pecoraro.
* UserInterface/Views/DebuggerTabContentView.js:
(WI.DebuggerTabContentView.prototype.showDetailsSidebarPanels):
* UserInterface/Views/SourcesTabContentView.js:
(WI.SourcesTabContentView.prototype.showDetailsSidebarPanels):
When the sidebar panel isn't visible `parentSidebar` is `null`. Use `WI.DetailsSidebar` instead.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (248757 => 248758)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-08-16 01:58:38 UTC (rev 248757)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-08-16 02:08:29 UTC (rev 248758)
@@ -1,5 +1,18 @@
2019-08-15 Devin Rousso <drou...@apple.com>
+ Web Inspector: REGRESSION(r244268): "Show Scope Chain on pause" setting has no effect
+ https://bugs.webkit.org/show_bug.cgi?id=200797
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/DebuggerTabContentView.js:
+ (WI.DebuggerTabContentView.prototype.showDetailsSidebarPanels):
+ * UserInterface/Views/SourcesTabContentView.js:
+ (WI.SourcesTabContentView.prototype.showDetailsSidebarPanels):
+ When the sidebar panel isn't visible `parentSidebar` is `null`. Use `WI.DetailsSidebar` instead.
+
+2019-08-15 Devin Rousso <drou...@apple.com>
+
Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'this._resource.initiatorSourceCodeLocation')
https://bugs.webkit.org/show_bug.cgi?id=200798
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js (248757 => 248758)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js 2019-08-16 01:58:38 UTC (rev 248757)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js 2019-08-16 02:08:29 UTC (rev 248758)
@@ -80,13 +80,9 @@
if (!scopeChainDetailsSidebarPanel)
return;
- let sidebar = scopeChainDetailsSidebarPanel.parentSidebar;
- if (!sidebar)
- return;
+ WI.detailsSidebar.selectedSidebarPanel = scopeChainDetailsSidebarPanel;
+ WI.detailsSidebar.collapsed = false;
- sidebar.selectedSidebarPanel = scopeChainDetailsSidebarPanel;
- sidebar.collapsed = false;
-
this._showScopeChainDetailsSidebarPanel = false;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourcesTabContentView.js (248757 => 248758)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourcesTabContentView.js 2019-08-16 01:58:38 UTC (rev 248757)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourcesTabContentView.js 2019-08-16 02:08:29 UTC (rev 248758)
@@ -83,13 +83,9 @@
if (!scopeChainDetailsSidebarPanel)
return;
- let sidebar = scopeChainDetailsSidebarPanel.parentSidebar;
- if (!sidebar)
- return;
+ WI.detailsSidebar.selectedSidebarPanel = scopeChainDetailsSidebarPanel;
+ WI.detailsSidebar.collapsed = false;
- sidebar.selectedSidebarPanel = scopeChainDetailsSidebarPanel;
- sidebar.collapsed = false;
-
this._showScopeChainDetailsSidebarPanel = false;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
