Title: [248905] trunk
- Revision
- 248905
- Author
- justin_mich...@apple.com
- Date
- 2019-08-20 10:35:46 -0700 (Tue, 20 Aug 2019)
Log Message
Fix InBounds speculation of typed array PutByVal and add extra step to integer range optimization to search for equality relationships on the RHS value
https://bugs.webkit.org/show_bug.cgi?id=200782
Reviewed by Saam Barati.
JSTests:
Skip long memcpy test on debug, and try to fix flakiness for recompilation count tests by disabling cjit.
* microbenchmarks/memcpy-typed-loop.js:
* stress/int8-repeat-in-then-out-of-bounds.js:
Tools:
* Scripts/run-jsc-stress-tests:
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (248904 => 248905)
--- trunk/JSTests/ChangeLog 2019-08-20 17:19:04 UTC (rev 248904)
+++ trunk/JSTests/ChangeLog 2019-08-20 17:35:46 UTC (rev 248905)
@@ -1,3 +1,15 @@
+2019-08-20 Justin Michaud <justin_mich...@apple.com>
+
+ Fix InBounds speculation of typed array PutByVal and add extra step to integer range optimization to search for equality relationships on the RHS value
+ https://bugs.webkit.org/show_bug.cgi?id=200782
+
+ Reviewed by Saam Barati.
+
+ Skip long memcpy test on debug, and try to fix flakiness for recompilation count tests by disabling cjit.
+
+ * microbenchmarks/memcpy-typed-loop.js:
+ * stress/int8-repeat-in-then-out-of-bounds.js:
+
2019-08-19 Alexey Shvayka <shvaikal...@gmail.com>
Proxy constructor should throw if handler is revoked Proxy
Modified: trunk/JSTests/microbenchmarks/memcpy-typed-loop.js (248904 => 248905)
--- trunk/JSTests/microbenchmarks/memcpy-typed-loop.js 2019-08-20 17:19:04 UTC (rev 248904)
+++ trunk/JSTests/microbenchmarks/memcpy-typed-loop.js 2019-08-20 17:35:46 UTC (rev 248905)
@@ -1,3 +1,4 @@
+//@ skip if $buildType == "debug"
function doTest(arr1, arr2) {
if (arr1.length != arr2.length)
return []
Modified: trunk/JSTests/stress/int8-repeat-in-then-out-of-bounds.js (248904 => 248905)
--- trunk/JSTests/stress/int8-repeat-in-then-out-of-bounds.js 2019-08-20 17:19:04 UTC (rev 248904)
+++ trunk/JSTests/stress/int8-repeat-in-then-out-of-bounds.js 2019-08-20 17:35:46 UTC (rev 248905)
@@ -1,4 +1,4 @@
-//@ defaultNoEagerRun
+//@ defaultNoEagerRun(*NO_CJIT_OPTIONS)
function foo(a, inBounds) {
a[0] = 1;
Modified: trunk/Tools/ChangeLog (248904 => 248905)
--- trunk/Tools/ChangeLog 2019-08-20 17:19:04 UTC (rev 248904)
+++ trunk/Tools/ChangeLog 2019-08-20 17:35:46 UTC (rev 248905)
@@ -1,3 +1,12 @@
+2019-08-20 Justin Michaud <justin_mich...@apple.com>
+
+ Fix InBounds speculation of typed array PutByVal and add extra step to integer range optimization to search for equality relationships on the RHS value
+ https://bugs.webkit.org/show_bug.cgi?id=200782
+
+ Reviewed by Saam Barati.
+
+ * Scripts/run-jsc-stress-tests:
+
2019-08-20 Darin Adler <da...@apple.com>
Variadic StringBuilder::append does not handle upconverting from 8-bit to 16-bit correctly
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (248904 => 248905)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2019-08-20 17:19:04 UTC (rev 248904)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2019-08-20 17:35:46 UTC (rev 248905)
@@ -885,22 +885,22 @@
# This is expected to not do eager runs because eager runs can have a lot of recompilations
# for reasons that don't arise in the real world. It's used for tests that assert convergence
# by counting recompilations.
-def defaultNoEagerRun
- runDefault
+def defaultNoEagerRun(*optionalTestSpecificOptions)
+ runDefault(*optionalTestSpecificOptions)
if $jitTests
- runNoLLInt
- runNoCJITValidatePhases
- runNoCJITCollectContinuously if shouldCollectContinuously?
+ runNoLLInt(*optionalTestSpecificOptions)
+ runNoCJITValidatePhases(*optionalTestSpecificOptions)
+ runNoCJITCollectContinuously(*optionalTestSpecificOptions) if shouldCollectContinuously?
return if !$isFTLPlatform
- runNoFTL
- runFTLNoCJITValidate
+ runNoFTL(*optionalTestSpecificOptions)
+ runFTLNoCJITValidate(*optionalTestSpecificOptions)
return if $mode == "basic"
- runFTLNoCJITNoInlineValidate
- runFTLNoCJITB3O0
+ runFTLNoCJITNoInlineValidate(*optionalTestSpecificOptions)
+ runFTLNoCJITB3O0(*optionalTestSpecificOptions)
end
end
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
