[webkit-changes] [248929] trunk/Source/JavaScriptCore

Tue, 20 Aug 2019 18:14:39 -0700

Title: [248929] trunk/Source/_javascript_Core
Revision
248929
Author
mark....@apple.com
Date
2019-08-20 18:13:02 -0700 (Tue, 20 Aug 2019)

Log Message

Remove superfluous size argument to allocateCell() for fixed size objects.
https://bugs.webkit.org/show_bug.cgi?id=200958

Reviewed by Yusuke Suzuki.

The size is already automatically computed by the allocateCell() template's default
arguments.  Removing these superfluous arguments will make it easier for us to
grep for cases where we do allocate variable size cells (for later analysis work).

* jsc.cpp:
(JSC::Masquerader::create):
(JSCMemoryFootprint::create):
* tools/JSDollarVM.cpp:
(JSC::JSDollarVMCallFrame::create):
(JSC::Element::create):
(JSC::Root::create):
(JSC::SimpleObject::create):
(JSC::ImpureGetter::create):
(JSC::CustomGetter::create):
(JSC::DOMJITNode::create):
(JSC::DOMJITGetter::create):
(JSC::DOMJITGetterComplex::create):
(JSC::DOMJITFunctionObject::create):
(JSC::DOMJITCheckSubClassObject::create):
(JSC::DOMJITGetterBaseJSObject::create):
(JSC::JSTestCustomGetterSetter::create):
(JSC::WasmStreamingParser::create):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (248928 => 248929)


--- trunk/Source/_javascript_Core/ChangeLog	2019-08-21 00:54:48 UTC (rev 248928)
+++ trunk/Source/_javascript_Core/ChangeLog	2019-08-21 01:13:02 UTC (rev 248929)
@@ -1,5 +1,35 @@
 2019-08-20  Mark Lam  <mark....@apple.com>
 
+        Remove superfluous size argument to allocateCell() for fixed size objects.
+        https://bugs.webkit.org/show_bug.cgi?id=200958
+
+        Reviewed by Yusuke Suzuki.
+
+        The size is already automatically computed by the allocateCell() template's default
+        arguments.  Removing these superfluous arguments will make it easier for us to
+        grep for cases where we do allocate variable size cells (for later analysis work).
+
+        * jsc.cpp:
+        (JSC::Masquerader::create):
+        (JSCMemoryFootprint::create):
+        * tools/JSDollarVM.cpp:
+        (JSC::JSDollarVMCallFrame::create):
+        (JSC::Element::create):
+        (JSC::Root::create):
+        (JSC::SimpleObject::create):
+        (JSC::ImpureGetter::create):
+        (JSC::CustomGetter::create):
+        (JSC::DOMJITNode::create):
+        (JSC::DOMJITGetter::create):
+        (JSC::DOMJITGetterComplex::create):
+        (JSC::DOMJITFunctionObject::create):
+        (JSC::DOMJITCheckSubClassObject::create):
+        (JSC::DOMJITGetterBaseJSObject::create):
+        (JSC::JSTestCustomGetterSetter::create):
+        (JSC::WasmStreamingParser::create):
+
+2019-08-20  Mark Lam  <mark....@apple.com>
+
         JSBigInt::m_length should be immutable.
         https://bugs.webkit.org/show_bug.cgi?id=200956

Modified: trunk/Source/_javascript_Core/jsc.cpp (248928 => 248929)


--- trunk/Source/_javascript_Core/jsc.cpp	2019-08-21 00:54:48 UTC (rev 248928)
+++ trunk/Source/_javascript_Core/jsc.cpp	2019-08-21 01:13:02 UTC (rev 248929)
@@ -1,6 +1,6 @@
 /*
  *  Copyright (C) 1999-2000 Harri Porten (por...@kde.org)
- *  Copyright (C) 2004-2018 Apple Inc. All rights reserved.
+ *  Copyright (C) 2004-2019 Apple Inc. All rights reserved.
  *  Copyright (C) 2006 Bjoern Graf (bjoern.g...@gmail.com)
  *
  *  This library is free software; you can redistribute it and/or
@@ -201,7 +201,7 @@
     {
         globalObject->masqueradesAsUndefinedWatchpoint()->fireAll(vm, "Masquerading object allocated");
         Structure* structure = createStructure(vm, globalObject, jsNull());
-        Masquerader* result = new (NotNull, allocateCell<Masquerader>(vm.heap, sizeof(Masquerader))) Masquerader(vm, structure);
+        Masquerader* result = new (NotNull, allocateCell<Masquerader>(vm.heap)) Masquerader(vm, structure);
         result->finishCreation(vm);
         return result;
     }
@@ -1392,7 +1392,7 @@
     static JSCMemoryFootprint* create(VM& vm, JSGlobalObject* globalObject)
     {
         Structure* structure = createStructure(vm, globalObject, jsNull());
-        JSCMemoryFootprint* footprint = new (NotNull, allocateCell<JSCMemoryFootprint>(vm.heap, sizeof(JSCMemoryFootprint))) JSCMemoryFootprint(vm, structure);
+        JSCMemoryFootprint* footprint = new (NotNull, allocateCell<JSCMemoryFootprint>(vm.heap)) JSCMemoryFootprint(vm, structure);
         footprint->finishCreation(vm);
         return footprint;
     }

Modified: trunk/Source/_javascript_Core/tools/JSDollarVM.cpp (248928 => 248929)


--- trunk/Source/_javascript_Core/tools/JSDollarVM.cpp	2019-08-21 00:54:48 UTC (rev 248928)
+++ trunk/Source/_javascript_Core/tools/JSDollarVM.cpp	2019-08-21 01:13:02 UTC (rev 248929)
@@ -79,7 +79,7 @@
         VM& vm = exec->vm();
         JSGlobalObject* globalObject = exec->lexicalGlobalObject();
         Structure* structure = createStructure(vm, globalObject, jsNull());
-        JSDollarVMCallFrame* frame = new (NotNull, allocateCell<JSDollarVMCallFrame>(vm.heap, sizeof(JSDollarVMCallFrame))) JSDollarVMCallFrame(vm, structure);
+        JSDollarVMCallFrame* frame = new (NotNull, allocateCell<JSDollarVMCallFrame>(vm.heap)) JSDollarVMCallFrame(vm, structure);
         frame->finishCreation(vm, exec, requestedFrameIndex);
         return frame;
     }
@@ -148,7 +148,7 @@
     static Element* create(VM& vm, JSGlobalObject* globalObject, Root* root)
     {
         Structure* structure = createStructure(vm, globalObject, jsNull());
-        Element* element = new (NotNull, allocateCell<Element>(vm.heap, sizeof(Element))) Element(vm, structure);
+        Element* element = new (NotNull, allocateCell<Element>(vm.heap)) Element(vm, structure);
         element->finishCreation(vm, root);
         return element;
     }
@@ -209,7 +209,7 @@
     static Root* create(VM& vm, JSGlobalObject* globalObject)
     {
         Structure* structure = createStructure(vm, globalObject, jsNull());
-        Root* root = new (NotNull, allocateCell<Root>(vm.heap, sizeof(Root))) Root(vm, structure);
+        Root* root = new (NotNull, allocateCell<Root>(vm.heap)) Root(vm, structure);
         root->finishCreation(vm);
         return root;
     }
@@ -247,7 +247,7 @@
     static SimpleObject* create(VM& vm, JSGlobalObject* globalObject)
     {
         Structure* structure = createStructure(vm, globalObject, jsNull());
-        SimpleObject* simpleObject = new (NotNull, allocateCell<SimpleObject>(vm.heap, sizeof(SimpleObject))) SimpleObject(vm, structure);
+        SimpleObject* simpleObject = new (NotNull, allocateCell<SimpleObject>(vm.heap)) SimpleObject(vm, structure);
         simpleObject->finishCreation(vm);
         return simpleObject;
     }
@@ -300,7 +300,7 @@
 
     static ImpureGetter* create(VM& vm, Structure* structure, JSObject* delegate)
     {
-        ImpureGetter* getter = new (NotNull, allocateCell<ImpureGetter>(vm.heap, sizeof(ImpureGetter))) ImpureGetter(vm, structure);
+        ImpureGetter* getter = new (NotNull, allocateCell<ImpureGetter>(vm.heap)) ImpureGetter(vm, structure);
         getter->finishCreation(vm, delegate);
         return getter;
     }
@@ -362,7 +362,7 @@
 
     static CustomGetter* create(VM& vm, Structure* structure)
     {
-        CustomGetter* getter = new (NotNull, allocateCell<CustomGetter>(vm.heap, sizeof(CustomGetter))) CustomGetter(vm, structure);
+        CustomGetter* getter = new (NotNull, allocateCell<CustomGetter>(vm.heap)) CustomGetter(vm, structure);
         getter->finishCreation(vm);
         return getter;
     }
@@ -555,7 +555,7 @@
 
     static DOMJITNode* create(VM& vm, Structure* structure)
     {
-        DOMJITNode* getter = new (NotNull, allocateCell<DOMJITNode>(vm.heap, sizeof(DOMJITNode))) DOMJITNode(vm, structure);
+        DOMJITNode* getter = new (NotNull, allocateCell<DOMJITNode>(vm.heap)) DOMJITNode(vm, structure);
         getter->finishCreation(vm);
         return getter;
     }
@@ -589,7 +589,7 @@
 
     static DOMJITGetter* create(VM& vm, Structure* structure)
     {
-        DOMJITGetter* getter = new (NotNull, allocateCell<DOMJITGetter>(vm.heap, sizeof(DOMJITGetter))) DOMJITGetter(vm, structure);
+        DOMJITGetter* getter = new (NotNull, allocateCell<DOMJITGetter>(vm.heap)) DOMJITGetter(vm, structure);
         getter->finishCreation(vm);
         return getter;
     }
@@ -672,7 +672,7 @@
 
     static DOMJITGetterComplex* create(VM& vm, JSGlobalObject* globalObject, Structure* structure)
     {
-        DOMJITGetterComplex* getter = new (NotNull, allocateCell<DOMJITGetterComplex>(vm.heap, sizeof(DOMJITGetterComplex))) DOMJITGetterComplex(vm, structure);
+        DOMJITGetterComplex* getter = new (NotNull, allocateCell<DOMJITGetterComplex>(vm.heap)) DOMJITGetterComplex(vm, structure);
         getter->finishCreation(vm, globalObject);
         return getter;
     }
@@ -784,7 +784,7 @@
 
     static DOMJITFunctionObject* create(VM& vm, JSGlobalObject* globalObject, Structure* structure)
     {
-        DOMJITFunctionObject* object = new (NotNull, allocateCell<DOMJITFunctionObject>(vm.heap, sizeof(DOMJITFunctionObject))) DOMJITFunctionObject(vm, structure);
+        DOMJITFunctionObject* object = new (NotNull, allocateCell<DOMJITFunctionObject>(vm.heap)) DOMJITFunctionObject(vm, structure);
         object->finishCreation(vm, globalObject);
         return object;
     }
@@ -855,7 +855,7 @@
 
     static DOMJITCheckSubClassObject* create(VM& vm, JSGlobalObject* globalObject, Structure* structure)
     {
-        DOMJITCheckSubClassObject* object = new (NotNull, allocateCell<DOMJITCheckSubClassObject>(vm.heap, sizeof(DOMJITCheckSubClassObject))) DOMJITCheckSubClassObject(vm, structure);
+        DOMJITCheckSubClassObject* object = new (NotNull, allocateCell<DOMJITCheckSubClassObject>(vm.heap)) DOMJITCheckSubClassObject(vm, structure);
         object->finishCreation(vm, globalObject);
         return object;
     }
@@ -908,7 +908,7 @@
 
     static DOMJITGetterBaseJSObject* create(VM& vm, Structure* structure)
     {
-        DOMJITGetterBaseJSObject* getter = new (NotNull, allocateCell<DOMJITGetterBaseJSObject>(vm.heap, sizeof(DOMJITGetterBaseJSObject))) DOMJITGetterBaseJSObject(vm, structure);
+        DOMJITGetterBaseJSObject* getter = new (NotNull, allocateCell<DOMJITGetterBaseJSObject>(vm.heap)) DOMJITGetterBaseJSObject(vm, structure);
         getter->finishCreation(vm);
         return getter;
     }
@@ -998,7 +998,7 @@
 
     static JSTestCustomGetterSetter* create(VM& vm, JSGlobalObject*, Structure* structure)
     {
-        JSTestCustomGetterSetter* result = new (NotNull, allocateCell<JSTestCustomGetterSetter>(vm.heap, sizeof(JSTestCustomGetterSetter))) JSTestCustomGetterSetter(vm, structure);
+        JSTestCustomGetterSetter* result = new (NotNull, allocateCell<JSTestCustomGetterSetter>(vm.heap)) JSTestCustomGetterSetter(vm, structure);
         result->finishCreation(vm);
         return result;
     }
@@ -1121,7 +1121,7 @@
     static WasmStreamingParser* create(VM& vm, JSGlobalObject* globalObject)
     {
         Structure* structure = createStructure(vm, globalObject, jsNull());
-        WasmStreamingParser* result = new (NotNull, allocateCell<WasmStreamingParser>(vm.heap, sizeof(WasmStreamingParser))) WasmStreamingParser(vm, structure);
+        WasmStreamingParser* result = new (NotNull, allocateCell<WasmStreamingParser>(vm.heap)) WasmStreamingParser(vm, structure);
         result->finishCreation(vm);
         return result;
     }

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to