Title: [249343] trunk/Source
Revision
249343
Author
achristen...@apple.com
Date
2019-08-30 13:27:33 -0700 (Fri, 30 Aug 2019)

Log Message

Remove HAVE_CFNETWORK_WITH_AUTO_ADDED_HTTP_HEADER_SUPPRESSION_SUPPORT conditional
https://bugs.webkit.org/show_bug.cgi?id=201280

Reviewed by Youenn Fablet.

Source/WebCore/PAL:

* pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

Source/WTF:

* wtf/Platform.h:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (249342 => 249343)


--- trunk/Source/WTF/ChangeLog	2019-08-30 20:26:08 UTC (rev 249342)
+++ trunk/Source/WTF/ChangeLog	2019-08-30 20:27:33 UTC (rev 249343)
@@ -1,5 +1,14 @@
 2019-08-30  Alex Christensen  <achristen...@webkit.org>
 
+        Remove HAVE_CFNETWORK_WITH_AUTO_ADDED_HTTP_HEADER_SUPPRESSION_SUPPORT conditional
+        https://bugs.webkit.org/show_bug.cgi?id=201280
+
+        Reviewed by Youenn Fablet.
+
+        * wtf/Platform.h:
+
+2019-08-30  Alex Christensen  <achristen...@webkit.org>
+
         Remove HAVE_CFNETWORK_WITH_IGNORE_HSTS conditional
         https://bugs.webkit.org/show_bug.cgi?id=201279
 

Modified: trunk/Source/WTF/wtf/Platform.h (249342 => 249343)


--- trunk/Source/WTF/wtf/Platform.h	2019-08-30 20:26:08 UTC (rev 249342)
+++ trunk/Source/WTF/wtf/Platform.h	2019-08-30 20:27:33 UTC (rev 249343)
@@ -1435,14 +1435,6 @@
 #endif
 #endif
 
-#if PLATFORM(MAC) || PLATFORM(IOS_FAMILY)
-#define HAVE_CFNETWORK_WITH_AUTO_ADDED_HTTP_HEADER_SUPPRESSION_SUPPORT 1
-/* FIXME: Does this work, and is this needed on other iOS family platforms? */
-#if PLATFORM(MAC) || PLATFORM(IOS)
-#define USE_CFNETWORK_AUTO_ADDED_HTTP_HEADER_SUPPRESSION 1
-#endif
-#endif
-
 #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || PLATFORM(GTK)
 #define HAVE_OS_DARK_MODE_SUPPORT 1
 #endif

Modified: trunk/Source/WebCore/PAL/ChangeLog (249342 => 249343)


--- trunk/Source/WebCore/PAL/ChangeLog	2019-08-30 20:26:08 UTC (rev 249342)
+++ trunk/Source/WebCore/PAL/ChangeLog	2019-08-30 20:27:33 UTC (rev 249343)
@@ -1,3 +1,12 @@
+2019-08-30  Alex Christensen  <achristen...@webkit.org>
+
+        Remove HAVE_CFNETWORK_WITH_AUTO_ADDED_HTTP_HEADER_SUPPRESSION_SUPPORT conditional
+        https://bugs.webkit.org/show_bug.cgi?id=201280
+
+        Reviewed by Youenn Fablet.
+
+        * pal/spi/cf/CFNetworkSPI.h:
+
 2019-08-29  Keith Rollin  <krol...@apple.com>
 
         Remove HAVE_PASSKIT_GRANULAR_ERRORS conditional

Modified: trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (249342 => 249343)


--- trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h	2019-08-30 20:26:08 UTC (rev 249342)
+++ trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h	2019-08-30 20:27:33 UTC (rev 249343)
@@ -192,9 +192,7 @@
 #if PLATFORM(IOS_FAMILY)
 @property (nullable, copy) NSString *_CTDataConnectionServiceType;
 #endif
-#if HAVE(CFNETWORK_WITH_AUTO_ADDED_HTTP_HEADER_SUPPRESSION_SUPPORT)
 @property (nullable, copy) NSSet *_suppressedAutoAddedHTTPHeaders;
-#endif
 #if PLATFORM(WATCHOS)
 @property NSURLSessionCompanionProxyPreference _companionProxyPreference;
 #endif

Modified: trunk/Source/WebKit/ChangeLog (249342 => 249343)


--- trunk/Source/WebKit/ChangeLog	2019-08-30 20:26:08 UTC (rev 249342)
+++ trunk/Source/WebKit/ChangeLog	2019-08-30 20:27:33 UTC (rev 249343)
@@ -1,5 +1,15 @@
 2019-08-30  Alex Christensen  <achristen...@webkit.org>
 
+        Remove HAVE_CFNETWORK_WITH_AUTO_ADDED_HTTP_HEADER_SUPPRESSION_SUPPORT conditional
+        https://bugs.webkit.org/show_bug.cgi?id=201280
+
+        Reviewed by Youenn Fablet.
+
+        * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+        (WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+
+2019-08-30  Alex Christensen  <achristen...@webkit.org>
+
         Remove HAVE_CFNETWORK_WITH_IGNORE_HSTS conditional
         https://bugs.webkit.org/show_bug.cgi?id=201279
 

Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (249342 => 249343)


--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2019-08-30 20:26:08 UTC (rev 249342)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2019-08-30 20:27:33 UTC (rev 249343)
@@ -946,10 +946,8 @@
     configuration._preventsAppSSO = true;
 #endif
 
-#if USE(CFNETWORK_AUTO_ADDED_HTTP_HEADER_SUPPRESSION)
     // Without this, CFNetwork would sometimes add a Content-Type header to our requests (rdar://problem/34748470).
     configuration._suppressedAutoAddedHTTPHeaders = [NSSet setWithObject:@"Content-Type"];
-#endif
 
     if (parameters.allowsCellularAccess == AllowsCellularAccess::No)
         configuration.allowsCellularAccess = NO;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to