Title: [249347] trunk/Source/_javascript_Core
- Revision
- 249347
- Author
- mark....@apple.com
- Date
- 2019-08-30 15:02:37 -0700 (Fri, 30 Aug 2019)
Log Message
Remove some obsolete statements that have no effect.
https://bugs.webkit.org/show_bug.cgi?id=201357
Reviewed by Saam Barati.
This patch removes 3 statements that look like this:
result->butterfly(); // Ensure that the butterfly is in to-space.
The statement just reads a field and does nothing with it. This is a no-op
logic-wise, and the comment that accompanies it is obsolete.
* dfg/DFGOperations.cpp:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (249346 => 249347)
--- trunk/Source/_javascript_Core/ChangeLog 2019-08-30 21:45:54 UTC (rev 249346)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-08-30 22:02:37 UTC (rev 249347)
@@ -1,5 +1,21 @@
2019-08-30 Mark Lam <mark....@apple.com>
+ Remove some obsolete statements that have no effect.
+ https://bugs.webkit.org/show_bug.cgi?id=201357
+
+ Reviewed by Saam Barati.
+
+ This patch removes 3 statements that look like this:
+
+ result->butterfly(); // Ensure that the butterfly is in to-space.
+
+ The statement just reads a field and does nothing with it. This is a no-op
+ logic-wise, and the comment that accompanies it is obsolete.
+
+ * dfg/DFGOperations.cpp:
+
+2019-08-30 Mark Lam <mark....@apple.com>
+
Fix a bug in SlotVisitor::reportZappedCellAndCrash() and also capture more information.
https://bugs.webkit.org/show_bug.cgi?id=201345
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (249346 => 249347)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2019-08-30 21:45:54 UTC (rev 249346)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2019-08-30 22:02:37 UTC (rev 249347)
@@ -2734,7 +2734,6 @@
}
JSObject* result = JSObject::createRawObject(exec, structure, butterfly);
- result->butterfly(); // Ensure that the butterfly is in to-space.
return bitwise_cast<char*>(result);
}
@@ -2749,7 +2748,6 @@
}
JSObject* result = JSObject::createRawObject(exec, structure, butterfly);
- result->butterfly(); // Ensure that the butterfly is in to-space.
return result;
}
@@ -2771,7 +2769,6 @@
// Paradoxically this may allocate a JSArray. That's totally cool.
JSObject* result = JSObject::createRawObject(exec, structure, butterfly);
- result->butterfly(); // Ensure that the butterfly is in to-space.
return result;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
