Title: [249624] trunk/Source/WebKit
- Revision
- 249624
- Author
- timothy_hor...@apple.com
- Date
- 2019-09-07 21:17:46 -0700 (Sat, 07 Sep 2019)
Log Message
Marking up a note on iOS results in a PDF with no contents
https://bugs.webkit.org/show_bug.cgi?id=201530
<rdar://problem/53686019>
Unreviewed follow-up.
* UIProcess/ios/WKContentView.mm:
(-[WKContentView _waitForDrawToPDFCallback]):
Remove an ASSERT_NOT_REACHED that fires if the synchronous wait for printing
times out. This is a totally legitimite situation that can occur if the process
crashes; there's no need for an assert there.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (249623 => 249624)
--- trunk/Source/WebKit/ChangeLog 2019-09-08 03:58:26 UTC (rev 249623)
+++ trunk/Source/WebKit/ChangeLog 2019-09-08 04:17:46 UTC (rev 249624)
@@ -1,3 +1,17 @@
+2019-09-07 Tim Horton <timothy_hor...@apple.com>
+
+ Marking up a note on iOS results in a PDF with no contents
+ https://bugs.webkit.org/show_bug.cgi?id=201530
+ <rdar://problem/53686019>
+
+ Unreviewed follow-up.
+
+ * UIProcess/ios/WKContentView.mm:
+ (-[WKContentView _waitForDrawToPDFCallback]):
+ Remove an ASSERT_NOT_REACHED that fires if the synchronous wait for printing
+ times out. This is a totally legitimite situation that can occur if the process
+ crashes; there's no need for an assert there.
+
2019-09-07 Alex Christensen <achristen...@webkit.org>
Null check m_client in NetworkDataTask::didReceiveResponse
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentView.mm (249623 => 249624)
--- trunk/Source/WebKit/UIProcess/ios/WKContentView.mm 2019-09-08 03:58:26 UTC (rev 249623)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentView.mm 2019-09-08 04:17:46 UTC (rev 249624)
@@ -744,10 +744,8 @@
- (BOOL)_waitForDrawToPDFCallback
{
- if (!_page->process().connection()->waitForAndDispatchImmediately<Messages::WebPageProxy::DrawToPDFCallback>(_page->webPageID(), Seconds::infinity())) {
- ASSERT_NOT_REACHED();
+ if (!_page->process().connection()->waitForAndDispatchImmediately<Messages::WebPageProxy::DrawToPDFCallback>(_page->webPageID(), Seconds::infinity()))
return false;
- }
ASSERT(!_isPrintingToPDF);
return true;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
