Diff
Modified: trunk/Source/WebCore/ChangeLog (249903 => 249904)
--- trunk/Source/WebCore/ChangeLog 2019-09-16 16:56:35 UTC (rev 249903)
+++ trunk/Source/WebCore/ChangeLog 2019-09-16 17:15:31 UTC (rev 249904)
@@ -1,3 +1,19 @@
+2019-09-16 Andres Gonzalez <andresg...@apple.com>
+
+ Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client.
+ https://bugs.webkit.org/show_bug.cgi?id=201820
+
+ Reviewed by Chris Fleizach.
+
+ No new tests necessary since this is a method rename.
+
+ * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityInsertText:]):
+ (-[WebAccessibilityObjectWrapper _accessibilityInsertText:]): Deleted.
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityInsertText:]):
+ (-[WebAccessibilityObjectWrapper _accessibilityInsertText:]): Deleted.
+
2019-09-16 Zalan Bujtas <za...@apple.com>
[LFC] Always provide a containing block width value to compute* functions.
Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (249903 => 249904)
--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2019-09-16 16:56:35 UTC (rev 249903)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2019-09-16 17:15:31 UTC (rev 249904)
@@ -2573,7 +2573,7 @@
return m_object->replaceTextInRange(string, PlainTextRange(range));
}
-- (BOOL)_accessibilityInsertText:(NSString *)text
+- (BOOL)accessibilityInsertText:(NSString *)text
{
if (![self _prepareAccessibilityCall])
return NO;
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (249903 => 249904)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2019-09-16 16:56:35 UTC (rev 249903)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2019-09-16 17:15:31 UTC (rev 249904)
@@ -3849,7 +3849,7 @@
return m_object->replaceTextInRange(string, PlainTextRange(range));
}
-- (BOOL)_accessibilityInsertText:(NSString *)text
+- (BOOL)accessibilityInsertText:(NSString *)text
{
if (![self updateObjectBackingStore])
return NO;
Modified: trunk/Tools/ChangeLog (249903 => 249904)
--- trunk/Tools/ChangeLog 2019-09-16 16:56:35 UTC (rev 249903)
+++ trunk/Tools/ChangeLog 2019-09-16 17:15:31 UTC (rev 249904)
@@ -1,3 +1,19 @@
+2019-09-16 Andres Gonzalez <andresg...@apple.com>
+
+ Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client.
+ https://bugs.webkit.org/show_bug.cgi?id=201820
+
+ Reviewed by Chris Fleizach.
+
+ * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
+ (AccessibilityUIElement::insertText):
+ * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
+ (AccessibilityUIElement::insertText):
+ * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
+ (WTR::AccessibilityUIElement::insertText):
+ * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
+ (WTR::AccessibilityUIElement::insertText):
+
2019-09-16 David Kilzer <ddkil...@apple.com>
Fix leaks in DumpRenderTree and WebKitTestRunner
Modified: trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm (249903 => 249904)
--- trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm 2019-09-16 16:56:35 UTC (rev 249903)
+++ trunk/Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm 2019-09-16 17:15:31 UTC (rev 249904)
@@ -75,7 +75,7 @@
- (NSAttributedString *)attributedStringForElement;
- (NSArray *)elementsForRange:(NSRange)range;
- (NSString *)selectionRangeString;
-- (BOOL)_accessibilityInsertText:(NSString *)text;
+- (BOOL)accessibilityInsertText:(NSString *)text;
- (CGPoint)accessibilityClickPoint;
- (void)accessibilityModifySelection:(WebCore::TextGranularity)granularity increase:(BOOL)increase;
- (void)accessibilitySetPostedNotificationCallback:(AXPostedNotificationCallback)function withContext:(void*)context;
@@ -494,7 +494,7 @@
bool AccessibilityUIElement::insertText(JSStringRef text)
{
- return [m_element _accessibilityInsertText:[NSString stringWithJSStringRef:text]];
+ return [m_element accessibilityInsertText:[NSString stringWithJSStringRef:text]];
}
void AccessibilityUIElement::resetSelectedTextMarkerRange()
Modified: trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm (249903 => 249904)
--- trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm 2019-09-16 16:56:35 UTC (rev 249903)
+++ trunk/Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm 2019-09-16 17:15:31 UTC (rev 249904)
@@ -71,7 +71,7 @@
@interface NSObject (WebKitAccessibilityAdditions)
- (BOOL)accessibilityReplaceRange:(NSRange)range withText:(NSString *)string;
-- (BOOL)_accessibilityInsertText:(NSString *)text;
+- (BOOL)accessibilityInsertText:(NSString *)text;
- (NSArray *)accessibilityArrayAttributeValues:(NSString *)attribute index:(NSUInteger)index maxCount:(NSUInteger)maxCount;
- (NSUInteger)accessibilityIndexOfChild:(id)child;
- (NSUInteger)accessibilityArrayAttributeCount:(NSString *)attribute;
@@ -1733,7 +1733,7 @@
bool AccessibilityUIElement::insertText(JSStringRef text)
{
BEGIN_AX_OBJC_EXCEPTIONS
- return [m_element _accessibilityInsertText:[NSString stringWithJSStringRef:text]];
+ return [m_element accessibilityInsertText:[NSString stringWithJSStringRef:text]];
END_AX_OBJC_EXCEPTIONS
return false;
}
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm (249903 => 249904)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm 2019-09-16 16:56:35 UTC (rev 249903)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm 2019-09-16 17:15:31 UTC (rev 249904)
@@ -58,7 +58,7 @@
- (NSRange)_accessibilitySelectedTextRange;
- (void)_accessibilitySetSelectedTextRange:(NSRange)range;
- (BOOL)accessibilityReplaceRange:(NSRange)range withText:(NSString *)string;
-- (BOOL)_accessibilityInsertText:(NSString *)text;
+- (BOOL)accessibilityInsertText:(NSString *)text;
- (void)accessibilitySetPostedNotificationCallback:(AXPostedNotificationCallback)function withContext:(void*)context;
- (CGFloat)_accessibilityMinValue;
- (CGFloat)_accessibilityMaxValue;
@@ -1180,7 +1180,7 @@
bool AccessibilityUIElement::insertText(JSStringRef text)
{
- return [m_element _accessibilityInsertText:[NSString stringWithJSStringRef:text]];
+ return [m_element accessibilityInsertText:[NSString stringWithJSStringRef:text]];
}
RefPtr<AccessibilityTextMarker> AccessibilityUIElement::textMarkerForPoint(int x, int y)
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm (249903 => 249904)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2019-09-16 16:56:35 UTC (rev 249903)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm 2019-09-16 17:15:31 UTC (rev 249904)
@@ -75,7 +75,7 @@
@interface NSObject (WebKitAccessibilityAdditions)
- (BOOL)accessibilityReplaceRange:(NSRange)range withText:(NSString *)string;
-- (BOOL)_accessibilityInsertText:(NSString *)text;
+- (BOOL)accessibilityInsertText:(NSString *)text;
- (NSArray *)accessibilityArrayAttributeValues:(NSString *)attribute index:(NSUInteger)index maxCount:(NSUInteger)maxCount;
- (NSUInteger)accessibilityIndexOfChild:(id)child;
- (NSUInteger)accessibilityArrayAttributeCount:(NSString *)attribute;
@@ -1902,7 +1902,7 @@
bool AccessibilityUIElement::insertText(JSStringRef text)
{
BEGIN_AX_OBJC_EXCEPTIONS
- return [m_element _accessibilityInsertText:[NSString stringWithJSStringRef:text]];
+ return [m_element accessibilityInsertText:[NSString stringWithJSStringRef:text]];
END_AX_OBJC_EXCEPTIONS
return false;
}
