Title: [250752] trunk/Source
- Revision
- 250752
- Author
- ross.kirsl...@sony.com
- Date
- 2019-10-04 15:23:56 -0700 (Fri, 04 Oct 2019)
Log Message
Socket-based RWI should base64-encode backend commands on client, not server
https://bugs.webkit.org/show_bug.cgi?id=202605
Reviewed by Don Olmstead.
Source/_javascript_Core:
* inspector/remote/socket/RemoteInspectorServer.cpp:
(Inspector::RemoteInspectorServer::setupInspectorClient):
Source/WebKit:
* UIProcess/socket/RemoteInspectorClient.cpp:
(WebKit::RemoteInspectorClient::setBackendCommands):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (250751 => 250752)
--- trunk/Source/_javascript_Core/ChangeLog 2019-10-04 22:22:38 UTC (rev 250751)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-10-04 22:23:56 UTC (rev 250752)
@@ -1,3 +1,13 @@
+2019-10-04 Ross Kirsling <ross.kirsl...@sony.com>
+
+ Socket-based RWI should base64-encode backend commands on client, not server
+ https://bugs.webkit.org/show_bug.cgi?id=202605
+
+ Reviewed by Don Olmstead.
+
+ * inspector/remote/socket/RemoteInspectorServer.cpp:
+ (Inspector::RemoteInspectorServer::setupInspectorClient):
+
2019-10-04 Saam Barati <sbar...@apple.com>
Allow OSR exit to the LLInt
Modified: trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.cpp (250751 => 250752)
--- trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.cpp 2019-10-04 22:22:38 UTC (rev 250751)
+++ trunk/Source/_javascript_Core/inspector/remote/socket/RemoteInspectorServer.cpp 2019-10-04 22:23:56 UTC (rev 250752)
@@ -33,7 +33,6 @@
#include <wtf/JSONValues.h>
#include <wtf/MainThread.h>
#include <wtf/RunLoop.h>
-#include <wtf/text/Base64.h>
namespace Inspector {
@@ -152,7 +151,7 @@
auto backendCommandsEvent = JSON::Object::create();
backendCommandsEvent->setString("event"_s, "BackendCommands"_s);
- backendCommandsEvent->setString("message"_s, base64Encode(backendCommands().utf8()));
+ backendCommandsEvent->setString("message"_s, backendCommands());
sendWebInspectorEvent(m_clientConnection.value(), backendCommandsEvent->toJSONString());
auto setupEvent = JSON::Object::create();
Modified: trunk/Source/WebKit/ChangeLog (250751 => 250752)
--- trunk/Source/WebKit/ChangeLog 2019-10-04 22:22:38 UTC (rev 250751)
+++ trunk/Source/WebKit/ChangeLog 2019-10-04 22:23:56 UTC (rev 250752)
@@ -1,3 +1,13 @@
+2019-10-04 Ross Kirsling <ross.kirsl...@sony.com>
+
+ Socket-based RWI should base64-encode backend commands on client, not server
+ https://bugs.webkit.org/show_bug.cgi?id=202605
+
+ Reviewed by Don Olmstead.
+
+ * UIProcess/socket/RemoteInspectorClient.cpp:
+ (WebKit::RemoteInspectorClient::setBackendCommands):
+
2019-10-04 Jiewen Tan <jiewen_...@apple.com>
Unreviewed, build fix after r250729
Modified: trunk/Source/WebKit/UIProcess/socket/RemoteInspectorClient.cpp (250751 => 250752)
--- trunk/Source/WebKit/UIProcess/socket/RemoteInspectorClient.cpp 2019-10-04 22:22:38 UTC (rev 250751)
+++ trunk/Source/WebKit/UIProcess/socket/RemoteInspectorClient.cpp 2019-10-04 22:23:56 UTC (rev 250752)
@@ -30,6 +30,7 @@
#include "RemoteWebInspectorProxy.h"
#include <wtf/MainThread.h>
+#include <wtf/text/Base64.h>
namespace WebKit {
@@ -193,7 +194,7 @@
if (!event.message || event.message->isEmpty())
return;
- m_backendCommandsURL = makeString("data:text/_javascript_;base64,", event.message.value());
+ m_backendCommandsURL = makeString("data:text/_javascript_;base64,", base64Encode(event.message->utf8()));
}
void RemoteInspectorClient::setTargetList(const Event& event)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
