Title: [250877] trunk/Tools
- Revision
- 250877
- Author
- jbed...@apple.com
- Date
- 2019-10-08 16:38:12 -0700 (Tue, 08 Oct 2019)
Log Message
REGRESSION (r250375): [old EWS] JSC EWS is always marking Patches as success
https://bugs.webkit.org/show_bug.cgi?id=202419
Rubber-stamped by Aakash Jain.
* Scripts/webkitpy/common/system/executive.py:
(Executive._run_command_with_teed_output): Return exit code.
* Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.test_run_command_with_bad_command): Test that exceptions are raised
For non-zero exit codes.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (250876 => 250877)
--- trunk/Tools/ChangeLog 2019-10-08 23:23:01 UTC (rev 250876)
+++ trunk/Tools/ChangeLog 2019-10-08 23:38:12 UTC (rev 250877)
@@ -1,5 +1,18 @@
2019-10-08 Jonathan Bedard <jbed...@apple.com>
+ REGRESSION (r250375): [old EWS] JSC EWS is always marking Patches as success
+ https://bugs.webkit.org/show_bug.cgi?id=202419
+
+ Rubber-stamped by Aakash Jain.
+
+ * Scripts/webkitpy/common/system/executive.py:
+ (Executive._run_command_with_teed_output): Return exit code.
+ * Scripts/webkitpy/common/system/executive_unittest.py:
+ (ExecutiveTest.test_run_command_with_bad_command): Test that exceptions are raised
+ For non-zero exit codes.
+
+2019-10-08 Jonathan Bedard <jbed...@apple.com>
+
Python 3: Add support to auto-importer
https://bugs.webkit.org/show_bug.cgi?id=201955
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (250876 => 250877)
--- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2019-10-08 23:23:01 UTC (rev 250876)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2019-10-08 23:38:12 UTC (rev 250877)
@@ -128,6 +128,7 @@
while child_process.poll() is None:
output_line = child_process.stdout.readline()
teed_output.write(unicode_compatibility.decode_for(output_line, str))
+ return child_process.poll()
# FIXME: Remove this deprecated method and move callers to run_command.
# FIXME: This method is a hack to allow running command which both
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py (250876 => 250877)
--- trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py 2019-10-08 23:23:01 UTC (rev 250876)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive_unittest.py 2019-10-08 23:38:12 UTC (rev 250877)
@@ -105,9 +105,10 @@
self.assert_interpreter_for_content('ruby', '#!/usr/bin/ruby')
def test_run_command_with_bad_command(self):
- def run_bad_command():
- Executive().run_command(["foo_bar_command_blah"], ignore_errors=True, return_exit_code=True)
- self.assertRaises(OSError, run_bad_command)
+ self.assertRaises(OSError, lambda: Executive().run_command(["foo_bar_command_blah"], ignore_errors=True, return_exit_code=True))
+ self.assertRaises(OSError, lambda: Executive().run_and_throw_if_fail(["foo_bar_command_blah"], quiet=True))
+ self.assertRaises(ScriptError, lambda: Executive().run_command(['python', '-c', 'import sys; sys.exit(1)']))
+ self.assertRaises(ScriptError, lambda: Executive().run_and_throw_if_fail(['python', '-c', 'import sys; sys.exit(1)'], quiet=True))
def test_run_command_args_type(self):
executive = Executive()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
