Title: [250884] trunk/LayoutTests
- Revision
- 250884
- Author
- mmaxfi...@apple.com
- Date
- 2019-10-08 19:12:04 -0700 (Tue, 08 Oct 2019)
Log Message
Make fast/text/complex-initial-advance.html more robust
https://bugs.webkit.org/show_bug.cgi?id=202708
<rdar://problem/49539493>
Reviewed by Tim Horton.
We are hitting floating point precision issues. Fortunately, the part of the text that is
hitting these issues isn't actually necessary for the test.
* fast/text/complex-initial-advance-expected.html:
* fast/text/complex-initial-advance.html:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (250883 => 250884)
--- trunk/LayoutTests/ChangeLog 2019-10-09 01:54:12 UTC (rev 250883)
+++ trunk/LayoutTests/ChangeLog 2019-10-09 02:12:04 UTC (rev 250884)
@@ -1,3 +1,18 @@
+2019-10-08 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ Make fast/text/complex-initial-advance.html more robust
+ https://bugs.webkit.org/show_bug.cgi?id=202708
+ <rdar://problem/49539493>
+
+ Reviewed by Tim Horton.
+
+ We are hitting floating point precision issues. Fortunately, the part of the text that is
+ hitting these issues isn't actually necessary for the test.
+
+ * fast/text/complex-initial-advance-expected.html:
+ * fast/text/complex-initial-advance.html:
+ * platform/mac/TestExpectations:
+
2019-10-08 Devin Rousso <drou...@apple.com>
Web Inspector: Canvas: modifications to shader modules can be shared between vertex/fragment shaders
Modified: trunk/LayoutTests/fast/text/complex-initial-advance-expected.html (250883 => 250884)
--- trunk/LayoutTests/fast/text/complex-initial-advance-expected.html 2019-10-09 01:54:12 UTC (rev 250883)
+++ trunk/LayoutTests/fast/text/complex-initial-advance-expected.html 2019-10-09 02:12:04 UTC (rev 250884)
@@ -4,6 +4,7 @@
<meta charset="utf-8">
</head>
<body style="font-family: Geeza Pro; text-rendering: optimizeSpeed;">
-<span>مليئ حياةٍ مليئ</span>
+<div>This test makes sure that text with an initial advance is rendered correctly. The test passes if the ◌ٍ marks are positioned in the right place below the ة character below.</div>
+<span>حياةٍ مليئ</span>
</body>
</html>
Modified: trunk/LayoutTests/fast/text/complex-initial-advance.html (250883 => 250884)
--- trunk/LayoutTests/fast/text/complex-initial-advance.html 2019-10-09 01:54:12 UTC (rev 250883)
+++ trunk/LayoutTests/fast/text/complex-initial-advance.html 2019-10-09 02:12:04 UTC (rev 250884)
@@ -4,6 +4,7 @@
<meta charset="utf-8">
</head>
<body style="font-family: Geeza Pro; text-rendering: optimizeSpeed;">
-<span>مليئ</span><span> </span><span>حياةٍ</span><span> </span><span>مليئ</span>
+<div>This test makes sure that text with an initial advance is rendered correctly. The test passes if the ◌ٍ marks are positioned in the right place below the ة character below.</div>
+<span>حياةٍ</span><span> </span><span>مليئ</span>
</body>
</html>
Modified: trunk/LayoutTests/platform/mac/TestExpectations (250883 => 250884)
--- trunk/LayoutTests/platform/mac/TestExpectations 2019-10-09 01:54:12 UTC (rev 250883)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2019-10-09 02:12:04 UTC (rev 250884)
@@ -1814,8 +1814,6 @@
webkit.org/b/19650 [ HighSierra+ ] accessibility/mac/press-not-work-for-disabled-menu-list.html [ Pass Failure ]
-webkit.org/b/196512 [ Mojave+ ] fast/text/complex-initial-advance.html [ ImageOnlyFailure ]
-
webkit.org/b/196517 imported/w3c/web-platform-tests/mst-content-hint/MediaStreamTrack-contentHint.html [ Skip ]
webkit.org/b/177663 media/W3C/video/events/event_progress_manual.html [ Pass Failure ]
@@ -2041,4 +2039,4 @@
webkit.org/b/202523 imported/w3c/web-platform-tests/2dcontext/path-objects/2d.path.stroke.scale2.html [ Failure ]
-webkit.org/b/202598 imported/w3c/web-platform-tests/2dcontext/line-styles/2d.line.cap.round.html [ Failure ]
\ No newline at end of file
+webkit.org/b/202598 imported/w3c/web-platform-tests/2dcontext/line-styles/2d.line.cap.round.html [ Failure ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
