Title: [250976] trunk/Source/WebCore
- Revision
- 250976
- Author
- cdu...@apple.com
- Date
- 2019-10-10 10:17:51 -0700 (Thu, 10 Oct 2019)
Log Message
Flaky Test: media/media-source/media-source-page-cache.html
https://bugs.webkit.org/show_bug.cgi?id=202775
Reviewed by Eric Carlson.
SourceBufferList should never prevent entering the page cache, even if it has
pending events in its queue. Its queue is a MainThreadGenericEventQueue, which
is Page Cache-aware and will properly suspend the firing of events when needed.
No new tests, covered by flaky test which should no longer be.
* Modules/mediasource/SourceBufferList.cpp:
(WebCore::SourceBufferList::canSuspendForDocumentSuspension const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (250975 => 250976)
--- trunk/Source/WebCore/ChangeLog 2019-10-10 16:57:26 UTC (rev 250975)
+++ trunk/Source/WebCore/ChangeLog 2019-10-10 17:17:51 UTC (rev 250976)
@@ -1,3 +1,19 @@
+2019-10-10 Chris Dumez <cdu...@apple.com>
+
+ Flaky Test: media/media-source/media-source-page-cache.html
+ https://bugs.webkit.org/show_bug.cgi?id=202775
+
+ Reviewed by Eric Carlson.
+
+ SourceBufferList should never prevent entering the page cache, even if it has
+ pending events in its queue. Its queue is a MainThreadGenericEventQueue, which
+ is Page Cache-aware and will properly suspend the firing of events when needed.
+
+ No new tests, covered by flaky test which should no longer be.
+
+ * Modules/mediasource/SourceBufferList.cpp:
+ (WebCore::SourceBufferList::canSuspendForDocumentSuspension const):
+
2019-10-10 Sihui Liu <sihui_...@apple.com>
Add a unit test for StorageQuotaManager
Modified: trunk/Source/WebCore/Modules/mediasource/SourceBufferList.cpp (250975 => 250976)
--- trunk/Source/WebCore/Modules/mediasource/SourceBufferList.cpp 2019-10-10 16:57:26 UTC (rev 250975)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBufferList.cpp 2019-10-10 17:17:51 UTC (rev 250976)
@@ -103,7 +103,7 @@
bool SourceBufferList::canSuspendForDocumentSuspension() const
{
- return !m_asyncEventQueue->hasPendingEvents();
+ return true;
}
const char* SourceBufferList::activeDOMObjectName() const
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
