Title: [251370] trunk/Source/WebKit
- Revision
- 251370
- Author
- cdu...@apple.com
- Date
- 2019-10-21 11:59:22 -0700 (Mon, 21 Oct 2019)
Log Message
Add more release logging for "Unexpectedly resumed" assertion
https://bugs.webkit.org/show_bug.cgi?id=203196
Reviewed by Geoffrey Garen.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::processDidResume):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::processTaskStateDidChange):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (251369 => 251370)
--- trunk/Source/WebKit/ChangeLog 2019-10-21 18:59:09 UTC (rev 251369)
+++ trunk/Source/WebKit/ChangeLog 2019-10-21 18:59:22 UTC (rev 251370)
@@ -1,3 +1,15 @@
+2019-10-21 Chris Dumez <cdu...@apple.com>
+
+ Add more release logging for "Unexpectedly resumed" assertion
+ https://bugs.webkit.org/show_bug.cgi?id=203196
+
+ Reviewed by Geoffrey Garen.
+
+ * WebProcess/WebProcess.cpp:
+ (WebKit::WebProcess::processDidResume):
+ * WebProcess/cocoa/WebProcessCocoa.mm:
+ (WebKit::WebProcess::processTaskStateDidChange):
+
2019-10-21 Carlos Garcia Campos <cgar...@igalia.com>
[GTK] Objects category in emoji picker is empty
Modified: trunk/Source/WebKit/WebProcess/WebProcess.cpp (251369 => 251370)
--- trunk/Source/WebKit/WebProcess/WebProcess.cpp 2019-10-21 18:59:09 UTC (rev 251369)
+++ trunk/Source/WebKit/WebProcess/WebProcess.cpp 2019-10-21 18:59:22 UTC (rev 251370)
@@ -1541,7 +1541,10 @@
accessibilityProcessSuspendedNotification(false);
{
LockHolder holder(m_unexpectedlyResumedUIAssertionLock);
- m_unexpectedlyResumedUIAssertion = nullptr;
+ if (m_unexpectedlyResumedUIAssertion) {
+ RELEASE_LOG(ProcessSuspension, "%p - WebProcess::processDidResume() Releasing 'Unexpectedly resumed' assertion", this);
+ m_unexpectedlyResumedUIAssertion = nullptr;
+ }
}
#endif
Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (251369 => 251370)
--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2019-10-21 18:59:09 UTC (rev 251369)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2019-10-21 18:59:22 UTC (rev 251370)
@@ -317,6 +317,7 @@
// We were awakened from suspension unexpectedly. Notify the WebProcessProxy, but take a process assertion on our parent PID
// to ensure that it too is awakened.
+ RELEASE_LOG(ProcessSuspension, "%p - WebProcess::processTaskStateChanged() Taking 'Unexpectedly resumed' assertion", this);
m_unexpectedlyResumedUIAssertion = adoptNS([[BKSProcessAssertion alloc] initWithPID:parentProcessConnection()->remoteProcessID() flags:BKSProcessAssertionPreventTaskSuspend reason:BKSProcessAssertionReasonFinishTask name:@"Unexpectedly resumed" withHandler:nil]);
auto releaseAssertion = [this] {
@@ -324,6 +325,7 @@
if (!m_unexpectedlyResumedUIAssertion)
return;
+ RELEASE_LOG(ProcessSuspension, "%p - WebProcess::processTaskStateChanged() Releasing 'Unexpectedly resumed' assertion due to time out", this);
[m_unexpectedlyResumedUIAssertion invalidate];
m_unexpectedlyResumedUIAssertion = nullptr;
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
