Title: [252352] trunk/Source/WebCore
- Revision
- 252352
- Author
- pvol...@apple.com
- Date
- 2019-11-11 17:58:52 -0800 (Mon, 11 Nov 2019)
Log Message
Many legacy animation tests are timing out with VS2019
https://bugs.webkit.org/show_bug.cgi?id=204000
Reviewed by Brent Fulgham.
When compiling with VS2019, there is a compiler issue, where an Optional without a value is returned
when it should definitely have a value. Work around this issue by moving the local Optional value
when returning.
No new tests, covered by existing tests.
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::timeToNextService):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::timeToNextService):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (252351 => 252352)
--- trunk/Source/WebCore/ChangeLog 2019-11-12 01:49:26 UTC (rev 252351)
+++ trunk/Source/WebCore/ChangeLog 2019-11-12 01:58:52 UTC (rev 252352)
@@ -1,3 +1,21 @@
+2019-11-11 Per Arne Vollan <pvol...@apple.com>
+
+ Many legacy animation tests are timing out with VS2019
+ https://bugs.webkit.org/show_bug.cgi?id=204000
+
+ Reviewed by Brent Fulgham.
+
+ When compiling with VS2019, there is a compiler issue, where an Optional without a value is returned
+ when it should definitely have a value. Work around this issue by moving the local Optional value
+ when returning.
+
+ No new tests, covered by existing tests.
+
+ * page/animation/ImplicitAnimation.cpp:
+ (WebCore::ImplicitAnimation::timeToNextService):
+ * page/animation/KeyframeAnimation.cpp:
+ (WebCore::KeyframeAnimation::timeToNextService):
+
2019-11-11 Youenn Fablet <you...@apple.com>
DOMFormData should be available in workers
Modified: trunk/Source/WebCore/page/animation/ImplicitAnimation.cpp (252351 => 252352)
--- trunk/Source/WebCore/page/animation/ImplicitAnimation.cpp 2019-11-12 01:49:26 UTC (rev 252351)
+++ trunk/Source/WebCore/page/animation/ImplicitAnimation.cpp 2019-11-12 01:58:52 UTC (rev 252352)
@@ -360,7 +360,11 @@
{
Optional<Seconds> t = AnimationBase::timeToNextService();
if (!t || t.value() != 0_s || preActive())
+#if COMPILER(MSVC) && _MSC_VER >= 1920
+ return WTFMove(t);
+#else
return t;
+#endif
// A return value of 0 means we need service. But if this is an accelerated animation we
// only need service at the end of the transition.
Modified: trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp (252351 => 252352)
--- trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp 2019-11-12 01:49:26 UTC (rev 252351)
+++ trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp 2019-11-12 01:58:52 UTC (rev 252352)
@@ -515,7 +515,11 @@
{
Optional<Seconds> t = AnimationBase::timeToNextService();
if (!t || t.value() != 0_s || preActive())
+#if COMPILER(MSVC) && _MSC_VER >= 1920
+ return WTFMove(t);
+#else
return t;
+#endif
// A return value of 0 means we need service. But if we only have accelerated animations we
// only need service at the end of the transition.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
