Title: [256636] trunk/Source/WebCore
- Revision
- 256636
- Author
- grao...@webkit.org
- Date
- 2020-02-14 13:19:53 -0800 (Fri, 14 Feb 2020)
Log Message
[Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
https://bugs.webkit.org/show_bug.cgi?id=207784
<rdar://problem/59251858>
Patch by Antoine Quint <grao...@webkit.org> on 2020-02-14
Reviewed by Dean Jackson.
After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
call should the Web Animations flag be on.
* page/Frame.cpp:
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (256635 => 256636)
--- trunk/Source/WebCore/ChangeLog 2020-02-14 21:13:36 UTC (rev 256635)
+++ trunk/Source/WebCore/ChangeLog 2020-02-14 21:19:53 UTC (rev 256636)
@@ -1,3 +1,17 @@
+2020-02-14 Antoine Quint <grao...@webkit.org>
+
+ [Web Animations] Missing call to DocumentTimeline::resumeAnimations() in Frame::resumeActiveDOMObjectsAndAnimations()
+ https://bugs.webkit.org/show_bug.cgi?id=207784
+ <rdar://problem/59251858>
+
+ Reviewed by Dean Jackson.
+
+ After auditing the code, there was one call to CSSAnimationController::resumeAnimationsForDocument() that missed a matching DocumentTimeline::resumeAnimations()
+ call should the Web Animations flag be on.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
+
2020-02-14 Yusuke Suzuki <ysuz...@apple.com>
NetworkLoadMetrics should be shared by multiple ResourceResponse instances
Modified: trunk/Source/WebCore/page/Frame.cpp (256635 => 256636)
--- trunk/Source/WebCore/page/Frame.cpp 2020-02-14 21:13:36 UTC (rev 256635)
+++ trunk/Source/WebCore/page/Frame.cpp 2020-02-14 21:19:53 UTC (rev 256636)
@@ -960,7 +960,12 @@
m_doc->resumeScheduledTasks(ReasonForSuspension::PageWillBeSuspended);
// Frame::clearTimers() suspended animations and pending relayouts.
- animation().resumeAnimationsForDocument(m_doc.get());
+
+ if (RuntimeEnabledFeatures::sharedFeatures().webAnimationsCSSIntegrationEnabled()) {
+ if (auto* timeline = m_doc->existingTimeline())
+ timeline->resumeAnimations();
+ } else
+ animation().resumeAnimationsForDocument(m_doc.get());
if (m_view)
m_view->layoutContext().scheduleLayout();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
