Title: [258041] trunk/Source/WebKit
- Revision
- 258041
- Author
- bfulg...@apple.com
- Date
- 2020-03-06 17:31:19 -0800 (Fri, 06 Mar 2020)
Log Message
Expand the feature flags mechanism with additional default feature preference values
https://bugs.webkit.org/show_bug.cgi?id=208737
<rdar://problem/60109390>
Reviewed by Simon Fraser.
No new tests, no functional change.
Update the new default feature preference implementation with additional flags
that would benefit from this approach.
* FeatureFlags/WebKit.plist:
* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultInAppBrowserPrivacy):
(WebKit::defaultWebGPUEnabled):
* Shared/WebPreferencesDefaultValues.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (258040 => 258041)
--- trunk/Source/WebKit/ChangeLog 2020-03-07 01:25:28 UTC (rev 258040)
+++ trunk/Source/WebKit/ChangeLog 2020-03-07 01:31:19 UTC (rev 258041)
@@ -1,3 +1,23 @@
+2020-03-06 Brent Fulgham <bfulg...@apple.com>
+
+ Expand the feature flags mechanism with additional default feature preference values
+ https://bugs.webkit.org/show_bug.cgi?id=208737
+ <rdar://problem/60109390>
+
+ Reviewed by Simon Fraser.
+
+ No new tests, no functional change.
+
+ Update the new default feature preference implementation with additional flags
+ that would benefit from this approach.
+
+ * FeatureFlags/WebKit.plist:
+ * Shared/WebPreferences.yaml:
+ * Shared/WebPreferencesDefaultValues.cpp:
+ (WebKit::defaultInAppBrowserPrivacy):
+ (WebKit::defaultWebGPUEnabled):
+ * Shared/WebPreferencesDefaultValues.h:
+
2020-03-06 Jer Noble <jer.no...@apple.com>
[GPUP] Convert CDMFactory away from platformStrategies() and use WebProcess settings instead
Modified: trunk/Source/WebKit/FeatureFlags/WebKit.plist (258040 => 258041)
--- trunk/Source/WebKit/FeatureFlags/WebKit.plist 2020-03-07 01:25:28 UTC (rev 258040)
+++ trunk/Source/WebKit/FeatureFlags/WebKit.plist 2020-03-07 01:31:19 UTC (rev 258041)
@@ -32,5 +32,15 @@
<key>Enabled</key>
<false/>
</dict>
+ <key>InAppBrowserPrivacy</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>ScriptOptimizations</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
</dict>
</plist>
Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (258040 => 258041)
--- trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-03-07 01:25:28 UTC (rev 258040)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml 2020-03-07 01:31:19 UTC (rev 258041)
@@ -1931,7 +1931,7 @@
IsInAppBrowserPrivacyEnabled:
type: bool
- defaultValue: false
+ defaultValue: defaultInAppBrowserPrivacy()
humanReadableName: "In-App Browser Privacy"
humanReadableDescription: "Enable In-App Browser Privacy"
webcoreBinding: RuntimeEnabledFeatures
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (258040 => 258041)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2020-03-07 01:25:28 UTC (rev 258040)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2020-03-07 01:31:19 UTC (rev 258041)
@@ -204,4 +204,13 @@
#endif // ENABLE(WEBGPU)
+bool defaultInAppBrowserPrivacy()
+{
+#if HAVE(HAVE_SYSTEM_FEATURE_FLAGS)
+ return os_feature_enabled(WebKit, InAppBrowserPrivacy);
+#endif
+
+ return false;
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (258040 => 258041)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2020-03-07 01:25:28 UTC (rev 258040)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h 2020-03-07 01:31:19 UTC (rev 258041)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010-2019 Apple Inc. All rights reserved.
+ * Copyright (C) 2010-2020 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -332,4 +332,6 @@
bool defaultWebGPUEnabled();
#endif
+bool defaultInAppBrowserPrivacy();
+
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
