Title: [258124] trunk/Source/WebKit
- Revision
- 258124
- Author
- bfulg...@apple.com
- Date
- 2020-03-08 17:55:16 -0700 (Sun, 08 Mar 2020)
Log Message
Revise In-App Browser Privacy checks to better reflect the meaning of the flag
https://bugs.webkit.org/show_bug.cgi?id=208793
<rdar://problem/60206256>
Reviewed by John Wilander.
The 'isInAppBrowserPrivacyEnabled' seems like a feature, but it's really an internal debugging flag.
Revise the use of these calls to make it clearer.
Tested by existing test cases.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::NetworkSessionCocoa::sessionWrapperForTask):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomain):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (258123 => 258124)
--- trunk/Source/WebKit/ChangeLog 2020-03-09 00:43:28 UTC (rev 258123)
+++ trunk/Source/WebKit/ChangeLog 2020-03-09 00:55:16 UTC (rev 258124)
@@ -1,3 +1,22 @@
+2020-03-08 Brent Fulgham <bfulg...@apple.com>
+
+ Revise In-App Browser Privacy checks to better reflect the meaning of the flag
+ https://bugs.webkit.org/show_bug.cgi?id=208793
+ <rdar://problem/60206256>
+
+ Reviewed by John Wilander.
+
+ The 'isInAppBrowserPrivacyEnabled' seems like a feature, but it's really an internal debugging flag.
+
+ Revise the use of these calls to make it clearer.
+
+ Tested by existing test cases.
+
+ * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+ (WebKit::NetworkSessionCocoa::sessionWrapperForTask):
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::setIsNavigatingToAppBoundDomain):
+
2020-03-08 Brady Eidson <beid...@apple.com>
Remember completed subranges during incremental PDF loading.
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (258123 => 258124)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2020-03-09 00:43:28 UTC (rev 258123)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2020-03-09 00:55:16 UTC (rev 258124)
@@ -61,6 +61,8 @@
#if USE(APPLE_INTERNAL_SDK)
#include <WebKitAdditions/NetworkSessionCocoaAdditions.h>
+#else
+#define NETWORK_SESSION_COCOA_ADDITIONS false
#endif
#import "DeviceManagementSoftLink.h"
@@ -1213,8 +1215,10 @@
ASSERT_NOT_REACHED();
#endif
- if (m_isInAppBrowserPrivacyEnabled && isNavigatingToAppBoundDomain == NavigatingToAppBoundDomain::Yes)
- return appBoundSession(storedCredentialsPolicy);
+ if (isNavigatingToAppBoundDomain == NavigatingToAppBoundDomain::Yes) {
+ if (m_isInAppBrowserPrivacyEnabled || NETWORK_SESSION_COCOA_ADDITIONS)
+ return appBoundSession(storedCredentialsPolicy);
+ }
switch (storedCredentialsPolicy) {
case WebCore::StoredCredentialsPolicy::Use:
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (258123 => 258124)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-03-09 00:43:28 UTC (rev 258123)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-03-09 00:55:16 UTC (rev 258124)
@@ -280,6 +280,7 @@
#include <WebKitAdditions/WebPageProxyAdditions.h>
#else
#define WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN
+#define WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN_2 false
#endif
// This controls what strategy we use for mouse wheel coalescing.
@@ -3096,7 +3097,7 @@
void WebPageProxy::setIsNavigatingToAppBoundDomain(bool isMainFrame, const URL& requestURL, NavigatingToAppBoundDomain isNavigatingToAppBoundDomain)
{
- if (m_preferences->isInAppBrowserPrivacyEnabled() && isMainFrame) {
+ if (isMainFrame && (m_preferences->isInAppBrowserPrivacyEnabled() || WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN_2)) {
WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN
if (isNavigatingToAppBoundDomain == NavigatingToAppBoundDomain::No) {
m_configuration->setWebViewCategory(WebViewCategory::InAppBrowser);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
