Diff
Modified: trunk/Source/WebCore/ChangeLog (260077 => 260078)
--- trunk/Source/WebCore/ChangeLog 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/ChangeLog 2020-04-14 17:03:25 UTC (rev 260078)
@@ -1,3 +1,73 @@
+2020-04-14 David Kilzer <ddkil...@apple.com>
+
+ Add WARN_UNUSED_RETURN to decode methods in Source/WebCore
+ <https://webkit.org/b/210416>
+ <rdar://problem/61693462>
+
+ Reviewed by Alex Christensen.
+
+ * Modules/geolocation/GeolocationPositionData.h:
+ * Modules/indexeddb/IDBGetAllResult.h:
+ * Modules/indexeddb/IDBGetResult.h:
+ * Modules/indexeddb/IDBKeyData.h:
+ * Modules/indexeddb/IDBKeyRangeData.h:
+ * Modules/indexeddb/server/IDBSerialization.cpp:
+ (WebCore::decodeKey):
+ * Modules/indexeddb/shared/IDBCursorInfo.h:
+ * Modules/indexeddb/shared/IDBCursorRecord.h:
+ * Modules/indexeddb/shared/IDBDatabaseInfo.h:
+ * Modules/indexeddb/shared/IDBError.h:
+ * Modules/indexeddb/shared/IDBGetAllRecordsData.h:
+ * Modules/indexeddb/shared/IDBGetRecordData.h:
+ * Modules/indexeddb/shared/IDBIndexInfo.h:
+ * Modules/indexeddb/shared/IDBIterateCursorData.h:
+ * Modules/indexeddb/shared/IDBObjectStoreInfo.h:
+ * Modules/indexeddb/shared/IDBRequestData.h:
+ * Modules/indexeddb/shared/IDBResourceIdentifier.h:
+ * Modules/indexeddb/shared/IDBTransactionInfo.h:
+ * Modules/mediasource/SourceBuffer.cpp:
+ (WebCore::decodeTimeComparator):
+ * dom/EventInit.h:
+ * dom/ExceptionData.h:
+ * dom/SecurityPolicyViolationEvent.h:
+ * editing/FontAttributeChanges.h:
+ * editing/FontShadow.h:
+ * loader/CanvasActivityRecord.h:
+ * loader/FetchOptions.h:
+ (WebCore::FetchOptions::decodePersistent):
+ * platform/ContentFilterUnblockHandler.h:
+ * platform/DragItem.h:
+ * platform/KeyedCoding.h:
+ * platform/LinkIcon.h:
+ * platform/ThreadSafeDataBuffer.h:
+ * platform/audio/mac/CAAudioStreamDescription.h:
+ * platform/cf/KeyedDecoderCF.h:
+ * platform/generic/KeyedDecoderGeneric.h:
+ * platform/glib/KeyedDecoderGlib.h:
+ * platform/graphics/Region.h:
+ * platform/graphics/RemoteVideoSample.h:
+ (WebCore::RemoteVideoSample::decode):
+ * platform/mediastream/MediaConstraints.h:
+ (WebCore::MediaConstraint::decode):
+ (WebCore::NumericConstraint::decode):
+ (WebCore::StringConstraint::decode):
+ * platform/mediastream/RealtimeMediaSourceCapabilities.h:
+ * platform/mediastream/RealtimeMediaSourceSettings.h:
+ * platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:
+ * platform/network/HTTPHeaderMap.h:
+ * platform/network/NetworkLoadMetrics.h:
+ * platform/network/ResourceRequestBase.h:
+ * platform/network/ResourceResponseBase.h:
+ (WebCore::ResourceResponseBase::decode):
+ * platform/network/SameSiteInfo.h:
+ * platform/network/SocketStreamError.h:
+ * platform/network/curl/ResourceRequest.h:
+ * platform/network/soup/ResourceRequest.h:
+ * platform/network/soup/ResourceResponse.h:
+ * rendering/EventRegion.h:
+ * workers/service/ServiceWorkerFetchResult.h:
+ - Add WARN_UNUSED_RETURN to all decode functions.
+
2020-04-14 Antoine Quint <grao...@apple.com>
[Web Animations] Store an Element / PseudoId pair to define the KeyframeEffect target
Modified: trunk/Source/WebCore/Modules/geolocation/GeolocationPositionData.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/geolocation/GeolocationPositionData.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/geolocation/GeolocationPositionData.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -67,7 +67,7 @@
bool isValid() const;
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, GeolocationPositionData&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, GeolocationPositionData&);
};
template<class Encoder>
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBGetAllResult.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/IDBGetAllResult.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBGetAllResult.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -62,7 +62,7 @@
void addValue(IDBValue&&);
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBGetAllResult&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBGetAllResult&);
WEBCORE_EXPORT Vector<String> allBlobFilePaths() const;
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBGetResult.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/IDBGetResult.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBGetResult.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -101,7 +101,7 @@
bool isDefined() const { return m_isDefined; }
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBGetResult&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBGetResult&);
private:
void dataFromBuffer(SharedBuffer&);
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -72,7 +72,7 @@
WEBCORE_EXPORT IDBKeyData isolatedCopy() const;
WEBCORE_EXPORT void encode(KeyedEncoder&) const;
- WEBCORE_EXPORT static bool decode(KeyedDecoder&, IDBKeyData&);
+ WEBCORE_EXPORT static WARN_UNUSED_RETURN bool decode(KeyedDecoder&, IDBKeyData&);
// compare() has the same semantics as strcmp().
// - Returns negative if this IDBKeyData is less than other.
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKeyRangeData.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/IDBKeyRangeData.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKeyRangeData.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -77,7 +77,7 @@
bool isValid() const;
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBKeyRangeData&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBKeyRangeData&);
bool isNull;
Modified: trunk/Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp 2020-04-14 17:03:25 UTC (rev 260078)
@@ -292,7 +292,7 @@
return SharedBuffer::create(WTFMove(data));
}
-static bool decodeKey(const uint8_t*& data, const uint8_t* end, IDBKeyData& result)
+static WARN_UNUSED_RETURN bool decodeKey(const uint8_t*& data, const uint8_t* end, IDBKeyData& result)
{
if (!data || data >= end)
return false;
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBCursorInfo.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBCursorInfo.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBCursorInfo.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -68,7 +68,7 @@
WEBCORE_EXPORT IDBCursorInfo();
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBCursorInfo&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBCursorInfo&);
#if !LOG_DISABLED
String loggingString() const;
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBCursorRecord.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBCursorRecord.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBCursorRecord.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -38,7 +38,7 @@
IDBValue value;
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBCursorRecord&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBCursorRecord&);
IDBCursorRecord isolatedCopy() const;
size_t size() const { return key.size() + primaryKey.size() + value.size(); }
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBDatabaseInfo.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -66,7 +66,7 @@
WEBCORE_EXPORT IDBDatabaseInfo();
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBDatabaseInfo&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBDatabaseInfo&);
void setMaxIndexID(uint64_t maxIndexID);
uint64_t generateNextIndexID() { return ++m_maxIndexID; }
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBError.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBError.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBError.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -58,7 +58,7 @@
WEBCORE_EXPORT IDBError isolatedCopy() const;
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBError&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBError&);
private:
Optional<ExceptionCode> m_code;
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBGetAllRecordsData.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBGetAllRecordsData.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBGetAllRecordsData.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -51,7 +51,7 @@
#endif
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBGetAllRecordsData&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBGetAllRecordsData&);
};
template<class Encoder>
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBGetRecordData.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBGetRecordData.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBGetRecordData.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -47,7 +47,7 @@
#endif
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBGetRecordData&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBGetRecordData&);
};
template<class Encoder>
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBIndexInfo.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -49,7 +49,7 @@
void rename(const String& newName) { m_name = newName; }
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBIndexInfo&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBIndexInfo&);
#if !LOG_DISABLED
String loggingString(int indent = 0) const;
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBIterateCursorData.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBIterateCursorData.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBIterateCursorData.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -44,7 +44,7 @@
#endif
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBIterateCursorData&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBIterateCursorData&);
};
template<class Encoder>
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -62,7 +62,7 @@
void deleteIndex(uint64_t indexIdentifier);
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBObjectStoreInfo&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBObjectStoreInfo&);
#if !LOG_DISABLED
String loggingString(int indent = 0) const;
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -76,7 +76,7 @@
WEBCORE_EXPORT IDBRequestData();
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBRequestData&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBRequestData&);
private:
static void isolatedCopy(const IDBRequestData& source, IDBRequestData& destination);
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -83,7 +83,7 @@
WEBCORE_EXPORT IDBResourceIdentifier();
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBResourceIdentifier&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBResourceIdentifier&);
private:
IDBResourceIdentifier(IDBConnectionIdentifier, uint64_t resourceIdentifier);
Modified: trunk/Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.h (260077 => 260078)
--- trunk/Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/indexeddb/shared/IDBTransactionInfo.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -69,7 +69,7 @@
WEBCORE_EXPORT IDBTransactionInfo();
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, IDBTransactionInfo&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, IDBTransactionInfo&);
#if !LOG_DISABLED
String loggingString() const;
Modified: trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp (260077 => 260078)
--- trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp 2020-04-14 17:03:25 UTC (rev 260078)
@@ -717,7 +717,7 @@
m_source->streamEndedWithError(MediaSource::EndOfStreamError::Decode);
}
-static bool decodeTimeComparator(const PresentationOrderSampleMap::MapType::value_type& a, const PresentationOrderSampleMap::MapType::value_type& b)
+static WARN_UNUSED_RETURN bool decodeTimeComparator(const PresentationOrderSampleMap::MapType::value_type& a, const PresentationOrderSampleMap::MapType::value_type& b)
{
return a.second->decodeTime() < b.second->decodeTime();
}
Modified: trunk/Source/WebCore/dom/EventInit.h (260077 => 260078)
--- trunk/Source/WebCore/dom/EventInit.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/dom/EventInit.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -33,7 +33,7 @@
bool composed { false };
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, EventInit&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, EventInit&);
};
template<class Encoder>
Modified: trunk/Source/WebCore/dom/ExceptionData.h (260077 => 260078)
--- trunk/Source/WebCore/dom/ExceptionData.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/dom/ExceptionData.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -37,7 +37,7 @@
WEBCORE_EXPORT ExceptionData isolatedCopy() const;
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, ExceptionData&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, ExceptionData&);
Exception toException() const
{
Modified: trunk/Source/WebCore/dom/SecurityPolicyViolationEvent.h (260077 => 260078)
--- trunk/Source/WebCore/dom/SecurityPolicyViolationEvent.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/dom/SecurityPolicyViolationEvent.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -55,7 +55,7 @@
int columnNumber { 0 };
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, Init&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, Init&);
};
static Ref<SecurityPolicyViolationEvent> create(const AtomString& type, const Init& initializer, IsTrusted isTrusted = IsTrusted::No)
Modified: trunk/Source/WebCore/editing/FontAttributeChanges.h (260077 => 260078)
--- trunk/Source/WebCore/editing/FontAttributeChanges.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/editing/FontAttributeChanges.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -41,7 +41,7 @@
class FontChanges {
public:
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, FontChanges&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, FontChanges&);
void setFontName(const String& fontName) { m_fontName = fontName; }
void setFontFamily(const String& fontFamily) { m_fontFamily = fontFamily; }
@@ -72,7 +72,7 @@
class FontAttributeChanges {
public:
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, FontAttributeChanges&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, FontAttributeChanges&);
void setVerticalAlign(VerticalAlignChange align) { m_verticalAlign = align; }
void setBackgroundColor(const Color& color) { m_backgroundColor = color; }
Modified: trunk/Source/WebCore/editing/FontShadow.h (260077 => 260078)
--- trunk/Source/WebCore/editing/FontShadow.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/editing/FontShadow.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -37,7 +37,7 @@
struct FontShadow {
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, FontShadow&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, FontShadow&);
#if PLATFORM(COCOA)
RetainPtr<NSShadow> createShadow() const;
Modified: trunk/Source/WebCore/loader/CanvasActivityRecord.h (260077 => 260078)
--- trunk/Source/WebCore/loader/CanvasActivityRecord.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/loader/CanvasActivityRecord.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -37,7 +37,7 @@
void mergeWith(const CanvasActivityRecord&);
template <class Encoder> void encode(Encoder&) const;
- template <class Decoder> static bool decode(Decoder&, CanvasActivityRecord&);
+ template <class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, CanvasActivityRecord&);
};
template <class Encoder>
Modified: trunk/Source/WebCore/loader/FetchOptions.h (260077 => 260078)
--- trunk/Source/WebCore/loader/FetchOptions.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/loader/FetchOptions.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -47,7 +47,7 @@
FetchOptions isolatedCopy() const { return { destination, mode, credentials, cache, redirect, referrerPolicy, integrity.isolatedCopy(), keepAlive }; }
template<class Encoder> void encodePersistent(Encoder&) const;
- template<class Decoder> static bool decodePersistent(Decoder&, FetchOptions&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decodePersistent(Decoder&, FetchOptions&);
template<class Encoder> void encode(Encoder&) const;
template<class Decoder> static Optional<FetchOptions> decode(Decoder&);
@@ -182,7 +182,7 @@
}
template<class Decoder>
-inline WARN_UNUSED_RETURN bool FetchOptions::decodePersistent(Decoder& decoder, FetchOptions& options)
+inline bool FetchOptions::decodePersistent(Decoder& decoder, FetchOptions& options)
{
Optional<FetchOptions::Destination> destination;
decoder >> destination;
Modified: trunk/Source/WebCore/platform/ContentFilterUnblockHandler.h (260077 => 260078)
--- trunk/Source/WebCore/platform/ContentFilterUnblockHandler.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/ContentFilterUnblockHandler.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -55,7 +55,7 @@
WEBCORE_EXPORT bool needsUIProcess() const;
WEBCORE_EXPORT void encode(NSCoder *) const;
- WEBCORE_EXPORT static bool decode(NSCoder *, ContentFilterUnblockHandler&);
+ WEBCORE_EXPORT static WARN_UNUSED_RETURN bool decode(NSCoder *, ContentFilterUnblockHandler&);
WEBCORE_EXPORT bool canHandleRequest(const ResourceRequest&) const;
WEBCORE_EXPORT void requestUnblockAsync(DecisionHandlerFunction) const;
void wrapWithDecisionHandler(const DecisionHandlerFunction&);
Modified: trunk/Source/WebCore/platform/DragItem.h (260077 => 260078)
--- trunk/Source/WebCore/platform/DragItem.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/DragItem.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -53,7 +53,7 @@
PromisedAttachmentInfo promisedAttachmentInfo;
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, DragItem&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, DragItem&);
};
template<class Encoder>
Modified: trunk/Source/WebCore/platform/KeyedCoding.h (260077 => 260078)
--- trunk/Source/WebCore/platform/KeyedCoding.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/KeyedCoding.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -40,17 +40,17 @@
virtual ~KeyedDecoder() = default;
- virtual bool decodeBytes(const String& key, const uint8_t*&, size_t&) = 0;
- virtual bool decodeBool(const String& key, bool&) = 0;
- virtual bool decodeUInt32(const String& key, uint32_t&) = 0;
- virtual bool decodeUInt64(const String& key, uint64_t&) = 0;
- virtual bool decodeInt32(const String& key, int32_t&) = 0;
- virtual bool decodeInt64(const String& key, int64_t&) = 0;
- virtual bool decodeFloat(const String& key, float&) = 0;
- virtual bool decodeDouble(const String& key, double&) = 0;
- virtual bool decodeString(const String& key, String&) = 0;
+ virtual WARN_UNUSED_RETURN bool decodeBytes(const String& key, const uint8_t*&, size_t&) = 0;
+ virtual WARN_UNUSED_RETURN bool decodeBool(const String& key, bool&) = 0;
+ virtual WARN_UNUSED_RETURN bool decodeUInt32(const String& key, uint32_t&) = 0;
+ virtual WARN_UNUSED_RETURN bool decodeUInt64(const String& key, uint64_t&) = 0;
+ virtual WARN_UNUSED_RETURN bool decodeInt32(const String& key, int32_t&) = 0;
+ virtual WARN_UNUSED_RETURN bool decodeInt64(const String& key, int64_t&) = 0;
+ virtual WARN_UNUSED_RETURN bool decodeFloat(const String& key, float&) = 0;
+ virtual WARN_UNUSED_RETURN bool decodeDouble(const String& key, double&) = 0;
+ virtual WARN_UNUSED_RETURN bool decodeString(const String& key, String&) = 0;
- template<typename T>
+ template<typename T> WARN_UNUSED_RETURN
bool decodeBytes(const String& key, Vector<T>& vector)
{
static_assert(sizeof(T) == 1, "");
@@ -65,7 +65,7 @@
return true;
}
- template<typename T, typename F>
+ template<typename T, typename F> WARN_UNUSED_RETURN
bool decodeEnum(const String& key, T& value, F&& isValidEnumFunction)
{
static_assert(std::is_enum<T>::value, "T must be an enum type");
@@ -81,7 +81,7 @@
return true;
}
- template<typename T, typename F>
+ template<typename T, typename F> WARN_UNUSED_RETURN
bool decodeObject(const String& key, T& object, F&& function)
{
if (!beginObject(key))
@@ -91,7 +91,7 @@
return result;
}
- template<typename T, typename F>
+ template<typename T, typename F> WARN_UNUSED_RETURN
bool decodeConditionalObject(const String& key, T& object, F&& function)
{
// FIXME: beginObject can return false for two reasons: either the
@@ -106,7 +106,7 @@
return result;
}
- template<typename ContainerType, typename F>
+ template<typename ContainerType, typename F> WARN_UNUSED_RETURN
bool decodeObjects(const String& key, ContainerType& objects, F&& function)
{
if (!beginArray(key))
Modified: trunk/Source/WebCore/platform/LinkIcon.h (260077 => 260078)
--- trunk/Source/WebCore/platform/LinkIcon.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/LinkIcon.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -41,7 +41,7 @@
Vector<std::pair<String, String>> attributes;
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, LinkIcon&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, LinkIcon&);
};
template<class Encoder>
Modified: trunk/Source/WebCore/platform/ThreadSafeDataBuffer.h (260077 => 260078)
--- trunk/Source/WebCore/platform/ThreadSafeDataBuffer.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/ThreadSafeDataBuffer.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -94,7 +94,7 @@
}
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, ThreadSafeDataBuffer&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, ThreadSafeDataBuffer&);
private:
explicit ThreadSafeDataBuffer(Vector<uint8_t>&& data)
Modified: trunk/Source/WebCore/platform/audio/mac/CAAudioStreamDescription.h (260077 => 260078)
--- trunk/Source/WebCore/platform/audio/mac/CAAudioStreamDescription.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/audio/mac/CAAudioStreamDescription.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -79,7 +79,7 @@
AudioStreamBasicDescription& streamDescription() { return m_streamDescription; }
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, CAAudioStreamDescription&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, CAAudioStreamDescription&);
private:
void calculateFormat();
Modified: trunk/Source/WebCore/platform/cf/KeyedDecoderCF.h (260077 => 260078)
--- trunk/Source/WebCore/platform/cf/KeyedDecoderCF.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/cf/KeyedDecoderCF.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -38,15 +38,15 @@
~KeyedDecoderCF() override;
private:
- bool decodeBytes(const String& key, const uint8_t*&, size_t&) override;
- bool decodeBool(const String& key, bool&) override;
- bool decodeUInt32(const String& key, uint32_t&) override;
- bool decodeUInt64(const String& key, uint64_t&) override;
- bool decodeInt32(const String& key, int32_t&) override;
- bool decodeInt64(const String& key, int64_t&) override;
- bool decodeFloat(const String& key, float&) override;
- bool decodeDouble(const String& key, double&) override;
- bool decodeString(const String& key, String&) override;
+ WARN_UNUSED_RETURN bool decodeBytes(const String& key, const uint8_t*&, size_t&) override;
+ WARN_UNUSED_RETURN bool decodeBool(const String& key, bool&) override;
+ WARN_UNUSED_RETURN bool decodeUInt32(const String& key, uint32_t&) override;
+ WARN_UNUSED_RETURN bool decodeUInt64(const String& key, uint64_t&) override;
+ WARN_UNUSED_RETURN bool decodeInt32(const String& key, int32_t&) override;
+ WARN_UNUSED_RETURN bool decodeInt64(const String& key, int64_t&) override;
+ WARN_UNUSED_RETURN bool decodeFloat(const String& key, float&) override;
+ WARN_UNUSED_RETURN bool decodeDouble(const String& key, double&) override;
+ WARN_UNUSED_RETURN bool decodeString(const String& key, String&) override;
bool beginObject(const String& key) override;
void endObject() override;
Modified: trunk/Source/WebCore/platform/generic/KeyedDecoderGeneric.h (260077 => 260078)
--- trunk/Source/WebCore/platform/generic/KeyedDecoderGeneric.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/generic/KeyedDecoderGeneric.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -37,15 +37,15 @@
using Array = Vector<std::unique_ptr<Dictionary>>;
private:
- bool decodeBytes(const String& key, const uint8_t*&, size_t&) override;
- bool decodeBool(const String& key, bool&) override;
- bool decodeUInt32(const String& key, uint32_t&) override;
- bool decodeUInt64(const String& key, uint64_t&) override;
- bool decodeInt32(const String& key, int32_t&) override;
- bool decodeInt64(const String& key, int64_t&) override;
- bool decodeFloat(const String& key, float&) override;
- bool decodeDouble(const String& key, double&) override;
- bool decodeString(const String& key, String&) override;
+ WARN_UNUSED_RETURN bool decodeBytes(const String& key, const uint8_t*&, size_t&) override;
+ WARN_UNUSED_RETURN bool decodeBool(const String& key, bool&) override;
+ WARN_UNUSED_RETURN bool decodeUInt32(const String& key, uint32_t&) override;
+ WARN_UNUSED_RETURN bool decodeUInt64(const String& key, uint64_t&) override;
+ WARN_UNUSED_RETURN bool decodeInt32(const String& key, int32_t&) override;
+ WARN_UNUSED_RETURN bool decodeInt64(const String& key, int64_t&) override;
+ WARN_UNUSED_RETURN bool decodeFloat(const String& key, float&) override;
+ WARN_UNUSED_RETURN bool decodeDouble(const String& key, double&) override;
+ WARN_UNUSED_RETURN bool decodeString(const String& key, String&) override;
bool beginObject(const String& key) override;
void endObject() override;
@@ -58,7 +58,7 @@
template<typename T>
const T* getPointerFromDictionaryStack(const String& key);
- template<typename T>
+ template<typename T> WARN_UNUSED_RETURN
bool decodeSimpleValue(const String& key, T& result);
std::unique_ptr<Dictionary> m_rootDictionary;
Modified: trunk/Source/WebCore/platform/glib/KeyedDecoderGlib.h (260077 => 260078)
--- trunk/Source/WebCore/platform/glib/KeyedDecoderGlib.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/glib/KeyedDecoderGlib.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -41,15 +41,15 @@
~KeyedDecoderGlib() override;
private:
- bool decodeBytes(const String& key, const uint8_t*&, size_t&) override;
- bool decodeBool(const String& key, bool&) override;
- bool decodeUInt32(const String& key, uint32_t&) override;
- bool decodeUInt64(const String& key, uint64_t&) override;
- bool decodeInt32(const String& key, int32_t&) override;
- bool decodeInt64(const String& key, int64_t&) override;
- bool decodeFloat(const String& key, float&) override;
- bool decodeDouble(const String& key, double&) override;
- bool decodeString(const String& key, String&) override;
+ WARN_UNUSED_RETURN bool decodeBytes(const String& key, const uint8_t*&, size_t&) override;
+ WARN_UNUSED_RETURN bool decodeBool(const String& key, bool&) override;
+ WARN_UNUSED_RETURN bool decodeUInt32(const String& key, uint32_t&) override;
+ WARN_UNUSED_RETURN bool decodeUInt64(const String& key, uint64_t&) override;
+ WARN_UNUSED_RETURN bool decodeInt32(const String& key, int32_t&) override;
+ WARN_UNUSED_RETURN bool decodeInt64(const String& key, int64_t&) override;
+ WARN_UNUSED_RETURN bool decodeFloat(const String& key, float&) override;
+ WARN_UNUSED_RETURN bool decodeDouble(const String& key, double&) override;
+ WARN_UNUSED_RETURN bool decodeString(const String& key, String&) override;
bool beginObject(const String& key) override;
void endObject() override;
@@ -59,7 +59,7 @@
void endArrayElement() override;
void endArray() override;
- template<typename T, typename F> bool decodeSimpleValue(const String& key, T& result, F getFunction);
+ template<typename T, typename F> WARN_UNUSED_RETURN bool decodeSimpleValue(const String& key, T& result, F getFunction);
HashMap<String, GRefPtr<GVariant>> dictionaryFromGVariant(GVariant*);
Vector<HashMap<String, GRefPtr<GVariant>>> m_dictionaryStack;
Modified: trunk/Source/WebCore/platform/graphics/Region.h (260077 => 260078)
--- trunk/Source/WebCore/platform/graphics/Region.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/graphics/Region.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -79,7 +79,7 @@
template<class Encoder> void encode(Encoder&) const;
template<class Decoder> static Optional<Region> decode(Decoder&);
// FIXME: Remove legacy decode.
- template<class Decoder> static bool decode(Decoder&, Region&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, Region&);
private:
struct Span {
Modified: trunk/Source/WebCore/platform/graphics/RemoteVideoSample.h (260077 => 260078)
--- trunk/Source/WebCore/platform/graphics/RemoteVideoSample.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/graphics/RemoteVideoSample.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -74,7 +74,7 @@
encoder << m_mirrored;
}
- template<class Decoder> static bool decode(Decoder& decoder, RemoteVideoSample& sample)
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder& decoder, RemoteVideoSample& sample)
{
#if HAVE(IOSURFACE)
MachSendRight sendRight;
Modified: trunk/Source/WebCore/platform/mediastream/MediaConstraints.h (260077 => 260078)
--- trunk/Source/WebCore/platform/mediastream/MediaConstraints.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/mediastream/MediaConstraints.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -60,7 +60,7 @@
encoder.encodeEnum(m_dataType);
}
- template <class Decoder> static bool decode(Decoder& decoder, MediaConstraint& constraint)
+ template <class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder& decoder, MediaConstraint& constraint)
{
if (!decoder.decodeEnum(constraint.m_constraintType))
return false;
@@ -343,7 +343,7 @@
encoder << m_ideal;
}
- template <class Decoder> static bool decode(Decoder& decoder, NumericConstraint& constraint)
+ template <class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder& decoder, NumericConstraint& constraint)
{
if (!MediaConstraint::decode(decoder, constraint))
return false;
@@ -513,7 +513,7 @@
encoder << m_ideal;
}
- template <class Decoder> static bool decode(Decoder& decoder, BooleanConstraint& constraint)
+ template <class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder& decoder, BooleanConstraint& constraint)
{
if (!MediaConstraint::decode(decoder, constraint))
return false;
@@ -597,7 +597,7 @@
encoder << m_ideal;
}
- template <class Decoder> static bool decode(Decoder& decoder, StringConstraint& constraint)
+ template <class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder& decoder, StringConstraint& constraint)
{
if (!MediaConstraint::decode(decoder, constraint))
return false;
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCapabilities.h (260077 => 260078)
--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCapabilities.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceCapabilities.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -103,7 +103,7 @@
}
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, CapabilityValueOrRange&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, CapabilityValueOrRange&);
private:
ValueUnion m_minOrValue;
@@ -195,7 +195,7 @@
void setSupportedConstraints(const RealtimeMediaSourceSupportedConstraints& constraints) { m_supportedConstraints = constraints; }
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, RealtimeMediaSourceCapabilities&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, RealtimeMediaSourceCapabilities&);
private:
CapabilityValueOrRange m_width;
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSettings.h (260077 => 260078)
--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSettings.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSettings.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -132,7 +132,7 @@
void setLabel(const AtomString& label) { m_label = label; }
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, RealtimeMediaSourceSettings&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, RealtimeMediaSourceSettings&);
static String convertFlagsToString(const OptionSet<RealtimeMediaSourceSettings::Flag>);
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.h (260077 => 260078)
--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceSupportedConstraints.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -102,7 +102,7 @@
bool supportsConstraint(MediaConstraintType) const;
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, RealtimeMediaSourceSupportedConstraints&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, RealtimeMediaSourceSupportedConstraints&);
private:
bool m_supportsWidth { false };
Modified: trunk/Source/WebCore/platform/network/HTTPHeaderMap.h (260077 => 260078)
--- trunk/Source/WebCore/platform/network/HTTPHeaderMap.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/network/HTTPHeaderMap.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -209,7 +209,7 @@
}
template <class Encoder> void encode(Encoder&) const;
- template <class Decoder> static bool decode(Decoder&, HTTPHeaderMap&);
+ template <class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, HTTPHeaderMap&);
private:
void setUncommonHeader(const String& name, const String& value);
Modified: trunk/Source/WebCore/platform/network/NetworkLoadMetrics.h (260077 => 260078)
--- trunk/Source/WebCore/platform/network/NetworkLoadMetrics.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/network/NetworkLoadMetrics.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -139,7 +139,7 @@
}
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, NetworkLoadMetrics&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, NetworkLoadMetrics&);
String remoteAddress;
String connectionIdentifier;
Modified: trunk/Source/WebCore/platform/network/ResourceRequestBase.h (260077 => 260078)
--- trunk/Source/WebCore/platform/network/ResourceRequestBase.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/network/ResourceRequestBase.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -187,7 +187,7 @@
bool encodingRequiresPlatformData() const { return true; }
#endif
template<class Encoder> void encodeWithoutPlatformData(Encoder&) const;
- template<class Decoder> bool decodeWithoutPlatformData(Decoder&);
+ template<class Decoder> WARN_UNUSED_RETURN bool decodeWithoutPlatformData(Decoder&);
WEBCORE_EXPORT static double defaultTimeoutInterval(); // May return 0 when using platform default.
WEBCORE_EXPORT static void setDefaultTimeoutInterval(double);
@@ -226,7 +226,7 @@
void updateResourceRequest(HTTPBodyUpdatePolicy = HTTPBodyUpdatePolicy::DoNotUpdateHTTPBody) const;
template<class Encoder> void encodeBase(Encoder&) const;
- template<class Decoder> bool decodeBase(Decoder&);
+ template<class Decoder> WARN_UNUSED_RETURN bool decodeBase(Decoder&);
// The ResourceRequest subclass may "shadow" this method to compare platform specific fields
static bool platformCompare(const ResourceRequest&, const ResourceRequest&) { return true; }
Modified: trunk/Source/WebCore/platform/network/ResourceResponseBase.h (260077 => 260078)
--- trunk/Source/WebCore/platform/network/ResourceResponseBase.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/network/ResourceResponseBase.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -203,7 +203,7 @@
static bool compare(const ResourceResponse&, const ResourceResponse&);
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, ResourceResponseBase&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, ResourceResponseBase&);
bool isRangeRequested() const { return m_isRangeRequested; }
void setAsRangeRequested() { m_isRangeRequested = true; }
@@ -308,7 +308,7 @@
}
template<class Decoder>
-bool WARN_UNUSED_RETURN ResourceResponseBase::decode(Decoder& decoder, ResourceResponseBase& response)
+bool ResourceResponseBase::decode(Decoder& decoder, ResourceResponseBase& response)
{
ASSERT(response.m_isNull);
Optional<bool> responseIsNull;
Modified: trunk/Source/WebCore/platform/network/SameSiteInfo.h (260077 => 260078)
--- trunk/Source/WebCore/platform/network/SameSiteInfo.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/network/SameSiteInfo.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -37,7 +37,7 @@
bool isSafeHTTPMethod { false };
template <class Encoder> void encode(Encoder&) const;
- template <class Decoder> static bool decode(Decoder&, SameSiteInfo&);
+ template <class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, SameSiteInfo&);
};
template <class Encoder>
Modified: trunk/Source/WebCore/platform/network/SocketStreamError.h (260077 => 260078)
--- trunk/Source/WebCore/platform/network/SocketStreamError.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/network/SocketStreamError.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -59,7 +59,7 @@
const String& localizedDescription() const { return m_localizedDescription; }
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, SocketStreamError&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, SocketStreamError&);
private:
int m_errorCode { 0 };
Modified: trunk/Source/WebCore/platform/network/curl/ResourceRequest.h (260077 => 260078)
--- trunk/Source/WebCore/platform/network/curl/ResourceRequest.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/network/curl/ResourceRequest.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -71,7 +71,7 @@
static void setHTTPPipeliningEnabled(bool) { }
template<class Encoder> void encodeWithPlatformData(Encoder&) const;
- template<class Decoder> bool decodeWithPlatformData(Decoder&);
+ template<class Decoder> WARN_UNUSED_RETURN bool decodeWithPlatformData(Decoder&);
private:
friend class ResourceRequestBase;
Modified: trunk/Source/WebCore/platform/network/soup/ResourceRequest.h (260077 => 260078)
--- trunk/Source/WebCore/platform/network/soup/ResourceRequest.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/network/soup/ResourceRequest.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -104,7 +104,7 @@
GUniquePtr<SoupURI> createSoupURI() const;
template<class Encoder> void encodeWithPlatformData(Encoder&) const;
- template<class Decoder> bool decodeWithPlatformData(Decoder&);
+ template<class Decoder> WARN_UNUSED_RETURN bool decodeWithPlatformData(Decoder&);
private:
friend class ResourceRequestBase;
Modified: trunk/Source/WebCore/platform/network/soup/ResourceResponse.h (260077 => 260078)
--- trunk/Source/WebCore/platform/network/soup/ResourceResponse.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/platform/network/soup/ResourceResponse.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -73,7 +73,7 @@
void setSoupMessageTLSErrors(GTlsCertificateFlags tlsErrors) { m_tlsErrors = tlsErrors; }
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, ResourceResponse&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, ResourceResponse&);
private:
friend class ResourceResponseBase;
Modified: trunk/Source/WebCore/rendering/EventRegion.h (260077 => 260078)
--- trunk/Source/WebCore/rendering/EventRegion.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/rendering/EventRegion.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -87,7 +87,7 @@
template<class Encoder> void encode(Encoder&) const;
template<class Decoder> static Optional<EventRegion> decode(Decoder&);
// FIXME: Remove legacy decode.
- template<class Decoder> static bool decode(Decoder&, EventRegion&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, EventRegion&);
void dump(TextStream&) const;
Modified: trunk/Source/WebCore/workers/service/ServiceWorkerFetchResult.h (260077 => 260078)
--- trunk/Source/WebCore/workers/service/ServiceWorkerFetchResult.h 2020-04-14 16:38:50 UTC (rev 260077)
+++ trunk/Source/WebCore/workers/service/ServiceWorkerFetchResult.h 2020-04-14 17:03:25 UTC (rev 260078)
@@ -45,7 +45,7 @@
ServiceWorkerFetchResult isolatedCopy() const { return { jobDataIdentifier, registrationKey.isolatedCopy(), script.isolatedCopy(), contentSecurityPolicy.isolatedCopy(), referrerPolicy.isolatedCopy(), scriptError.isolatedCopy() }; }
template<class Encoder> void encode(Encoder&) const;
- template<class Decoder> static bool decode(Decoder&, ServiceWorkerFetchResult&);
+ template<class Decoder> static WARN_UNUSED_RETURN bool decode(Decoder&, ServiceWorkerFetchResult&);
};
inline ServiceWorkerFetchResult serviceWorkerFetchError(ServiceWorkerJobDataIdentifier jobDataIdentifier, ServiceWorkerRegistrationKey&& registrationKey, ResourceError&& error)
