Title: [260481] trunk/Source/_javascript_Core
- Revision
- 260481
- Author
- keith_mil...@apple.com
- Date
- 2020-04-21 18:27:49 -0700 (Tue, 21 Apr 2020)
Log Message
JSC's options should be case insensitive
https://bugs.webkit.org/show_bug.cgi?id=210834
Reviewed by Yusuke Suzuki.
* runtime/Options.cpp:
(JSC::Options::setOptionWithoutAlias):
(JSC::Options::setAliasedOption):
* runtime/OptionsList.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (260480 => 260481)
--- trunk/Source/_javascript_Core/ChangeLog 2020-04-22 00:57:52 UTC (rev 260480)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-04-22 01:27:49 UTC (rev 260481)
@@ -1,3 +1,15 @@
+2020-04-21 Keith Miller <keith_mil...@apple.com>
+
+ JSC's options should be case insensitive
+ https://bugs.webkit.org/show_bug.cgi?id=210834
+
+ Reviewed by Yusuke Suzuki.
+
+ * runtime/Options.cpp:
+ (JSC::Options::setOptionWithoutAlias):
+ (JSC::Options::setAliasedOption):
+ * runtime/OptionsList.h:
+
2020-04-21 Alexey Shvayka <shvaikal...@gmail.com>
constructObjectFromPropertyDescriptor() is incorrect with partial descriptors
Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (260480 => 260481)
--- trunk/Source/_javascript_Core/runtime/Options.cpp 2020-04-22 00:57:52 UTC (rev 260480)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp 2020-04-22 01:27:49 UTC (rev 260481)
@@ -773,8 +773,8 @@
// if the value makes sense. Otherwise, move on to checking the next option.
#define SET_OPTION_IF_MATCH(type_, name_, defaultValue_, availability_, description_) \
if (strlen(#name_) == static_cast<size_t>(equalStr - arg) \
- && !strncmp(arg, #name_, equalStr - arg)) { \
- if (Availability::availability_ != Availability::Normal \
+ && !strncasecmp(arg, #name_, equalStr - arg)) { \
+ if (Availability::availability_ != Availability::Normal \
&& !isAvailable(name_##ID, Availability::availability_)) \
return false; \
Optional<OptionsStorage::type_> value; \
@@ -817,7 +817,7 @@
// if the value makes sense. Otherwise, move on to checking the next option.
#define FOR_EACH_OPTION(aliasedName_, unaliasedName_, equivalence) \
if (strlen(#aliasedName_) == static_cast<size_t>(equalStr - arg) \
- && !strncmp(arg, #aliasedName_, equalStr - arg)) { \
+ && !strncasecmp(arg, #aliasedName_, equalStr - arg)) { \
String unaliasedOption(#unaliasedName_); \
if (equivalence == SameOption) \
unaliasedOption = unaliasedOption + equalStr; \
@@ -828,7 +828,7 @@
return false; \
unaliasedOption = unaliasedOption + "=" + invertedValueStr; \
} \
- return setOptionWithoutAlias(unaliasedOption.utf8().data()); \
+ return setOptionWithoutAlias(unaliasedOption.utf8().data()); \
}
FOR_EACH_JSC_ALIASED_OPTION(FOR_EACH_OPTION)
Modified: trunk/Source/_javascript_Core/runtime/OptionsList.h (260480 => 260481)
--- trunk/Source/_javascript_Core/runtime/OptionsList.h 2020-04-22 00:57:52 UTC (rev 260480)
+++ trunk/Source/_javascript_Core/runtime/OptionsList.h 2020-04-22 01:27:49 UTC (rev 260481)
@@ -541,7 +541,6 @@
v(enableOSRExitFuzz, useOSRExitFuzz, SameOption) \
v(enableDollarVM, useDollarVM, SameOption) \
v(enableWebAssembly, useWebAssembly, SameOption) \
- v(verboseDFGByteCodeParsing, verboseDFGBytecodeParsing, SameOption) \
v(maximumOptimizationCandidateInstructionCount, maximumOptimizationCandidateBytecodeCost, SameOption) \
v(maximumFunctionForCallInlineCandidateInstructionCount, maximumFunctionForCallInlineCandidateBytecodeCost, SameOption) \
v(maximumFunctionForClosureCallInlineCandidateInstructionCount, maximumFunctionForClosureCallInlineCandidateBytecodeCost, SameOption) \
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
