Title: [262659] trunk/Source
- Revision
- 262659
- Author
- katherine_che...@apple.com
- Date
- 2020-06-05 15:12:07 -0700 (Fri, 05 Jun 2020)
Log Message
ITP SQLite Database should only vacuum once per day
https://bugs.webkit.org/show_bug.cgi?id=212712
<rdar://problem/63939711>
Reviewed by Brent Fulgham.
Source/WebCore:
Add WEBCORE_EXPORT macro to function needed in WebKit.
* platform/sql/SQLiteDatabase.h:
Source/WebKit:
Followup to https://trac.webkit.org/changeset/262538/webkit. We should
run incremental auto vacuum, not a full vacuum, once per-day, because
it is less expensive.
* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
* NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::performDailyTasks):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (262658 => 262659)
--- trunk/Source/WebCore/ChangeLog 2020-06-05 22:05:34 UTC (rev 262658)
+++ trunk/Source/WebCore/ChangeLog 2020-06-05 22:12:07 UTC (rev 262659)
@@ -1,3 +1,15 @@
+2020-06-05 Kate Cheney <katherine_che...@apple.com>
+
+ ITP SQLite Database should only vacuum once per day
+ https://bugs.webkit.org/show_bug.cgi?id=212712
+ <rdar://problem/63939711>
+
+ Reviewed by Brent Fulgham.
+
+ Add WEBCORE_EXPORT macro to function needed in WebKit.
+
+ * platform/sql/SQLiteDatabase.h:
+
2020-06-05 Sam Weinig <wei...@apple.com>
Some tests in css/css-color/parsing/system-color-valid.html are failing
Modified: trunk/Source/WebCore/platform/sql/SQLiteDatabase.h (262658 => 262659)
--- trunk/Source/WebCore/platform/sql/SQLiteDatabase.h 2020-06-05 22:05:34 UTC (rev 262658)
+++ trunk/Source/WebCore/platform/sql/SQLiteDatabase.h 2020-06-05 22:12:07 UTC (rev 262659)
@@ -66,7 +66,7 @@
WEBCORE_EXPORT bool tableExists(const String&);
WEBCORE_EXPORT void clearAllTables();
WEBCORE_EXPORT int runVacuumCommand();
- int runIncrementalVacuumCommand();
+ WEBCORE_EXPORT int runIncrementalVacuumCommand();
bool transactionInProgress() const { return m_transactionInProgress; }
Modified: trunk/Source/WebKit/ChangeLog (262658 => 262659)
--- trunk/Source/WebKit/ChangeLog 2020-06-05 22:05:34 UTC (rev 262658)
+++ trunk/Source/WebKit/ChangeLog 2020-06-05 22:12:07 UTC (rev 262659)
@@ -1,3 +1,20 @@
+2020-06-05 Kate Cheney <katherine_che...@apple.com>
+
+ ITP SQLite Database should only vacuum once per day
+ https://bugs.webkit.org/show_bug.cgi?id=212712
+ <rdar://problem/63939711>
+
+ Reviewed by Brent Fulgham.
+
+ Followup to https://trac.webkit.org/changeset/262538/webkit. We should
+ run incremental auto vacuum, not a full vacuum, once per-day, because
+ it is less expensive.
+
+ * NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
+ * NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
+ * NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
+ (WebKit::WebResourceLoadStatisticsStore::performDailyTasks):
+
2020-06-05 Daniel Bates <daba...@apple.com>
-_focusTextInputContext should reposition the caret if called for an already focused text input context
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp (262658 => 262659)
--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp 2020-06-05 22:05:34 UTC (rev 262658)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp 2020-06-05 22:12:07 UTC (rev 262659)
@@ -1470,10 +1470,10 @@
reclassifyResources();
}
-void ResourceLoadStatisticsDatabaseStore::runVacuumCommand()
+void ResourceLoadStatisticsDatabaseStore::runIncrementalVacuumCommand()
{
ASSERT(!RunLoop::isMain());
- m_database.runVacuumCommand();
+ m_database.runIncrementalVacuumCommand();
}
bool ResourceLoadStatisticsDatabaseStore::hasStorageAccess(const TopFrameDomain& topFrameDomain, const SubFrameDomain& subFrameDomain) const
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h (262658 => 262659)
--- trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h 2020-06-05 22:05:34 UTC (rev 262658)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h 2020-06-05 22:12:07 UTC (rev 262659)
@@ -95,7 +95,7 @@
void classifyPrevalentResources() override;
void syncStorageIfNeeded() override { };
void syncStorageImmediately() override { };
- void runVacuumCommand();
+ void runIncrementalVacuumCommand();
void requestStorageAccessUnderOpener(DomainInNeedOfStorageAccess&&, WebCore::PageIdentifier openerID, OpenerDomain&&) override;
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp (262658 => 262659)
--- trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp 2020-06-05 22:05:34 UTC (rev 262658)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp 2020-06-05 22:12:07 UTC (rev 262659)
@@ -738,7 +738,7 @@
m_statisticsStore->calculateAndSubmitTelemetry();
}
if (is<ResourceLoadStatisticsDatabaseStore>(*m_statisticsStore))
- downcast<ResourceLoadStatisticsDatabaseStore>(*m_statisticsStore).runVacuumCommand();
+ downcast<ResourceLoadStatisticsDatabaseStore>(*m_statisticsStore).runIncrementalVacuumCommand();
});
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
