Title: [264307] trunk/Source/WebKit
- Revision
- 264307
- Author
- bfulg...@apple.com
- Date
- 2020-07-13 12:00:09 -0700 (Mon, 13 Jul 2020)
Log Message
REGRESSION (r262538): Nullptr Deref in WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::performDailyTasks()::$_66, void>::call
https://bugs.webkit.org/show_bug.cgi?id=214264
<rdar://problem/65093949>
Reviewed by Darin Adler.
A new type check was added outside of the protecting nullptr check. This introduced
a new nullptr dereference bug.
* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::performDailyTasks):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (264306 => 264307)
--- trunk/Source/WebKit/ChangeLog 2020-07-13 17:57:59 UTC (rev 264306)
+++ trunk/Source/WebKit/ChangeLog 2020-07-13 19:00:09 UTC (rev 264307)
@@ -1,3 +1,17 @@
+2020-07-13 Brent Fulgham <bfulg...@apple.com>
+
+ REGRESSION (r262538): Nullptr Deref in WTF::Detail::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::performDailyTasks()::$_66, void>::call
+ https://bugs.webkit.org/show_bug.cgi?id=214264
+ <rdar://problem/65093949>
+
+ Reviewed by Darin Adler.
+
+ A new type check was added outside of the protecting nullptr check. This introduced
+ a new nullptr dereference bug.
+
+ * NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
+ (WebKit::WebResourceLoadStatisticsStore::performDailyTasks):
+
2020-07-13 Kate Cheney <katherine_che...@apple.com>
Add artificial delay to WebSocket connections to mitigate port scanning attacks
Modified: trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp (264306 => 264307)
--- trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp 2020-07-13 17:57:59 UTC (rev 264306)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp 2020-07-13 19:00:09 UTC (rev 264307)
@@ -755,9 +755,9 @@
if (m_statisticsStore) {
m_statisticsStore->includeTodayAsOperatingDateIfNecessary();
m_statisticsStore->calculateAndSubmitTelemetry();
+ if (is<ResourceLoadStatisticsDatabaseStore>(*m_statisticsStore))
+ downcast<ResourceLoadStatisticsDatabaseStore>(*m_statisticsStore).runIncrementalVacuumCommand();
}
- if (is<ResourceLoadStatisticsDatabaseStore>(*m_statisticsStore))
- downcast<ResourceLoadStatisticsDatabaseStore>(*m_statisticsStore).runIncrementalVacuumCommand();
});
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
