- Revision
- 267458
- Author
- krol...@apple.com
- Date
- 2020-09-22 20:38:17 -0700 (Tue, 22 Sep 2020)
Log Message
Unify debug and release target aliases
https://bugs.webkit.org/show_bug.cgi?id=216863
<rdar://problem/69407746>
Reviewed by Tim Horton.
All Makefiles have "debug", "d", "release", and "r" for build
targets. Others -- but not all -- also include "dev", "develop",
"development", "dep", "deploy", and "deployment". Because of this
inconsistency, trying to use those additional targets didn't work. It
looks like all Makefiles used to support all of those targets, but
some got dropped along the way. For instance, the top-level Makefile
and Source/Makefile dropped them in 2013 as part of Bug 107863. And it
looks like WebKitLibraries/Makefile never had them. Given that those
additional targets don't work, it seems like no one uses them, so
let's remove them completely.
.:
* Makefile.shared:
Source/ThirdParty:
* Makefile:
Tools:
* Makefile:
Modified Paths
Diff
Modified: trunk/ChangeLog (267457 => 267458)
--- trunk/ChangeLog 2020-09-23 03:36:13 UTC (rev 267457)
+++ trunk/ChangeLog 2020-09-23 03:38:17 UTC (rev 267458)
@@ -1,5 +1,26 @@
2020-09-22 Keith Rollin <krol...@apple.com>
+ Unify debug and release target aliases
+ https://bugs.webkit.org/show_bug.cgi?id=216863
+ <rdar://problem/69407746>
+
+ Reviewed by Tim Horton.
+
+ All Makefiles have "debug", "d", "release", and "r" for build
+ targets. Others -- but not all -- also include "dev", "develop",
+ "development", "dep", "deploy", and "deployment". Because of this
+ inconsistency, trying to use those additional targets didn't work. It
+ looks like all Makefiles used to support all of those targets, but
+ some got dropped along the way. For instance, the top-level Makefile
+ and Source/Makefile dropped them in 2013 as part of Bug 107863. And it
+ looks like WebKitLibraries/Makefile never had them. Given that those
+ additional targets don't work, it seems like no one uses them, so
+ let's remove them completely.
+
+ * Makefile.shared:
+
+2020-09-22 Keith Rollin <krol...@apple.com>
+
Refactor build rules in Makefiles and Makefile.shared
https://bugs.webkit.org/show_bug.cgi?id=216806
<rdar://problem/69332316>
Modified: trunk/Makefile.shared (267457 => 267458)
--- trunk/Makefile.shared 2020-09-23 03:36:13 UTC (rev 267457)
+++ trunk/Makefile.shared 2020-09-23 03:38:17 UTC (rev 267458)
@@ -109,11 +109,11 @@
endif
@$(call invoke_xcode,,GCC_PREPROCESSOR_DEFINITIONS='$(GCC_PREPROCESSOR_ADDITIONS) $$(inherited)')
-debug d development dev develop: force
+debug d: force
@$(call set_webkit_configuration,--debug)
@$(call invoke_xcode,,GCC_PREPROCESSOR_DEFINITIONS='$(GCC_PREPROCESSOR_ADDITIONS) $$(inherited)')
-release r deployment dep deploy: force
+release r: force
@$(call set_webkit_configuration,--release)
@$(call invoke_xcode,,GCC_PREPROCESSOR_DEFINITIONS='$(GCC_PREPROCESSOR_ADDITIONS) $$(inherited)')
Modified: trunk/Source/ThirdParty/ChangeLog (267457 => 267458)
--- trunk/Source/ThirdParty/ChangeLog 2020-09-23 03:36:13 UTC (rev 267457)
+++ trunk/Source/ThirdParty/ChangeLog 2020-09-23 03:38:17 UTC (rev 267458)
@@ -1,5 +1,26 @@
2020-09-22 Keith Rollin <krol...@apple.com>
+ Unify debug and release target aliases
+ https://bugs.webkit.org/show_bug.cgi?id=216863
+ <rdar://problem/69407746>
+
+ Reviewed by Tim Horton.
+
+ All Makefiles have "debug", "d", "release", and "r" for build
+ targets. Others -- but not all -- also include "dev", "develop",
+ "development", "dep", "deploy", and "deployment". Because of this
+ inconsistency, trying to use those additional targets didn't work. It
+ looks like all Makefiles used to support all of those targets, but
+ some got dropped along the way. For instance, the top-level Makefile
+ and Source/Makefile dropped them in 2013 as part of Bug 107863. And it
+ looks like WebKitLibraries/Makefile never had them. Given that those
+ additional targets don't work, it seems like no one uses them, so
+ let's remove them completely.
+
+ * Makefile:
+
+2020-09-22 Keith Rollin <krol...@apple.com>
+
Refactor build rules in Makefiles and Makefile.shared
https://bugs.webkit.org/show_bug.cgi?id=216806
<rdar://problem/69332316>
Modified: trunk/Source/ThirdParty/Makefile (267457 => 267458)
--- trunk/Source/ThirdParty/Makefile 2020-09-23 03:36:13 UTC (rev 267457)
+++ trunk/Source/ThirdParty/Makefile 2020-09-23 03:38:17 UTC (rev 267458)
@@ -35,10 +35,10 @@
all:
@$(build_target_for_each_module)
-debug d development dev develop:
+debug d:
@$(build_target_for_each_module)
-release r deployment dep deploy:
+release r:
@$(build_target_for_each_module)
release+assert ra:
Modified: trunk/Tools/ChangeLog (267457 => 267458)
--- trunk/Tools/ChangeLog 2020-09-23 03:36:13 UTC (rev 267457)
+++ trunk/Tools/ChangeLog 2020-09-23 03:38:17 UTC (rev 267458)
@@ -1,3 +1,24 @@
+2020-09-22 Keith Rollin <krol...@apple.com>
+
+ Unify debug and release target aliases
+ https://bugs.webkit.org/show_bug.cgi?id=216863
+ <rdar://problem/69407746>
+
+ Reviewed by Tim Horton.
+
+ All Makefiles have "debug", "d", "release", and "r" for build
+ targets. Others -- but not all -- also include "dev", "develop",
+ "development", "dep", "deploy", and "deployment". Because of this
+ inconsistency, trying to use those additional targets didn't work. It
+ looks like all Makefiles used to support all of those targets, but
+ some got dropped along the way. For instance, the top-level Makefile
+ and Source/Makefile dropped them in 2013 as part of Bug 107863. And it
+ looks like WebKitLibraries/Makefile never had them. Given that those
+ additional targets don't work, it seems like no one uses them, so
+ let's remove them completely.
+
+ * Makefile:
+
2020-09-22 Alex Christensen <achristen...@webkit.org>
Make TLSVersion API tests more robust.
Modified: trunk/Tools/Makefile (267457 => 267458)
--- trunk/Tools/Makefile 2020-09-23 03:36:13 UTC (rev 267457)
+++ trunk/Tools/Makefile 2020-09-23 03:38:17 UTC (rev 267458)
@@ -31,10 +31,10 @@
all:
@$(build_target_for_each_module)
-debug d development dev develop:
+debug d:
@$(build_target_for_each_module)
-release r deployment dep deploy:
+release r:
@$(build_target_for_each_module)
release+assert ra:
