Title: [267902] trunk
- Revision
- 267902
- Author
- krol...@apple.com
- Date
- 2020-10-02 17:18:25 -0700 (Fri, 02 Oct 2020)
Log Message
Seeing "usage: basename string [suffix]" spam when using make to build
https://bugs.webkit.org/show_bug.cgi?id=217231
<rdar://problem/69889138>
Reviewed by Darin Adler.
The name of the project being built is no longer displayed when using
XCBuild. Therefore, https://bugs.webkit.org/show_bug.cgi?id=216865
taught the Makefile to perform this logging. The approach took
advantage of a `make` variable (PATH_FROM_ROOT) that tracks the
relative path from the root of the build hierarchy to the current
project. However, that variable may not be initialized if the build is
not initiated from the root. Therefore, don't count on that variable,
and get the name of the current project by invoking `pwd`.
* Makefile.shared:
Modified Paths
Diff
Modified: trunk/ChangeLog (267901 => 267902)
--- trunk/ChangeLog 2020-10-02 23:28:01 UTC (rev 267901)
+++ trunk/ChangeLog 2020-10-03 00:18:25 UTC (rev 267902)
@@ -1,3 +1,22 @@
+2020-10-02 Keith Rollin <krol...@apple.com>
+
+ Seeing "usage: basename string [suffix]" spam when using make to build
+ https://bugs.webkit.org/show_bug.cgi?id=217231
+ <rdar://problem/69889138>
+
+ Reviewed by Darin Adler.
+
+ The name of the project being built is no longer displayed when using
+ XCBuild. Therefore, https://bugs.webkit.org/show_bug.cgi?id=216865
+ taught the Makefile to perform this logging. The approach took
+ advantage of a `make` variable (PATH_FROM_ROOT) that tracks the
+ relative path from the root of the build hierarchy to the current
+ project. However, that variable may not be initialized if the build is
+ not initiated from the root. Therefore, don't count on that variable,
+ and get the name of the current project by invoking `pwd`.
+
+ * Makefile.shared:
+
2020-10-02 Sam Weinig <wei...@apple.com>
Remove code behind ENABLE(MEDIA_SESSION), no ports enable it
Modified: trunk/Makefile.shared (267901 => 267902)
--- trunk/Makefile.shared 2020-10-02 23:28:01 UTC (rev 267901)
+++ trunk/Makefile.shared 2020-10-03 00:18:25 UTC (rev 267902)
@@ -100,7 +100,7 @@
( \
[[ -t 1 ]] && COLOR_DIAGNOSTICS_ARG="COLOR_DIAGNOSTICS=YES"; \
echo; \
- echo "===== BUILDING $$(basename $(PATH_FROM_ROOT)) ====="; \
+ echo "===== BUILDING $$(basename "$$(pwd)") ====="; \
echo; \
$1 xcodebuild $(OTHER_OPTIONS) $(XCODE_OPTIONS) $2 | $(OUTPUT_FILTER) && exit $${PIPESTATUS[0]} \
)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
