Title: [268581] trunk/Tools
- Revision
- 268581
- Author
- clo...@igalia.com
- Date
- 2020-10-16 05:33:52 -0700 (Fri, 16 Oct 2020)
Log Message
Ensure the tests are run with US/Pacific time zone
https://bugs.webkit.org/show_bug.cgi?id=186612
Reviewed by Michael Catanzaro.
Some tests fail if the time zone is not set to US/Pacific, and
this causes issues for contributors living outside of that timezone.
Ideally we should fix those tests, but in the meantime setting this
environment variable before starting the layout tests seems like
an acceptable workaround. Note that something similar is also
already done for the JSC tests.
* Scripts/webkitpy/port/base.py:
(Port.setup_environ_for_server):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (268580 => 268581)
--- trunk/Tools/ChangeLog 2020-10-16 12:33:15 UTC (rev 268580)
+++ trunk/Tools/ChangeLog 2020-10-16 12:33:52 UTC (rev 268581)
@@ -1,3 +1,20 @@
+2020-10-16 Carlos Alberto Lopez Perez <clo...@igalia.com>
+
+ Ensure the tests are run with US/Pacific time zone
+ https://bugs.webkit.org/show_bug.cgi?id=186612
+
+ Reviewed by Michael Catanzaro.
+
+ Some tests fail if the time zone is not set to US/Pacific, and
+ this causes issues for contributors living outside of that timezone.
+ Ideally we should fix those tests, but in the meantime setting this
+ environment variable before starting the layout tests seems like
+ an acceptable workaround. Note that something similar is also
+ already done for the JSC tests.
+
+ * Scripts/webkitpy/port/base.py:
+ (Port.setup_environ_for_server):
+
2020-10-15 Sam Weinig <wei...@apple.com>
Attempt to fix the build.
Modified: trunk/Tools/Scripts/webkitpy/port/base.py (268580 => 268581)
--- trunk/Tools/Scripts/webkitpy/port/base.py 2020-10-16 12:33:15 UTC (rev 268580)
+++ trunk/Tools/Scripts/webkitpy/port/base.py 2020-10-16 12:33:52 UTC (rev 268581)
@@ -930,6 +930,9 @@
[name, value] = string_variable.split('=', 1)
clean_env[name] = value
+ # FIXME: Some tests fail if the time zone is not set to US/Pacific (<https://webkit.org/b/186612>)
+ clean_env['TZ'] = 'US/Pacific'
+
return clean_env
def _clear_global_caches_and_temporary_files(self):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
