[webkit-changes] [271675] trunk/Tools

Wed, 20 Jan 2021 15:06:42 -0800

Title: [271675] trunk/Tools
Revision
271675
Author
aakash_j...@apple.com
Date
2021-01-20 15:06:00 -0800 (Wed, 20 Jan 2021)

Log Message

EWS should display commit identifier in builds
https://bugs.webkit.org/show_bug.cgi?id=220769

Reviewed by Jonathan Bedard.

* CISupport/ews-build/factories.py:
(Factory.__init__): Added ShowIdentifier build step.
(StyleFactory.__init__):
(WatchListFactory.__init__):
(CommitQueueFactory.__init__):
* CISupport/ews-build/steps.py:
(ShowIdentifier): build-step to show commit identifier.
(ShowIdentifier.start):
(ShowIdentifier.evaluateCommand):
(ShowIdentifier.getLastBuildStepByName):
(ShowIdentifier.url_for_identifier):
(ShowIdentifier.getResultSummary): Display custom failure message.
(ShowIdentifier.hideStepIf): Hide this step if successful.
* CISupport/ews-build/steps_unittest.py: Added unit-tests.
* CISupport/ews-build/factories_unittest.py:

Modified Paths

Diff

Modified: trunk/Tools/CISupport/ews-build/factories.py (271674 => 271675)


--- trunk/Tools/CISupport/ews-build/factories.py	2021-01-20 22:38:10 UTC (rev 271674)
+++ trunk/Tools/CISupport/ews-build/factories.py	2021-01-20 23:06:00 UTC (rev 271675)
@@ -30,7 +30,7 @@
                    InstallWpeDependencies, KillOldProcesses, PrintConfiguration, PushCommitToWebKitRepo,
                    RunAPITests, RunBindingsTests, RunBuildWebKitOrgUnitTests, RunEWSBuildbotCheckConfig, RunEWSUnitTests,
                    RunResultsdbpyTests, RunJavaScriptCoreTests, RunWebKit1Tests, RunWebKitPerlTests, RunWebKitPyPython2Tests,
-                   RunWebKitPyPython3Tests, RunWebKitTests, SetBuildSummary, TriggerCrashLogSubmission, UpdateWorkingDirectory,
+                   RunWebKitPyPython3Tests, RunWebKitTests, SetBuildSummary, ShowIdentifier, TriggerCrashLogSubmission, UpdateWorkingDirectory,
                    ValidatePatch, ValidateChangeLogAndReviewer, ValidateCommiterAndReviewer, WaitForCrashCollection)
 
 
@@ -47,6 +47,7 @@
         # automatically apply the patch to the repo, and that doesn't handle ChangeLogs well. See https://webkit.org/b/193138
         # Therefore we add CheckOutSpecificRevision step to checkout required revision.
         self.addStep(CheckOutSpecificRevision())
+        self.addStep(ShowIdentifier())
         self.addStep(ApplyPatch())
 
 
@@ -57,6 +58,7 @@
         self.addStep(ValidatePatch())
         self.addStep(PrintConfiguration())
         self.addStep(CheckOutSource())
+        self.addStep(ShowIdentifier())
         self.addStep(UpdateWorkingDirectory())
         self.addStep(ApplyPatch())
         self.addStep(CheckStyle())
@@ -69,6 +71,7 @@
         self.addStep(ValidatePatch())
         self.addStep(PrintConfiguration())
         self.addStep(CheckOutSource())
+        self.addStep(ShowIdentifier())
         self.addStep(UpdateWorkingDirectory())
         self.addStep(ApplyPatch())
         self.addStep(ApplyWatchList())
@@ -256,6 +259,7 @@
         self.addStep(ValidateCommiterAndReviewer())
         self.addStep(PrintConfiguration())
         self.addStep(CheckOutSource())
+        self.addStep(ShowIdentifier())
         self.addStep(UpdateWorkingDirectory())
         self.addStep(ApplyPatch())
         self.addStep(ValidateChangeLogAndReviewer())

Modified: trunk/Tools/CISupport/ews-build/factories_unittest.py (271674 => 271675)


--- trunk/Tools/CISupport/ews-build/factories_unittest.py	2021-01-20 22:38:10 UTC (rev 271674)
+++ trunk/Tools/CISupport/ews-build/factories_unittest.py	2021-01-20 23:06:00 UTC (rev 271675)
@@ -56,6 +56,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
         ])
 
@@ -69,6 +70,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
         ])
 
@@ -85,6 +87,7 @@
             _BuildStepFactory(steps.ValidatePatch),
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.UpdateWorkingDirectory),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.CheckStyle),
@@ -98,6 +101,7 @@
             _BuildStepFactory(steps.ValidatePatch),
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.UpdateWorkingDirectory),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.ApplyWatchList),
@@ -113,6 +117,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.RunBindingsTests),
         ])
@@ -126,6 +131,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.RunWebKitPerlTests),
         ])
@@ -140,6 +146,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.RunWebKitPyPython2Tests),
             _BuildStepFactory(steps.RunWebKitPyPython3Tests),
@@ -156,6 +163,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.RunEWSUnitTests),
             _BuildStepFactory(steps.RunEWSBuildbotCheckConfig),
@@ -174,6 +182,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileWebKit, skipUpload=False),
@@ -188,6 +197,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileWebKit, skipUpload=False),
@@ -203,6 +213,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileWebKit, skipUpload=True),
@@ -217,6 +228,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileWebKit, skipUpload=False),
@@ -231,6 +243,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileWebKit, skipUpload=True),
@@ -245,6 +258,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileWebKit, skipUpload=True),
@@ -259,6 +273,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileWebKit, skipUpload=True),
@@ -273,6 +288,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.InstallGtkDependencies),
@@ -288,6 +304,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.InstallWpeDependencies),
@@ -303,6 +320,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileWebKit, skipUpload=True),
@@ -318,6 +336,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileJSC),
@@ -333,6 +352,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileJSC),
@@ -350,6 +370,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileWebKit, skipUpload=True),
@@ -369,6 +390,7 @@
             _BuildStepFactory(steps.ValidateCommiterAndReviewer),
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.UpdateWorkingDirectory),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.ValidateChangeLogAndReviewer),
@@ -400,6 +422,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.DownloadBuiltProduct),
             _BuildStepFactory(steps.ExtractBuiltProduct),
@@ -420,6 +443,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.DownloadBuiltProduct),
             _BuildStepFactory(steps.ExtractBuiltProduct),
@@ -439,6 +463,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.DownloadBuiltProduct),
             _BuildStepFactory(steps.ExtractBuiltProduct),
@@ -458,6 +483,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.DownloadBuiltProduct),
             _BuildStepFactory(steps.ExtractBuiltProduct),
@@ -477,6 +503,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.InstallGtkDependencies),
             _BuildStepFactory(steps.DownloadBuiltProduct),
@@ -498,6 +525,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileJSC),
@@ -513,6 +541,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileJSC),
@@ -530,6 +559,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileJSC),
@@ -545,6 +575,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.KillOldProcesses),
             _BuildStepFactory(steps.CompileJSC),
@@ -562,6 +593,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.DownloadBuiltProduct),
             _BuildStepFactory(steps.ExtractBuiltProduct),
@@ -579,6 +611,7 @@
             _BuildStepFactory(steps.PrintConfiguration),
             _BuildStepFactory(steps.CheckOutSource),
             _BuildStepFactory(steps.CheckOutSpecificRevision),
+            _BuildStepFactory(steps.ShowIdentifier),
             _BuildStepFactory(steps.ApplyPatch),
             _BuildStepFactory(steps.DownloadBuiltProduct),
             _BuildStepFactory(steps.ExtractBuiltProduct),

Modified: trunk/Tools/CISupport/ews-build/steps.py (271674 => 271675)


--- trunk/Tools/CISupport/ews-build/steps.py	2021-01-20 22:38:10 UTC (rev 271674)
+++ trunk/Tools/CISupport/ews-build/steps.py	2021-01-20 23:06:00 UTC (rev 271675)
@@ -39,6 +39,7 @@
 import socket
 
 BUG_SERVER_URL = 'https://bugs.webkit.org/'
+COMMITS_INFO_URL = 'https://commits.webkit.org/'
 S3URL = 'https://s3-us-west-2.amazonaws.com/'
 S3_RESULTS_URL = 'https://ews-build.s3-us-west-2.amazonaws.com/'
 CURRENT_HOSTNAME = socket.gethostname().strip()
@@ -163,6 +164,64 @@
         return shell.ShellCommand.start(self)
 
 
+class ShowIdentifier(shell.ShellCommand):
+    name = 'show-identifier'
+    identifier_re = '^Identifier: (.*)$'
+    flunkOnFailure = False
+    haltOnFailure = False
+
+    def __init__(self, **kwargs):
+        shell.ShellCommand.__init__(self, timeout=5 * 60, logEnviron=False, **kwargs)
+
+    def start(self):
+        self.log_observer = logobserver.BufferLogObserver()
+        self.addLogObserver('stdio', self.log_observer)
+        revision = self.getProperty('ews_revision', self.getProperty('got_revision'))
+        if not revision:
+            revision = 'HEAD'
+        self.setCommand(['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', revision])
+        return shell.ShellCommand.start(self)
+
+    def evaluateCommand(self, cmd):
+        rc = shell.ShellCommand.evaluateCommand(self, cmd)
+        if rc != SUCCESS:
+            return rc
+
+        log_text = self.log_observer.getStdout()
+        match = re.search(self.identifier_re, log_text, re.MULTILINE)
+        if match:
+            identifier = match.group(1)
+            self.setProperty('identifier', identifier)
+            ews_revision = self.getProperty('ews_revision')
+            if ews_revision:
+                step = self.getLastBuildStepByName(CheckOutSpecificRevision.name)
+            else:
+                step = self.getLastBuildStepByName(CheckOutSource.name)
+            if not step:
+                step = self
+            step.addURL('Updated to {}'.format(identifier), self.url_for_identifier(identifier))
+            self.descriptionDone = 'Identifier: {}'.format(identifier)
+        else:
+            self.descriptionDone = 'Failed to find identifier'
+        return rc
+
+    def getLastBuildStepByName(self, name):
+        for step in reversed(self.build.executedSteps):
+            if name in step.name:
+                return step
+        return None
+
+    def url_for_identifier(self, identifier):
+        return '{}{}'.format(COMMITS_INFO_URL, identifier)
+
+    def getResultSummary(self):
+        if self.results != SUCCESS:
+            return {u'step': u'Failed to find identifier'}
+        return shell.ShellCommand.getResultSummary(self)
+
+    def hideStepIf(self, results, step):
+        return results == SUCCESS
+
 class CleanWorkingDirectory(shell.ShellCommand):
     name = 'clean-working-directory'
     description = ['clean-working-directory running']

Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (271674 => 271675)


--- trunk/Tools/CISupport/ews-build/steps_unittest.py	2021-01-20 22:38:10 UTC (rev 271674)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py	2021-01-20 23:06:00 UTC (rev 271675)
@@ -49,7 +49,7 @@
                    ReRunWebKitTests, RunAPITests, RunAPITestsWithoutPatch, RunBindingsTests, RunBuildWebKitOrgUnitTests,
                    RunEWSBuildbotCheckConfig, RunEWSUnitTests, RunResultsdbpyTests, RunJavaScriptCoreTests,
                    RunJSCTestsWithoutPatch, RunWebKit1Tests, RunWebKitPerlTests, RunWebKitPyPython2Tests,
-                   RunWebKitPyPython3Tests, RunWebKitTests, RunWebKitTestsWithoutPatch, TestWithFailureCount,
+                   RunWebKitPyPython3Tests, RunWebKitTests, RunWebKitTestsWithoutPatch, TestWithFailureCount, ShowIdentifier,
                    Trigger, TransferToS3, UnApplyPatchIfRequired, UpdateWorkingDirectory, UploadBuiltProduct,
                    UploadTestResults, ValidateCommiterAndReviewer, ValidatePatch)
 
@@ -3767,5 +3767,43 @@
         return self.runStep()
 
 
+class TestShowIdentifier(BuildStepMixinAdditions, unittest.TestCase):
+    def setUp(self):
+        self.longMessage = True
+        return self.setUpBuildStep()
+
+    def tearDown(self):
+        return self.tearDownBuildStep()
+
+    def test_success(self):
+        self.setupStep(ShowIdentifier())
+        self.setProperty('ews_revision', '51a6aec9f664')
+        self.expectRemoteCommands(
+            ExpectShell(workdir='wkdir',
+                        timeout=300,
+                        logEnviron=False,
+                        command=['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', '51a6aec9f664']) +
+            ExpectShell.log('stdio', stdout='Identifier: 233175@main') +
+            0,
+        )
+        self.expectOutcome(result=SUCCESS, state_string='Identifier: 233175@main')
+        rc = self.runStep()
+        self.assertEqual(self.getProperty('identifier'), '233175@main')
+        return rc
+
+    def test_failure(self):
+        self.setupStep(ShowIdentifier())
+        self.expectRemoteCommands(
+            ExpectShell(workdir='wkdir',
+                        timeout=300,
+                        logEnviron=False,
+                        command=['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', 'HEAD']) +
+            ExpectShell.log('stdio', stdout='Unexpected failure') +
+            2,
+        )
+        self.expectOutcome(result=FAILURE, state_string='Failed to find identifier')
+        return self.runStep()
+
+
 if __name__ == '__main__':
     unittest.main()

Modified: trunk/Tools/ChangeLog (271674 => 271675)


--- trunk/Tools/ChangeLog	2021-01-20 22:38:10 UTC (rev 271674)
+++ trunk/Tools/ChangeLog	2021-01-20 23:06:00 UTC (rev 271675)
@@ -1,3 +1,26 @@
+2021-01-20  Aakash Jain  <aakash_j...@apple.com>
+
+        EWS should display commit identifier in builds
+        https://bugs.webkit.org/show_bug.cgi?id=220769
+
+        Reviewed by Jonathan Bedard.
+
+        * CISupport/ews-build/factories.py:
+        (Factory.__init__): Added ShowIdentifier build step.
+        (StyleFactory.__init__):
+        (WatchListFactory.__init__):
+        (CommitQueueFactory.__init__):
+        * CISupport/ews-build/steps.py:
+        (ShowIdentifier): build-step to show commit identifier.
+        (ShowIdentifier.start):
+        (ShowIdentifier.evaluateCommand):
+        (ShowIdentifier.getLastBuildStepByName):
+        (ShowIdentifier.url_for_identifier):
+        (ShowIdentifier.getResultSummary): Display custom failure message.
+        (ShowIdentifier.hideStepIf): Hide this step if successful.
+        * CISupport/ews-build/steps_unittest.py: Added unit-tests.
+        * CISupport/ews-build/factories_unittest.py:
+
 2021-01-20  Youenn Fablet  <you...@apple.com>
 
         Two pages in the same process should not be able to play media stream backed video elements at the same time

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to