Title: [280425] trunk/Source/WebKit
- Revision
- 280425
- Author
- katherine_che...@apple.com
- Date
- 2021-07-29 09:47:31 -0700 (Thu, 29 Jul 2021)
Log Message
CORS preflight checks not attributed to the correct application
https://bugs.webkit.org/show_bug.cgi?id=228585
<rdar://problem/81220151>
Reviewed by Alex Christensen.
We use _attributedBundleIdentifier to attribute loads to the correct
application. This parameter is set on each NSURLSession in the per-page
session sets. This patch sets the webPageProxyID for CORS preflight check
in the load parameters so the network data task knows to use the per-page
session set, so the loads get attributed to the right application.
* NetworkProcess/NetworkCORSPreflightChecker.cpp:
(WebKit::NetworkCORSPreflightChecker::startPreflight):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (280424 => 280425)
--- trunk/Source/WebKit/ChangeLog 2021-07-29 16:27:43 UTC (rev 280424)
+++ trunk/Source/WebKit/ChangeLog 2021-07-29 16:47:31 UTC (rev 280425)
@@ -1,3 +1,20 @@
+2021-07-29 Kate Cheney <katherine_che...@apple.com>
+
+ CORS preflight checks not attributed to the correct application
+ https://bugs.webkit.org/show_bug.cgi?id=228585
+ <rdar://problem/81220151>
+
+ Reviewed by Alex Christensen.
+
+ We use _attributedBundleIdentifier to attribute loads to the correct
+ application. This parameter is set on each NSURLSession in the per-page
+ session sets. This patch sets the webPageProxyID for CORS preflight check
+ in the load parameters so the network data task knows to use the per-page
+ session set, so the loads get attributed to the right application.
+
+ * NetworkProcess/NetworkCORSPreflightChecker.cpp:
+ (WebKit::NetworkCORSPreflightChecker::startPreflight):
+
2021-07-29 Peng Liu <peng.l...@apple.com>
[macOS Catalina] Some feature preferences have wrong default values
Modified: trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp (280424 => 280425)
--- trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp 2021-07-29 16:27:43 UTC (rev 280424)
+++ trunk/Source/WebKit/NetworkProcess/NetworkCORSPreflightChecker.cpp 2021-07-29 16:47:31 UTC (rev 280425)
@@ -73,6 +73,8 @@
if (m_shouldCaptureExtraNetworkLoadMetrics)
m_loadInformation = NetworkTransactionInformation { NetworkTransactionInformation::Type::Preflight, loadParameters.request, { }, { } };
+ loadParameters.webPageProxyID = m_parameters.webPageProxyID;
+
if (auto* networkSession = m_networkProcess->networkSession(m_parameters.sessionID)) {
m_task = NetworkDataTask::create(*networkSession, *this, WTFMove(loadParameters));
m_task->resume();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
