Title: [280706] trunk
Revision
280706
Author
katherine_che...@apple.com
Date
2021-08-05 16:47:09 -0700 (Thu, 05 Aug 2021)

Log Message

LoadWebArchive.FailNavigation1 test is a false positive
https://bugs.webkit.org/show_bug.cgi?id=228848
<rdar://problem/81587448>

Reviewed by Brent Fulgham.

Source/WebKit:

Drive by logging fix.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):

Tools:

Update LoadWebArchive.FailNavigation1 to test the case of a webarchive
being loaded with a host for better test coverage.

* TestWebKitAPI/Tests/mac/load-web-archive-1.html:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (280705 => 280706)


--- trunk/Source/WebKit/ChangeLog	2021-08-05 22:47:59 UTC (rev 280705)
+++ trunk/Source/WebKit/ChangeLog	2021-08-05 23:47:09 UTC (rev 280706)
@@ -1,3 +1,17 @@
+2021-08-05  Kate Cheney  <katherine_che...@apple.com>
+
+        LoadWebArchive.FailNavigation1 test is a false positive
+        https://bugs.webkit.org/show_bug.cgi?id=228848
+        <rdar://problem/81587448>
+
+        Reviewed by Brent Fulgham.
+
+        Drive by logging fix.
+
+        * UIProcess/WebProcessProxy.cpp:
+        (WebKit::WebProcessProxy::fetchWebsiteData):
+        (WebKit::WebProcessProxy::deleteWebsiteData):
+
 2021-08-05  Eric Carlson  <eric.carl...@apple.com>
 
         [iOS] getUserMedia sometimes doesn't capture from specified microphone

Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp (280705 => 280706)


--- trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp	2021-08-05 22:47:59 UTC (rev 280705)
+++ trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp	2021-08-05 23:47:09 UTC (rev 280706)
@@ -1245,7 +1245,7 @@
         UNUSED_PARAM(this);
 #endif
         completionHandler(WTFMove(reply));
-        WEBPROCESSPROXY_RELEASE_LOG(ProcessSuspension, "fetchWebsiteData: Teleasing a background assertion because the Web process is done fetching Website data");
+        WEBPROCESSPROXY_RELEASE_LOG(ProcessSuspension, "fetchWebsiteData: Releasing a background assertion because the Web process is done fetching Website data");
     });
 }
 
@@ -1261,7 +1261,7 @@
         UNUSED_PARAM(this);
 #endif
         completionHandler();
-        WEBPROCESSPROXY_RELEASE_LOG(ProcessSuspension, "deleteWebsiteData: Teleasing a background assertion because the Web process is done deleting Website data");
+        WEBPROCESSPROXY_RELEASE_LOG(ProcessSuspension, "deleteWebsiteData: Releasing a background assertion because the Web process is done deleting Website data");
     });
 }
 

Modified: trunk/Tools/ChangeLog (280705 => 280706)


--- trunk/Tools/ChangeLog	2021-08-05 22:47:59 UTC (rev 280705)
+++ trunk/Tools/ChangeLog	2021-08-05 23:47:09 UTC (rev 280706)
@@ -1,3 +1,16 @@
+2021-08-05  Kate Cheney  <katherine_che...@apple.com>
+
+        LoadWebArchive.FailNavigation1 test is a false positive
+        https://bugs.webkit.org/show_bug.cgi?id=228848
+        <rdar://problem/81587448>
+
+        Reviewed by Brent Fulgham.
+
+        Update LoadWebArchive.FailNavigation1 to test the case of a webarchive
+        being loaded with a host for better test coverage.
+
+        * TestWebKitAPI/Tests/mac/load-web-archive-1.html:
+
 2021-08-05  Zan Dobersek  <zdober...@igalia.com>
 
         run-jsc-stress-tests: detect the riscv64 architecture

Modified: trunk/Tools/TestWebKitAPI/Tests/mac/load-web-archive-1.html (280705 => 280706)


--- trunk/Tools/TestWebKitAPI/Tests/mac/load-web-archive-1.html	2021-08-05 22:47:59 UTC (rev 280705)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/load-web-archive-1.html	2021-08-05 23:47:09 UTC (rev 280706)
@@ -1,6 +1,11 @@
 <!DOCTYPE html>
 <html>
 <script>
-    document.location.href = '';
+    var url = "" URL(location.href);
+    var path = url.pathname.replace('load-web-archive-1.html', 'helloworld.webarchive');
+    url.pathname = path;
+    url.host = 'test';
+
+    document.location.href = ""
 </script>
 </html>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to