Title: [285128] trunk/Tools
- Revision
- 285128
- Author
- hironori.fu...@sony.com
- Date
- 2021-11-01 13:33:37 -0700 (Mon, 01 Nov 2021)
Log Message
TestWTF.WTF_CompactUniquePtrTuple.Subclassing is randomly failing on WinCairo tester bots
https://bugs.webkit.org/show_bug.cgi?id=232556
Reviewed by Yusuke Suzuki.
"EXPECT_NE(oldPointer, a.pointer())" of line 241 was randomly
failing on WinCairo tester bots. This seems a simple mistake of
the test case. 'oldPointer' should be updated before destructing
the old value.
* TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp:
(WTF_CompactUniquePtrTuple::Subclassing):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (285127 => 285128)
--- trunk/Tools/ChangeLog 2021-11-01 20:32:51 UTC (rev 285127)
+++ trunk/Tools/ChangeLog 2021-11-01 20:33:37 UTC (rev 285128)
@@ -1,3 +1,18 @@
+2021-11-01 Fujii Hironori <hironori.fu...@sony.com>
+
+ TestWTF.WTF_CompactUniquePtrTuple.Subclassing is randomly failing on WinCairo tester bots
+ https://bugs.webkit.org/show_bug.cgi?id=232556
+
+ Reviewed by Yusuke Suzuki.
+
+ "EXPECT_NE(oldPointer, a.pointer())" of line 241 was randomly
+ failing on WinCairo tester bots. This seems a simple mistake of
+ the test case. 'oldPointer' should be updated before destructing
+ the old value.
+
+ * TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp:
+ (WTF_CompactUniquePtrTuple::Subclassing):
+
2021-11-01 Brady Eidson <beid...@apple.com>
webpushd: Add mock in-memory registration, and the WKWebsiteDataStore SPI to manage them
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp (285127 => 285128)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp 2021-11-01 20:32:51 UTC (rev 285127)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/CompactUniquePtrTuple.cpp 2021-11-01 20:33:37 UTC (rev 285128)
@@ -233,6 +233,7 @@
EXPECT_NE(oldPointer, a.pointer());
EXPECT_EQ(0x1cU, a.type());
+ oldPointer = a.pointer();
a = makeCompactUniquePtr<A, uint16_t>();
EXPECT_EQ(4U, A::s_constructorCallCount);
EXPECT_EQ(3U, A::s_destructorCallCount);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
