Title: [286262] trunk/Source/WebCore
Revision
286262
Author
hironori.fu...@sony.com
Date
2021-11-29 14:04:59 -0800 (Mon, 29 Nov 2021)

Log Message

REGRESSION(r286205) [WinCairo] WebGL tests are failing
https://bugs.webkit.org/show_bug.cgi?id=233589

Unreviewed crash fix.

EGL_BIND_TO_TEXTURE_TARGET_ANGLE isn't available for Windows.
Restored the previous code.

* platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLOpenGL::drawingBufferTextureTarget):
Set m_drawingBufferTextureTarget to EGL_TEXTURE_2D for
PLATFORM(WIN) instead of querying with EGL_BIND_TO_TEXTURE_TARGET_ANGLE.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (286261 => 286262)


--- trunk/Source/WebCore/ChangeLog	2021-11-29 21:34:35 UTC (rev 286261)
+++ trunk/Source/WebCore/ChangeLog	2021-11-29 22:04:59 UTC (rev 286262)
@@ -1,3 +1,18 @@
+2021-11-29  Fujii Hironori  <hironori.fu...@sony.com>
+
+        REGRESSION(r286205) [WinCairo] WebGL tests are failing
+        https://bugs.webkit.org/show_bug.cgi?id=233589
+
+        Unreviewed crash fix.
+
+        EGL_BIND_TO_TEXTURE_TARGET_ANGLE isn't available for Windows.
+        Restored the previous code.
+
+        * platform/graphics/angle/GraphicsContextGLANGLE.cpp:
+        (WebCore::GraphicsContextGLOpenGL::drawingBufferTextureTarget):
+        Set m_drawingBufferTextureTarget to EGL_TEXTURE_2D for
+        PLATFORM(WIN) instead of querying with EGL_BIND_TO_TEXTURE_TARGET_ANGLE.
+
 2021-11-29  Chris Fleizach  <cfleiz...@apple.com>
 
         AX: Unify speech synthesizer platform usage for Mac/iOS

Modified: trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp (286261 => 286262)


--- trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp	2021-11-29 21:34:35 UTC (rev 286261)
+++ trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp	2021-11-29 22:04:59 UTC (rev 286262)
@@ -79,8 +79,12 @@
 
 GCGLenum GraphicsContextGLOpenGL::drawingBufferTextureTarget()
 {
+#if PLATFORM(WIN)
+    m_drawingBufferTextureTarget = EGL_TEXTURE_2D;
+#else
     if (m_drawingBufferTextureTarget == -1)
         EGL_GetConfigAttrib(platformDisplay(), platformConfig(), EGL_BIND_TO_TEXTURE_TARGET_ANGLE, &m_drawingBufferTextureTarget);
+#endif
 
     switch (m_drawingBufferTextureTarget) {
     case EGL_TEXTURE_2D:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to