Diff
Modified: trunk/JSTests/ChangeLog (290078 => 290079)
--- trunk/JSTests/ChangeLog 2022-02-17 22:54:03 UTC (rev 290078)
+++ trunk/JSTests/ChangeLog 2022-02-17 22:58:31 UTC (rev 290079)
@@ -1,3 +1,25 @@
+2022-02-17 Mikhail R. Gadelha <mikh...@igalia.com>
+
+ [32bit] Increase fixedExecutableMemoryPoolSize on ARM to 32MB
+ https://bugs.webkit.org/show_bug.cgi?id=236606
+
+ Reviewed by Mark Lam.
+
+ Increased executable memory on ARM to 32MB and make it consistent with
+ other 32 bit platforms (MIPS and x86). This patch also enables some
+ tests that now pass because of the increased memory; each test was
+ executed 1000 times and there was no failure.
+
+ let-const-tdz-environment-parsing-and-hash-consing-speed.js was disabled
+ on MIPS because the jitted code is still a bit too bigger for the 32MB,
+ but it can probably be enable when the EXTRA_CTI_THUNKS patch lands.
+
+ * microbenchmarks/let-const-tdz-environment-parsing-and-hash-consing-speed.js:
+ * stress/arrowfunction-lexical-bind-superproperty.js:
+ * stress/proxy-revoke.js:
+ * stress/regress-169445.js:
+ * stress/tagged-template-object-collect.js:
+
2022-02-17 Angelos Oikonomopoulos <ange...@igalia.com>
[JSC] Unskip test on mips
Modified: trunk/JSTests/microbenchmarks/let-const-tdz-environment-parsing-and-hash-consing-speed.js (290078 => 290079)
--- trunk/JSTests/microbenchmarks/let-const-tdz-environment-parsing-and-hash-consing-speed.js 2022-02-17 22:54:03 UTC (rev 290078)
+++ trunk/JSTests/microbenchmarks/let-const-tdz-environment-parsing-and-hash-consing-speed.js 2022-02-17 22:58:31 UTC (rev 290079)
@@ -1,4 +1,4 @@
-//@ skip if $architecture != "arm64" and $architecture != "x86-64"
+//@ defaultNoNoLLIntRun if $architecture == "mips"
/*
* Copyright jQuery Foundation and other contributors, https://jquery.org/
*
Modified: trunk/JSTests/stress/arrowfunction-lexical-bind-superproperty.js (290078 => 290079)
--- trunk/JSTests/stress/arrowfunction-lexical-bind-superproperty.js 2022-02-17 22:54:03 UTC (rev 290078)
+++ trunk/JSTests/stress/arrowfunction-lexical-bind-superproperty.js 2022-02-17 22:58:31 UTC (rev 290079)
@@ -1,5 +1,3 @@
-//@ defaultNoNoLLIntRun if $architecture == "arm"
-
var testCase = function (actual, expected, message) {
if (actual !== expected) {
throw message + ". Expected '" + expected + "', but was '" + actual + "'";
Modified: trunk/JSTests/stress/proxy-revoke.js (290078 => 290079)
--- trunk/JSTests/stress/proxy-revoke.js 2022-02-17 22:54:03 UTC (rev 290078)
+++ trunk/JSTests/stress/proxy-revoke.js 2022-02-17 22:58:31 UTC (rev 290079)
@@ -1,4 +1,4 @@
-//@ defaultNoNoLLIntRun if $architecture == "arm64" or $architecture == "arm"
+//@ defaultNoNoLLIntRun if $architecture == "arm64"
function assert(b) {
if (!b)
Modified: trunk/JSTests/stress/regress-169445.js (290078 => 290079)
--- trunk/JSTests/stress/regress-169445.js 2022-02-17 22:54:03 UTC (rev 290078)
+++ trunk/JSTests/stress/regress-169445.js 2022-02-17 22:58:31 UTC (rev 290079)
@@ -1,5 +1,3 @@
-//@ defaultNoNoLLIntRun if $architecture == "arm"
-
let args = new Array(0x10000);
args.fill();
args = args.map((_, i) => 'a' + i).join(', ');
Modified: trunk/JSTests/stress/tagged-template-object-collect.js (290078 => 290079)
--- trunk/JSTests/stress/tagged-template-object-collect.js 2022-02-17 22:54:03 UTC (rev 290078)
+++ trunk/JSTests/stress/tagged-template-object-collect.js 2022-02-17 22:58:31 UTC (rev 290079)
@@ -1,5 +1,3 @@
-//@ defaultNoNoLLIntRun if $architecture == "arm"
-
function shouldBe(actual, expected) {
if (actual !== expected)
throw new Error('bad value: ' + actual);
Modified: trunk/Source/_javascript_Core/ChangeLog (290078 => 290079)
--- trunk/Source/_javascript_Core/ChangeLog 2022-02-17 22:54:03 UTC (rev 290078)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-02-17 22:58:31 UTC (rev 290079)
@@ -1,3 +1,25 @@
+2022-02-17 Mikhail R. Gadelha <mikh...@igalia.com>
+
+ [32bit] Increase fixedExecutableMemoryPoolSize on ARM to 32MB
+ https://bugs.webkit.org/show_bug.cgi?id=236606
+
+ Reviewed by Mark Lam.
+
+ Increased executable memory on ARM to 32MB and make it consistent with
+ other 32 bit platforms (MIPS and x86). This patch also enables some
+ tests that now pass because of the increased memory; each test was
+ executed 1000 times and there was no failure.
+
+ let-const-tdz-environment-parsing-and-hash-consing-speed.js was disabled
+ on MIPS because the jitted code is still a bit too bigger for the 32MB,
+ but it can probably be enable when the EXTRA_CTI_THUNKS patch lands.
+
+ * microbenchmarks/let-const-tdz-environment-parsing-and-hash-consing-speed.js:
+ * stress/arrowfunction-lexical-bind-superproperty.js:
+ * stress/proxy-revoke.js:
+ * stress/regress-169445.js:
+ * stress/tagged-template-object-collect.js:
+
2022-02-17 Chris Dumez <cdu...@apple.com>
Clean up / optimize call sites constructing vectors
Modified: trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp (290078 => 290079)
--- trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2022-02-17 22:54:03 UTC (rev 290078)
+++ trunk/Source/_javascript_Core/jit/ExecutableAllocator.cpp 2022-02-17 22:58:31 UTC (rev 290079)
@@ -91,8 +91,6 @@
#if defined(FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB) && FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB > 0
static constexpr size_t fixedExecutableMemoryPoolSize = FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB * MB;
-#elif CPU(ARM)
-static constexpr size_t fixedExecutableMemoryPoolSize = 16 * MB;
#elif CPU(ARM64)
#if ENABLE(JUMP_ISLANDS)
static constexpr size_t fixedExecutableMemoryPoolSize = 512 * MB;
