Title: [290247] trunk
- Revision
- 290247
- Author
- n...@webkit.org
- Date
- 2022-02-21 09:50:40 -0800 (Mon, 21 Feb 2022)
Log Message
PerformanceObserver: buffered flag not working in Paint Timing
https://bugs.webkit.org/show_bug.cgi?id=225305
<rdar://problem/77746237>
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
* web-platform-tests/paint-timing/fcp-only/buffered-flag.window-expected.txt: This test now passes
Source/WebCore:
Include paint entries when collecting buffered performance entries.
A previously failing W3C test is now marked as passing.
* page/Performance.cpp:
(WebCore::Performance::appendBufferedEntriesByType const): Add the existing FCP entry
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (290246 => 290247)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-21 17:07:45 UTC (rev 290246)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-21 17:50:40 UTC (rev 290247)
@@ -1,3 +1,13 @@
+2022-02-21 Noam Rosenthal <n...@webkit.org>
+
+ PerformanceObserver: buffered flag not working in Paint Timing
+ https://bugs.webkit.org/show_bug.cgi?id=225305
+ <rdar://problem/77746237>
+
+ Reviewed by Simon Fraser.
+
+ * web-platform-tests/paint-timing/fcp-only/buffered-flag.window-expected.txt: This test now passes
+
2022-02-20 Tim Nguyen <n...@apple.com>
Rebaseline inert-focus-in-frames.html after r290197.
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/buffered-flag.window-expected.txt (290246 => 290247)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/buffered-flag.window-expected.txt 2022-02-21 17:07:45 UTC (rev 290246)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/buffered-flag.window-expected.txt 2022-02-21 17:50:40 UTC (rev 290247)
@@ -1,5 +1,3 @@
-Harness Error (TIMEOUT), message = null
+PASS PerformanceObserver with buffered flag sees previous FCP entry.
-TIMEOUT PerformanceObserver with buffered flag sees previous FCP entry. Test timed out
-
Modified: trunk/Source/WebCore/ChangeLog (290246 => 290247)
--- trunk/Source/WebCore/ChangeLog 2022-02-21 17:07:45 UTC (rev 290246)
+++ trunk/Source/WebCore/ChangeLog 2022-02-21 17:50:40 UTC (rev 290247)
@@ -1,3 +1,18 @@
+2022-02-21 Noam Rosenthal <n...@webkit.org>
+
+ PerformanceObserver: buffered flag not working in Paint Timing
+ https://bugs.webkit.org/show_bug.cgi?id=225305
+ <rdar://problem/77746237>
+
+ Reviewed by Simon Fraser.
+
+ Include paint entries when collecting buffered performance entries.
+
+ A previously failing W3C test is now marked as passing.
+
+ * page/Performance.cpp:
+ (WebCore::Performance::appendBufferedEntriesByType const): Add the existing FCP entry
+
2022-02-21 Alan Bujtas <za...@apple.com>
[IFC][Integration] Take vertical-rl writing mode value into account when converting visual margin/border/padding value to logical
Modified: trunk/Source/WebCore/page/Performance.cpp (290246 => 290247)
--- trunk/Source/WebCore/page/Performance.cpp 2022-02-21 17:07:45 UTC (rev 290246)
+++ trunk/Source/WebCore/page/Performance.cpp 2022-02-21 17:50:40 UTC (rev 290247)
@@ -218,6 +218,9 @@
if (entryType == "resource")
entries.appendVector(m_resourceTimingBuffer);
+ if (entryType == "paint" && m_firstContentfulPaint)
+ entries.append(m_firstContentfulPaint);
+
if (m_userTiming) {
if (entryType.isNull() || entryType == "mark")
entries.appendVector(m_userTiming->getMarks());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
