Title: [290280] trunk
- Revision
- 290280
- Author
- jon...@apple.com
- Date
- 2022-02-21 17:48:11 -0800 (Mon, 21 Feb 2022)
Log Message
Add test name to the image diff template
https://bugs.webkit.org/show_bug.cgi?id=237003
Reviewed by Sam Weinig.
Tools:
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.write_image_diff_files):
LayoutTests:
Include the test name in the page. Workflow to update fuzzy match data becomes easier to copy-paste the name there instead of from the location bar.
* fast/harness/image-diff-template-expected.txt:
* fast/harness/image-diff-template.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (290279 => 290280)
--- trunk/LayoutTests/ChangeLog 2022-02-22 01:42:45 UTC (rev 290279)
+++ trunk/LayoutTests/ChangeLog 2022-02-22 01:48:11 UTC (rev 290280)
@@ -1 +1,12 @@
+2022-02-21 Jon Lee <jon...@apple.com>
+
+ Add test name to the image diff template
+ https://bugs.webkit.org/show_bug.cgi?id=237003
+
+ Reviewed by Sam Weinig.
+
+ Include the test name in the page. Workflow to update fuzzy match data becomes easier to copy-paste the name there instead of from the location bar.
+ * fast/harness/image-diff-template-expected.txt:
+ * fast/harness/image-diff-template.html:
+
== Rolled over to ChangeLog-2022-02-22 ==
Modified: trunk/LayoutTests/fast/harness/image-diff-template-expected.txt (290279 => 290280)
--- trunk/LayoutTests/fast/harness/image-diff-template-expected.txt 2022-02-22 01:42:45 UTC (rev 290279)
+++ trunk/LayoutTests/fast/harness/image-diff-template-expected.txt 2022-02-22 01:48:11 UTC (rev 290280)
@@ -1,4 +1,5 @@
CONSOLE MESSAGE: ReferenceError: Can't find variable: __FUZZY_DATA__
+Test path: __TEST_NAME__
Pixel difference: __PIXEL_DIFF__
Fuzzy match: Click to toggle between ranges and values
Modified: trunk/LayoutTests/fast/harness/image-diff-template.html (290279 => 290280)
--- trunk/LayoutTests/fast/harness/image-diff-template.html 2022-02-22 01:42:45 UTC (rev 290279)
+++ trunk/LayoutTests/fast/harness/image-diff-template.html 2022-02-22 01:48:11 UTC (rev 290280)
@@ -59,6 +59,10 @@
</head>
<body>
<table class="controls">
+ <tr class="pixel-diff">
+ <td>Test path:</td>
+ <td>__TEST_NAME__</td>
+ </tr>
<tr class="pixel-diff __HIDE_DIFF_CLASS__">
<td>Pixel difference:</td>
<td>__PIXEL_DIFF__</td>
Modified: trunk/Tools/ChangeLog (290279 => 290280)
--- trunk/Tools/ChangeLog 2022-02-22 01:42:45 UTC (rev 290279)
+++ trunk/Tools/ChangeLog 2022-02-22 01:48:11 UTC (rev 290280)
@@ -1 +1,11 @@
+2022-02-21 Jon Lee <jon...@apple.com>
+
+ Add test name to the image diff template
+ https://bugs.webkit.org/show_bug.cgi?id=237003
+
+ Reviewed by Sam Weinig.
+
+ * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
+ (TestResultWriter.write_image_diff_files):
+
== Rolled over to ChangeLog-2022-02-22 ==
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py (290279 => 290280)
--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py 2022-02-22 01:42:45 UTC (rev 290279)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py 2022-02-22 01:48:11 UTC (rev 290280)
@@ -196,6 +196,7 @@
image_diff_file = self._filesystem.read_text_file(image_diff_template)
html = image_diff_file.replace('__TITLE__', self._test_name)
+ html = html.replace('__TEST_NAME__', self._test_name)
html = html.replace('__PREFIX__', self._output_testname(''))
if not diff_percent_text:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
