- Revision
- 290594
- Author
- commit-qu...@webkit.org
- Date
- 2022-02-28 06:01:27 -0800 (Mon, 28 Feb 2022)
Log Message
REGRESSION(r290588) Missing symbol jsValueForDecodedMessage<107> (IPCStreamTesterProxy_WasCreated)
https://bugs.webkit.org/show_bug.cgi?id=237268
Patch by Kimmo Kinnunen <kkinnu...@apple.com> on 2022-02-28
Reviewed by Antti Koivisto.
Add the class IPCStreamTesterProxy now that *MessageReceiver.cpp
are needed. After commit
"IPC_TESTING_API MessageArgumentDescriptions.cpp is slow to compile"
MessageReceiver.cpp files contain also message-specific functions that
need to be compiled, even though IPCStreamTesterProxy itself is not
used.
* Shared/IPCStreamTesterProxy.h: Added.
* Sources.txt:
* WebKit.xcodeproj/project.pbxproj:
Modified Paths
Added Paths
Diff
Modified: trunk/Source/WebKit/CMakeLists.txt (290593 => 290594)
--- trunk/Source/WebKit/CMakeLists.txt 2022-02-28 10:47:06 UTC (rev 290593)
+++ trunk/Source/WebKit/CMakeLists.txt 2022-02-28 14:01:27 UTC (rev 290594)
@@ -220,6 +220,7 @@
Shared/AuxiliaryProcess
Shared/IPCStreamTester
+ Shared/IPCStreamTesterProxy
Shared/IPCTester
Shared/WebConnection
Modified: trunk/Source/WebKit/ChangeLog (290593 => 290594)
--- trunk/Source/WebKit/ChangeLog 2022-02-28 10:47:06 UTC (rev 290593)
+++ trunk/Source/WebKit/ChangeLog 2022-02-28 14:01:27 UTC (rev 290594)
@@ -1,3 +1,21 @@
+2022-02-28 Kimmo Kinnunen <kkinnu...@apple.com>
+
+ REGRESSION(r290588) Missing symbol jsValueForDecodedMessage<107> (IPCStreamTesterProxy_WasCreated)
+ https://bugs.webkit.org/show_bug.cgi?id=237268
+
+ Reviewed by Antti Koivisto.
+
+ Add the class IPCStreamTesterProxy now that *MessageReceiver.cpp
+ are needed. After commit
+ "IPC_TESTING_API MessageArgumentDescriptions.cpp is slow to compile"
+ MessageReceiver.cpp files contain also message-specific functions that
+ need to be compiled, even though IPCStreamTesterProxy itself is not
+ used.
+
+ * Shared/IPCStreamTesterProxy.h: Added.
+ * Sources.txt:
+ * WebKit.xcodeproj/project.pbxproj:
+
2022-02-28 Youenn Fablet <you...@apple.com>
RemoteVideoFrameObjectHeap should process its IPC messages in a background thread
Added: trunk/Source/WebKit/Shared/IPCStreamTesterProxy.h (0 => 290594)
--- trunk/Source/WebKit/Shared/IPCStreamTesterProxy.h (rev 0)
+++ trunk/Source/WebKit/Shared/IPCStreamTesterProxy.h 2022-02-28 14:01:27 UTC (rev 290594)
@@ -0,0 +1,57 @@
+/*
+ * Copyright (C) 2022 Apple Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#pragma once
+
+#if ENABLE(IPC_TESTING_API)
+
+#include "MessageReceiver.h"
+
+namespace IPC {
+class Connection;
+class IPCSemaphore;
+}
+
+namespace WebKit {
+
+// Proxy interface to test various IPC stream related activities.
+// Currently this is not instantiated. This only exists due to the IPCStreamTesterProxy
+// messages that are caught in the JS IPC_TESTING_API tests. The messages need to
+// compile the IPCStreamTesterProxyMessageReceiver.cpp, so this class definition is needed.
+class IPCStreamTesterProxy final : public IPC::MessageReceiver {
+public:
+ // IPC::MessageReceiver overrides.
+ void didReceiveMessage(IPC::Connection&, IPC::Decoder&);
+private:
+ IPCStreamTesterProxy() = default;
+ ~IPCStreamTesterProxy() = default;
+
+ // Messages.
+ void wasCreated(IPC::Semaphore&&) { }
+};
+
+}
+
+#endif
Modified: trunk/Source/WebKit/Sources.txt (290593 => 290594)
--- trunk/Source/WebKit/Sources.txt 2022-02-28 10:47:06 UTC (rev 290593)
+++ trunk/Source/WebKit/Sources.txt 2022-02-28 14:01:27 UTC (rev 290594)
@@ -870,6 +870,7 @@
WebProcess/XR/PlatformXRSystemProxy.cpp
IPCStreamTesterMessageReceiver.cpp
+IPCStreamTesterProxyMessageReceiver.cpp
IPCTesterMessageReceiver.cpp
NetworkBroadcastChannelRegistryMessageReceiver.cpp
RTCDataChannelRemoteManagerMessageReceiver.cpp
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (290593 => 290594)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2022-02-28 10:47:06 UTC (rev 290593)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2022-02-28 14:01:27 UTC (rev 290594)
@@ -5139,6 +5139,7 @@
7AFBD36E21E546E3005DBACB /* PersistencyUtils.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = PersistencyUtils.cpp; sourceTree = "<group>"; };
7B16191227198AA900C40EAC /* RemoteGraphicsContextGLProxyCocoa.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = RemoteGraphicsContextGLProxyCocoa.mm; sourceTree = "<group>"; };
7B1DB26525668CE0000E26BC /* ArrayReference.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ArrayReference.h; sourceTree = "<group>"; };
+ 7B2DDD5E27CCD9710060ABAB /* IPCStreamTesterProxy.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = IPCStreamTesterProxy.h; sourceTree = "<group>"; };
7B483F1B25CDDA9B00120486 /* MessageReceiveQueueMap.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MessageReceiveQueueMap.h; sourceTree = "<group>"; };
7B483F1C25CDDA9B00120486 /* MessageReceiveQueue.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MessageReceiveQueue.h; sourceTree = "<group>"; };
7B483F1D25CDDA9B00120486 /* MessageReceiveQueueMap.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MessageReceiveQueueMap.cpp; sourceTree = "<group>"; };
@@ -7309,6 +7310,7 @@
7BE37F9527C7CD90007A6CD3 /* IPCStreamTester.cpp */,
7BE37F9427C7CD51007A6CD3 /* IPCStreamTester.h */,
7BE37F9227C7C518007A6CD3 /* IPCStreamTesterIdentifier.h */,
+ 7B2DDD5E27CCD9710060ABAB /* IPCStreamTesterProxy.h */,
7B50E97F2771F6CE003DAAC4 /* IPCTester.cpp */,
7B50E9802771F6CF003DAAC4 /* IPCTester.h */,
1A92DC1212F8BAB90017AF65 /* LayerTreeContext.cpp */,
