Title: [290608] trunk/Tools
- Revision
- 290608
- Author
- ange...@igalia.com
- Date
- 2022-02-28 11:18:50 -0800 (Mon, 28 Feb 2022)
Log Message
[webkit-patch] Allow user to opt out of browser for viewing the diff
https://bugs.webkit.org/show_bug.cgi?id=220925
Reviewed by Jonathan Bedard.
The user may legitimately have a browser installed yet not want to
use it to view the diff.
* Scripts/webkitpy/common/system/user.py:
(User.can_open_url):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (290607 => 290608)
--- trunk/Tools/ChangeLog 2022-02-28 19:10:48 UTC (rev 290607)
+++ trunk/Tools/ChangeLog 2022-02-28 19:18:50 UTC (rev 290608)
@@ -1,3 +1,16 @@
+2022-02-28 Angelos Oikonomopoulos <ange...@igalia.com>
+
+ [webkit-patch] Allow user to opt out of browser for viewing the diff
+ https://bugs.webkit.org/show_bug.cgi?id=220925
+
+ Reviewed by Jonathan Bedard.
+
+ The user may legitimately have a browser installed yet not want to
+ use it to view the diff.
+
+ * Scripts/webkitpy/common/system/user.py:
+ (User.can_open_url):
+
2022-02-28 Jonathan Bedard <jbed...@apple.com>
Unreviewed, reverting r290583.
Modified: trunk/Tools/Scripts/webkitpy/tool/steps/confirmdiff.py (290607 => 290608)
--- trunk/Tools/Scripts/webkitpy/tool/steps/confirmdiff.py 2022-02-28 19:10:48 UTC (rev 290607)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/confirmdiff.py 2022-02-28 19:18:50 UTC (rev 290608)
@@ -26,6 +26,7 @@
# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+import os
import sys
from webkitpy.tool.steps.abstractstep import AbstractStep
@@ -50,7 +51,7 @@
]
def _show_pretty_diff(self, diff):
- if not self._tool.user.can_open_url():
+ if os.environ.get('WEBKIT_PATCH_PREFER_PAGER') or not self._tool.user.can_open_url():
return None
try:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
