Title: [291158] trunk
Revision
291158
Author
grao...@webkit.org
Date
2022-03-11 06:01:39 -0800 (Fri, 11 Mar 2022)

Log Message

[web-animations] mask-type should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237768

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291157 => 291158)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-11 13:48:53 UTC (rev 291157)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2022-03-11 14:01:39 UTC (rev 291158)
@@ -1,5 +1,16 @@
 2022-03-11  Antoine Quint  <grao...@webkit.org>
 
+        [web-animations] mask-type should support discrete animation
+        https://bugs.webkit.org/show_bug.cgi?id=237768
+
+        Reviewed by Antti Koivisto.
+
+        * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
+        * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
+        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
+
+2022-03-11  Antoine Quint  <grao...@webkit.org>
+
         [web-animations] text-rendering should support discrete animation
         https://bugs.webkit.org/show_bug.cgi?id=237777
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt (291157 => 291158)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt	2022-03-11 13:48:53 UTC (rev 291157)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt	2022-03-11 14:01:39 UTC (rev 291158)
@@ -43,6 +43,9 @@
 PASS mask-origin (type: discrete) has testAccumulation function
 PASS mask-origin: "border-box" onto "content-box"
 PASS mask-origin: "content-box" onto "border-box"
+PASS mask-type (type: discrete) has testAccumulation function
+PASS mask-type: "luminance" onto "alpha"
+PASS mask-type: "alpha" onto "luminance"
 PASS mix-blend-mode (type: discrete) has testAccumulation function
 PASS mix-blend-mode: "screen" onto "multiply"
 PASS mix-blend-mode: "multiply" onto "screen"

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt (291157 => 291158)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt	2022-03-11 13:48:53 UTC (rev 291157)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt	2022-03-11 14:01:39 UTC (rev 291158)
@@ -43,6 +43,9 @@
 PASS mask-origin (type: discrete) has testAddition function
 PASS mask-origin: "border-box" onto "content-box"
 PASS mask-origin: "content-box" onto "border-box"
+PASS mask-type (type: discrete) has testAddition function
+PASS mask-type: "luminance" onto "alpha"
+PASS mask-type: "alpha" onto "luminance"
 PASS mix-blend-mode (type: discrete) has testAddition function
 PASS mix-blend-mode: "screen" onto "multiply"
 PASS mix-blend-mode: "multiply" onto "screen"

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt (291157 => 291158)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt	2022-03-11 13:48:53 UTC (rev 291157)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt	2022-03-11 14:01:39 UTC (rev 291158)
@@ -54,6 +54,10 @@
 PASS mask-origin uses discrete animation when animating between "content-box" and "border-box" with linear easing
 PASS mask-origin uses discrete animation when animating between "content-box" and "border-box" with effect easing
 PASS mask-origin uses discrete animation when animating between "content-box" and "border-box" with keyframe easing
+PASS mask-type (type: discrete) has testInterpolation function
+PASS mask-type uses discrete animation when animating between "alpha" and "luminance" with linear easing
+PASS mask-type uses discrete animation when animating between "alpha" and "luminance" with effect easing
+PASS mask-type uses discrete animation when animating between "alpha" and "luminance" with keyframe easing
 PASS mix-blend-mode (type: discrete) has testInterpolation function
 PASS mix-blend-mode uses discrete animation when animating between "multiply" and "screen" with linear easing
 PASS mix-blend-mode uses discrete animation when animating between "multiply" and "screen" with effect easing

Modified: trunk/Source/WebCore/ChangeLog (291157 => 291158)


--- trunk/Source/WebCore/ChangeLog	2022-03-11 13:48:53 UTC (rev 291157)
+++ trunk/Source/WebCore/ChangeLog	2022-03-11 14:01:39 UTC (rev 291158)
@@ -1,5 +1,15 @@
 2022-03-11  Antoine Quint  <grao...@webkit.org>
 
+        [web-animations] mask-type should support discrete animation
+        https://bugs.webkit.org/show_bug.cgi?id=237768
+
+        Reviewed by Antti Koivisto.
+
+        * animation/CSSPropertyAnimation.cpp:
+        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
+
+2022-03-11  Antoine Quint  <grao...@webkit.org>
+
         [web-animations] text-rendering should support discrete animation
         https://bugs.webkit.org/show_bug.cgi?id=237777
 

Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (291157 => 291158)


--- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp	2022-03-11 13:48:53 UTC (rev 291157)
+++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp	2022-03-11 14:01:39 UTC (rev 291158)
@@ -3249,6 +3249,7 @@
         new QuotesWrapper,
         new DiscretePropertyWrapper<bool>(CSSPropertyScrollBehavior, &RenderStyle::useSmoothScrolling, &RenderStyle::setUseSmoothScrolling),
         new DiscreteFontDescriptionTypedWrapper<TextRenderingMode>(CSSPropertyTextRendering, &FontCascadeDescription::textRenderingMode, &FontCascadeDescription::setTextRenderingMode),
+        new DiscreteSVGPropertyWrapper<MaskType>(CSSPropertyMaskType, &SVGRenderStyle::maskType, &SVGRenderStyle::setMaskType)
     };
     const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to