Title: [291170] trunk
- Revision
- 291170
- Author
- grao...@webkit.org
- Date
- 2022-03-11 09:08:15 -0800 (Fri, 11 Mar 2022)
Log Message
[web-animations] vector-effect should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237766
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
* web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
* web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
Source/WebCore:
* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (291169 => 291170)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-11 16:44:43 UTC (rev 291169)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-03-11 17:08:15 UTC (rev 291170)
@@ -1,5 +1,16 @@
2022-03-11 Antoine Quint <grao...@webkit.org>
+ [web-animations] vector-effect should support discrete animation
+ https://bugs.webkit.org/show_bug.cgi?id=237766
+
+ Reviewed by Antti Koivisto.
+
+ * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt:
+ * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt:
+ * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
+
+2022-03-11 Antoine Quint <grao...@webkit.org>
+
[web-animations] text-anchor should support discrete animation
https://bugs.webkit.org/show_bug.cgi?id=237765
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt (291169 => 291170)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt 2022-03-11 16:44:43 UTC (rev 291169)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-002-expected.txt 2022-03-11 17:08:15 UTC (rev 291170)
@@ -248,6 +248,9 @@
PASS scale with two unspecified values
PASS scale with one unspecified value
PASS scale
+PASS vector-effect (type: discrete) has testAccumulation function
+PASS vector-effect: "non-scaling-stroke" onto "none"
+PASS vector-effect: "none" onto "non-scaling-stroke"
PASS visibility (type: visibility) has testAccumulation function
PASS visibility: onto "visible"
PASS visibility: onto "hidden"
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt (291169 => 291170)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt 2022-03-11 16:44:43 UTC (rev 291169)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-002-expected.txt 2022-03-11 17:08:15 UTC (rev 291170)
@@ -244,6 +244,9 @@
PASS scale with two unspecified values
PASS scale with one unspecified value
PASS scale
+PASS vector-effect (type: discrete) has testAddition function
+PASS vector-effect: "non-scaling-stroke" onto "none"
+PASS vector-effect: "none" onto "non-scaling-stroke"
PASS visibility (type: visibility) has testAddition function
PASS visibility: onto "visible"
PASS visibility: onto "hidden"
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt (291169 => 291170)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt 2022-03-11 16:44:43 UTC (rev 291169)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt 2022-03-11 17:08:15 UTC (rev 291170)
@@ -302,6 +302,10 @@
PASS scale with two unspecified values
PASS scale with one unspecified value
PASS scale
+PASS vector-effect (type: discrete) has testInterpolation function
+PASS vector-effect uses discrete animation when animating between "none" and "non-scaling-stroke" with linear easing
+PASS vector-effect uses discrete animation when animating between "none" and "non-scaling-stroke" with effect easing
+PASS vector-effect uses discrete animation when animating between "none" and "non-scaling-stroke" with keyframe easing
PASS visibility (type: visibility) has testInterpolation function
PASS visibility uses visibility animation when animating from "visible" to "hidden"
PASS visibility uses visibility animation when animating from "hidden" to "visible"
Modified: trunk/Source/WebCore/ChangeLog (291169 => 291170)
--- trunk/Source/WebCore/ChangeLog 2022-03-11 16:44:43 UTC (rev 291169)
+++ trunk/Source/WebCore/ChangeLog 2022-03-11 17:08:15 UTC (rev 291170)
@@ -1,3 +1,13 @@
+2022-03-11 Antoine Quint <grao...@webkit.org>
+
+ [web-animations] vector-effect should support discrete animation
+ https://bugs.webkit.org/show_bug.cgi?id=237766
+
+ Reviewed by Antti Koivisto.
+
+ * animation/CSSPropertyAnimation.cpp:
+ (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
+
2022-03-11 Alan Bujtas <za...@apple.com>
[IFC][Integration] Add support for inline table
Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (291169 => 291170)
--- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2022-03-11 16:44:43 UTC (rev 291169)
+++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2022-03-11 17:08:15 UTC (rev 291170)
@@ -3264,7 +3264,8 @@
new DiscreteSVGPropertyWrapper<MaskType>(CSSPropertyMaskType, &SVGRenderStyle::maskType, &SVGRenderStyle::setMaskType),
new DiscretePropertyWrapper<LineCap>(CSSPropertyStrokeLinecap, &RenderStyle::capStyle, &RenderStyle::setCapStyle),
new DiscretePropertyWrapper<LineJoin>(CSSPropertyStrokeLinejoin, &RenderStyle::joinStyle, &RenderStyle::setJoinStyle),
- new DiscreteSVGPropertyWrapper<TextAnchor>(CSSPropertyTextAnchor, &SVGRenderStyle::textAnchor, &SVGRenderStyle::setTextAnchor)
+ new DiscreteSVGPropertyWrapper<TextAnchor>(CSSPropertyTextAnchor, &SVGRenderStyle::textAnchor, &SVGRenderStyle::setTextAnchor),
+ new DiscreteSVGPropertyWrapper<VectorEffect>(CSSPropertyVectorEffect, &SVGRenderStyle::vectorEffect, &SVGRenderStyle::setVectorEffect)
};
const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
