Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (292271 => 292272)
--- trunk/Source/_javascript_Core/ChangeLog 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-04-03 03:56:21 UTC (rev 292272)
@@ -1,3 +1,87 @@
+2022-04-02 Chris Dumez <cdu...@apple.com>
+
+ Add default constructor to ASCIILiteral
+ https://bugs.webkit.org/show_bug.cgi?id=238700
+
+ Reviewed by Geoffrey Garen.
+
+ Add default constructor to ASCIILiteral, to replace the more verbose ASCIILiteral::null().
+
+ * Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result:
+ * Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result:
+ * Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result:
+ * Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result:
+ * Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result:
+ * Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result:
+ * Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result:
+ * Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
+ * Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
+ * Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
+ * Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
+ * Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
+ * Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
+ * Scripts/wkbuiltins/builtins_model.py:
+ (BuiltinFunction.fromString):
+ * runtime/ArrayBufferSharingMode.h:
+ (JSC::arrayBufferSharingModeName):
+ * runtime/IntlCollator.cpp:
+ (JSC::IntlCollator::initializeCollator):
+ (JSC::IntlCollator::usageString):
+ (JSC::IntlCollator::sensitivityString):
+ (JSC::IntlCollator::caseFirstString):
+ * runtime/IntlDateTimeFormat.cpp:
+ (JSC::IntlDateTimeFormat::initializeDateTimeFormat):
+ (JSC::IntlDateTimeFormat::hourCycleString):
+ (JSC::IntlDateTimeFormat::weekdayString):
+ (JSC::IntlDateTimeFormat::eraString):
+ (JSC::IntlDateTimeFormat::yearString):
+ (JSC::IntlDateTimeFormat::monthString):
+ (JSC::IntlDateTimeFormat::dayString):
+ (JSC::IntlDateTimeFormat::dayPeriodString):
+ (JSC::IntlDateTimeFormat::hourString):
+ (JSC::IntlDateTimeFormat::minuteString):
+ (JSC::IntlDateTimeFormat::secondString):
+ (JSC::IntlDateTimeFormat::timeZoneNameString):
+ (JSC::IntlDateTimeFormat::formatStyleString):
+ * runtime/IntlDisplayNames.cpp:
+ (JSC::IntlDisplayNames::styleString):
+ (JSC::IntlDisplayNames::typeString):
+ (JSC::IntlDisplayNames::fallbackString):
+ (JSC::IntlDisplayNames::languageDisplayString):
+ * runtime/IntlListFormat.cpp:
+ (JSC::IntlListFormat::styleString):
+ (JSC::IntlListFormat::typeString):
+ * runtime/IntlLocale.cpp:
+ (JSC::IntlLocale::initializeLocale):
+ * runtime/IntlNumberFormat.cpp:
+ (JSC::IntlNumberFormat::initializeNumberFormat):
+ (JSC::IntlNumberFormat::styleString):
+ (JSC::IntlNumberFormat::currencyDisplayString):
+ (JSC::IntlNumberFormat::notationString):
+ (JSC::IntlNumberFormat::currencySignString):
+ (JSC::IntlNumberFormat::unitDisplayString):
+ (JSC::IntlNumberFormat::compactDisplayString):
+ (JSC::IntlNumberFormat::signDisplayString):
+ (JSC::IntlNumberFormat::roundingModeString):
+ (JSC::IntlNumberFormat::trailingZeroDisplayString):
+ (JSC::IntlNumberFormat::roundingPriorityString):
+ * runtime/IntlObject.cpp:
+ (JSC::relevantExtensionKeyString):
+ * runtime/IntlRelativeTimeFormat.cpp:
+ (JSC::IntlRelativeTimeFormat::initializeRelativeTimeFormat):
+ (JSC::IntlRelativeTimeFormat::styleString):
+ * runtime/IntlSegmenter.cpp:
+ (JSC::IntlSegmenter::granularityString):
+ * runtime/JSObjectInlines.h:
+ (JSC::JSObject::putDirectInternal):
+ * runtime/TemporalDuration.cpp:
+ (JSC::TemporalDuration::total const):
+ * runtime/TemporalObject.cpp:
+ (JSC::temporalLargestUnit):
+ (JSC::temporalSmallestUnit):
+ * yarr/YarrErrorCode.cpp:
+ (JSC::Yarr::errorMessage):
+
2022-04-02 Keith Miller <keith_mil...@apple.com>
AI should do int32 optimization in ValueRep
Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result (292271 => 292272)
--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Combined.js-result 2022-04-03 03:56:21 UTC (rev 292272)
@@ -60,8 +60,8 @@
macro(fulfillPromise, builtinPromiseFulfillPromise, 2) \
#define JSC_FOREACH_BUILTIN_CODE(macro) \
- macro(builtinPromiseFulfillPromiseCode, fulfillPromise, ASCIILiteral::null(), s_builtinPromiseFulfillPromiseCodeLength) \
- macro(builtinPromiseRejectPromiseCode, rejectPromise, ASCIILiteral::null(), s_builtinPromiseRejectPromiseCodeLength) \
+ macro(builtinPromiseFulfillPromiseCode, fulfillPromise, ASCIILiteral(), s_builtinPromiseFulfillPromiseCodeLength) \
+ macro(builtinPromiseRejectPromiseCode, rejectPromise, ASCIILiteral(), s_builtinPromiseRejectPromiseCodeLength) \
#define JSC_FOREACH_BUILTIN_FUNCTION_NAME(macro) \
macro(fulfillPromise) \
Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result (292271 => 292272)
--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.Promise-Separate.js-result 2022-04-03 03:56:21 UTC (rev 292272)
@@ -57,8 +57,8 @@
#define JSC_BUILTIN_BUILTIN_PROMISE_FULFILLPROMISE 1
#define JSC_FOREACH_BUILTIN.PROMISE_BUILTIN_CODE(macro) \
- macro(builtinPromiseRejectPromiseCode, rejectPromise, ASCIILiteral::null(), s_builtinPromiseRejectPromiseCodeLength) \
- macro(builtinPromiseFulfillPromiseCode, fulfillPromise, ASCIILiteral::null(), s_builtinPromiseFulfillPromiseCodeLength) \
+ macro(builtinPromiseRejectPromiseCode, rejectPromise, ASCIILiteral(), s_builtinPromiseRejectPromiseCodeLength) \
+ macro(builtinPromiseFulfillPromiseCode, fulfillPromise, ASCIILiteral(), s_builtinPromiseFulfillPromiseCodeLength) \
#define JSC_FOREACH_BUILTIN.PROMISE_BUILTIN_FUNCTION_NAME(macro) \
macro(fulfillPromise) \
Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result (292271 => 292272)
--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Combined.js-result 2022-04-03 03:56:21 UTC (rev 292272)
@@ -70,10 +70,10 @@
macro(test, builtinPrototypeTest, 1) \
#define JSC_FOREACH_BUILTIN_CODE(macro) \
- macro(builtinPrototypeEveryCode, every, ASCIILiteral::null(), s_builtinPrototypeEveryCodeLength) \
- macro(builtinPrototypeForEachCode, forEach, ASCIILiteral::null(), s_builtinPrototypeForEachCodeLength) \
+ macro(builtinPrototypeEveryCode, every, ASCIILiteral(), s_builtinPrototypeEveryCodeLength) \
+ macro(builtinPrototypeForEachCode, forEach, ASCIILiteral(), s_builtinPrototypeForEachCodeLength) \
macro(builtinPrototypeMatchCode, match, "[Symbol.match]"_s, s_builtinPrototypeMatchCodeLength) \
- macro(builtinPrototypeTestCode, test, ASCIILiteral::null(), s_builtinPrototypeTestCodeLength) \
+ macro(builtinPrototypeTestCode, test, ASCIILiteral(), s_builtinPrototypeTestCodeLength) \
#define JSC_FOREACH_BUILTIN_FUNCTION_NAME(macro) \
macro(every) \
Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result (292271 => 292272)
--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-Builtin.prototype-Separate.js-result 2022-04-03 03:56:21 UTC (rev 292272)
@@ -69,10 +69,10 @@
#define JSC_BUILTIN_BUILTIN_PROTOTYPE_TEST 1
#define JSC_FOREACH_BUILTIN.PROTOTYPE_BUILTIN_CODE(macro) \
- macro(builtinPrototypeEveryCode, every, ASCIILiteral::null(), s_builtinPrototypeEveryCodeLength) \
- macro(builtinPrototypeForEachCode, forEach, ASCIILiteral::null(), s_builtinPrototypeForEachCodeLength) \
+ macro(builtinPrototypeEveryCode, every, ASCIILiteral(), s_builtinPrototypeEveryCodeLength) \
+ macro(builtinPrototypeForEachCode, forEach, ASCIILiteral(), s_builtinPrototypeForEachCodeLength) \
macro(builtinPrototypeMatchCode, match, "[Symbol.match]"_s, s_builtinPrototypeMatchCodeLength) \
- macro(builtinPrototypeTestCode, test, ASCIILiteral::null(), s_builtinPrototypeTestCodeLength) \
+ macro(builtinPrototypeTestCode, test, ASCIILiteral(), s_builtinPrototypeTestCodeLength) \
#define JSC_FOREACH_BUILTIN.PROTOTYPE_BUILTIN_FUNCTION_NAME(macro) \
macro(every) \
Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result (292271 => 292272)
--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Combined.js-result 2022-04-03 03:56:21 UTC (rev 292272)
@@ -59,8 +59,8 @@
macro(from, builtinConstructorFrom, 1) \
#define JSC_FOREACH_BUILTIN_CODE(macro) \
- macro(builtinConstructorFromCode, from, ASCIILiteral::null(), s_builtinConstructorFromCodeLength) \
- macro(builtinConstructorOfCode, of, ASCIILiteral::null(), s_builtinConstructorOfCodeLength) \
+ macro(builtinConstructorFromCode, from, ASCIILiteral(), s_builtinConstructorFromCodeLength) \
+ macro(builtinConstructorOfCode, of, ASCIILiteral(), s_builtinConstructorOfCodeLength) \
#define JSC_FOREACH_BUILTIN_FUNCTION_NAME(macro) \
macro(from) \
Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result (292271 => 292272)
--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-BuiltinConstructor-Separate.js-result 2022-04-03 03:56:21 UTC (rev 292272)
@@ -56,8 +56,8 @@
#define JSC_BUILTIN_BUILTINCONSTRUCTOR_FROM 1
#define JSC_FOREACH_BUILTINCONSTRUCTOR_BUILTIN_CODE(macro) \
- macro(builtinConstructorOfCode, of, ASCIILiteral::null(), s_builtinConstructorOfCodeLength) \
- macro(builtinConstructorFromCode, from, ASCIILiteral::null(), s_builtinConstructorFromCodeLength) \
+ macro(builtinConstructorOfCode, of, ASCIILiteral(), s_builtinConstructorOfCodeLength) \
+ macro(builtinConstructorFromCode, from, ASCIILiteral(), s_builtinConstructorFromCodeLength) \
#define JSC_FOREACH_BUILTINCONSTRUCTOR_BUILTIN_FUNCTION_NAME(macro) \
macro(from) \
Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result (292271 => 292272)
--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/_javascript_Core-InternalClashingNames-Combined.js-result 2022-04-03 03:56:21 UTC (rev 292272)
@@ -60,8 +60,8 @@
macro(isReadableStreamLocked, internalClashingNamesIsReadableStreamLocked, 1) \
#define JSC_FOREACH_BUILTIN_CODE(macro) \
- macro(internalClashingNamesIsReadableStreamLockedCode, isReadableStreamLocked, ASCIILiteral::null(), s_internalClashingNamesIsReadableStreamLockedCodeLength) \
- macro(internalClashingNamesIsReadableStreamLockedCode, isReadableStreamLocked, ASCIILiteral::null(), s_internalClashingNamesIsReadableStreamLockedCodeLength) \
+ macro(internalClashingNamesIsReadableStreamLockedCode, isReadableStreamLocked, ASCIILiteral(), s_internalClashingNamesIsReadableStreamLockedCodeLength) \
+ macro(internalClashingNamesIsReadableStreamLockedCode, isReadableStreamLocked, ASCIILiteral(), s_internalClashingNamesIsReadableStreamLockedCodeLength) \
#define JSC_FOREACH_BUILTIN_FUNCTION_NAME(macro) \
macro(isReadableStreamLocked) \
Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result (292271 => 292272)
--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result 2022-04-03 03:56:21 UTC (rev 292272)
@@ -55,7 +55,7 @@
#define WEBCORE_BUILTIN_ANOTHERGUARDEDINTERNALBUILTIN_LETSFETCH 1
#define WEBCORE_FOREACH_ANOTHERGUARDEDINTERNALBUILTIN_BUILTIN_CODE(macro) \
- macro(anotherGuardedInternalBuiltinLetsFetchCode, letsFetch, ASCIILiteral::null(), s_anotherGuardedInternalBuiltinLetsFetchCodeLength) \
+ macro(anotherGuardedInternalBuiltinLetsFetchCode, letsFetch, ASCIILiteral(), s_anotherGuardedInternalBuiltinLetsFetchCodeLength) \
#define WEBCORE_FOREACH_ANOTHERGUARDEDINTERNALBUILTIN_BUILTIN_FUNCTION_NAME(macro) \
macro(letsFetch) \
Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result (292271 => 292272)
--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result 2022-04-03 03:56:21 UTC (rev 292272)
@@ -56,7 +56,7 @@
#define WEBCORE_BUILTIN_ARBITRARYCONDITIONALGUARD_ISREADABLESTREAMLOCKED 1
#define WEBCORE_FOREACH_ARBITRARYCONDITIONALGUARD_BUILTIN_CODE(macro) \
- macro(arbitraryConditionalGuardIsReadableStreamLockedCode, isReadableStreamLocked, ASCIILiteral::null(), s_arbitraryConditionalGuardIsReadableStreamLockedCodeLength) \
+ macro(arbitraryConditionalGuardIsReadableStreamLockedCode, isReadableStreamLocked, ASCIILiteral(), s_arbitraryConditionalGuardIsReadableStreamLockedCodeLength) \
#define WEBCORE_FOREACH_ARBITRARYCONDITIONALGUARD_BUILTIN_FUNCTION_NAME(macro) \
macro(isReadableStreamLocked) \
Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result (292271 => 292272)
--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result 2022-04-03 03:56:21 UTC (rev 292272)
@@ -56,7 +56,7 @@
#define WEBCORE_BUILTIN_GUARDEDBUILTIN_ISREADABLESTREAMLOCKED 1
#define WEBCORE_FOREACH_GUARDEDBUILTIN_BUILTIN_CODE(macro) \
- macro(guardedBuiltinIsReadableStreamLockedCode, isReadableStreamLocked, ASCIILiteral::null(), s_guardedBuiltinIsReadableStreamLockedCodeLength) \
+ macro(guardedBuiltinIsReadableStreamLockedCode, isReadableStreamLocked, ASCIILiteral(), s_guardedBuiltinIsReadableStreamLockedCodeLength) \
#define WEBCORE_FOREACH_GUARDEDBUILTIN_BUILTIN_FUNCTION_NAME(macro) \
macro(isReadableStreamLocked) \
Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result (292271 => 292272)
--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result 2022-04-03 03:56:21 UTC (rev 292272)
@@ -56,7 +56,7 @@
#define WEBCORE_BUILTIN_GUARDEDINTERNALBUILTIN_ISREADABLESTREAMLOCKED 1
#define WEBCORE_FOREACH_GUARDEDINTERNALBUILTIN_BUILTIN_CODE(macro) \
- macro(guardedInternalBuiltinIsReadableStreamLockedCode, isReadableStreamLocked, ASCIILiteral::null(), s_guardedInternalBuiltinIsReadableStreamLockedCodeLength) \
+ macro(guardedInternalBuiltinIsReadableStreamLockedCode, isReadableStreamLocked, ASCIILiteral(), s_guardedInternalBuiltinIsReadableStreamLockedCodeLength) \
#define WEBCORE_FOREACH_GUARDEDINTERNALBUILTIN_BUILTIN_FUNCTION_NAME(macro) \
macro(isReadableStreamLocked) \
Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result (292271 => 292272)
--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result 2022-04-03 03:56:21 UTC (rev 292272)
@@ -54,7 +54,7 @@
#define WEBCORE_BUILTIN_UNGUARDEDBUILTIN_ISREADABLESTREAMLOCKED 1
#define WEBCORE_FOREACH_UNGUARDEDBUILTIN_BUILTIN_CODE(macro) \
- macro(unguardedBuiltinIsReadableStreamLockedCode, isReadableStreamLocked, ASCIILiteral::null(), s_unguardedBuiltinIsReadableStreamLockedCodeLength) \
+ macro(unguardedBuiltinIsReadableStreamLockedCode, isReadableStreamLocked, ASCIILiteral(), s_unguardedBuiltinIsReadableStreamLockedCodeLength) \
#define WEBCORE_FOREACH_UNGUARDEDBUILTIN_BUILTIN_FUNCTION_NAME(macro) \
macro(isReadableStreamLocked) \
Modified: trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result (292271 => 292272)
--- trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result 2022-04-03 03:56:21 UTC (rev 292272)
@@ -68,9 +68,9 @@
#define WEBCORE_BUILTIN_XMLCASINGTEST_URLCASINGTEST 1
#define WEBCORE_FOREACH_XMLCASINGTEST_BUILTIN_CODE(macro) \
- macro(xmlCasingTestXMLCasingTestCode, xmlCasingTest, ASCIILiteral::null(), s_xmlCasingTestXMLCasingTestCodeLength) \
- macro(xmlCasingTestCssCasingTestCode, cssCasingTest, ASCIILiteral::null(), s_xmlCasingTestCssCasingTestCodeLength) \
- macro(xmlCasingTestUrlCasingTestCode, urlCasingTest, ASCIILiteral::null(), s_xmlCasingTestUrlCasingTestCodeLength) \
+ macro(xmlCasingTestXMLCasingTestCode, xmlCasingTest, ASCIILiteral(), s_xmlCasingTestXMLCasingTestCodeLength) \
+ macro(xmlCasingTestCssCasingTestCode, cssCasingTest, ASCIILiteral(), s_xmlCasingTestCssCasingTestCodeLength) \
+ macro(xmlCasingTestUrlCasingTestCode, urlCasingTest, ASCIILiteral(), s_xmlCasingTestUrlCasingTestCodeLength) \
#define WEBCORE_FOREACH_XMLCASINGTEST_BUILTIN_FUNCTION_NAME(macro) \
macro(cssCasingTest) \
Modified: trunk/Source/_javascript_Core/Scripts/wkbuiltins/builtins_model.py (292271 => 292272)
--- trunk/Source/_javascript_Core/Scripts/wkbuiltins/builtins_model.py 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/Scripts/wkbuiltins/builtins_model.py 2022-04-03 03:56:21 UTC (rev 292272)
@@ -153,7 +153,7 @@
overridden_name = "\"get %s\"_s" % (function_name)
if not overridden_name:
- overridden_name = "ASCIILiteral::null()"
+ overridden_name = "ASCIILiteral()"
if overridden_name[-1] == "\"":
overridden_name += "_s"
Modified: trunk/Source/_javascript_Core/runtime/ArrayBufferSharingMode.h (292271 => 292272)
--- trunk/Source/_javascript_Core/runtime/ArrayBufferSharingMode.h 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/runtime/ArrayBufferSharingMode.h 2022-04-03 03:56:21 UTC (rev 292272)
@@ -44,7 +44,7 @@
return "SharedArrayBuffer"_s;
}
RELEASE_ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
} // namespace JSC
Modified: trunk/Source/_javascript_Core/runtime/IntlCollator.cpp (292271 => 292272)
--- trunk/Source/_javascript_Core/runtime/IntlCollator.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/runtime/IntlCollator.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -172,7 +172,7 @@
RETURN_IF_EXCEPTION(scope, void());
{
- String collation = intlStringOption(globalObject, options, vm.propertyNames->collation, { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String collation = intlStringOption(globalObject, options, vm.propertyNames->collation, { }, { }, { });
RETURN_IF_EXCEPTION(scope, void());
if (!collation.isNull()) {
if (!isUnicodeLocaleIdentifierType(collation)) {
@@ -188,7 +188,7 @@
if (numeric != TriState::Indeterminate)
localeOptions[static_cast<unsigned>(RelevantExtensionKey::Kn)] = String(numeric == TriState::True ? "true"_s : "false"_s);
- String caseFirstOption = intlStringOption(globalObject, options, vm.propertyNames->caseFirst, { "upper", "lower", "false" }, "caseFirst must be either \"upper\", \"lower\", or \"false\""_s, ASCIILiteral::null());
+ String caseFirstOption = intlStringOption(globalObject, options, vm.propertyNames->caseFirst, { "upper", "lower", "false" }, "caseFirst must be either \"upper\", \"lower\", or \"false\""_s, { });
RETURN_IF_EXCEPTION(scope, void());
if (!caseFirstOption.isNull())
localeOptions[static_cast<unsigned>(RelevantExtensionKey::Kf)] = caseFirstOption;
@@ -330,7 +330,7 @@
return "search"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlCollator::sensitivityString(Sensitivity sensitivity)
@@ -346,7 +346,7 @@
return "variant"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlCollator::caseFirstString(CaseFirst caseFirst)
@@ -360,7 +360,7 @@
return "upper"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
// https://tc39.es/ecma402/#sec-intl.collator.prototype.resolvedoptions
Modified: trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp (292271 => 292272)
--- trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/runtime/IntlDateTimeFormat.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -604,7 +604,7 @@
LocaleMatcher localeMatcher = intlOption<LocaleMatcher>(globalObject, options, vm.propertyNames->localeMatcher, { { "lookup"_s, LocaleMatcher::Lookup }, { "best fit"_s, LocaleMatcher::BestFit } }, "localeMatcher must be either \"lookup\" or \"best fit\""_s, LocaleMatcher::BestFit);
RETURN_IF_EXCEPTION(scope, void());
- String calendar = intlStringOption(globalObject, options, vm.propertyNames->calendar, { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String calendar = intlStringOption(globalObject, options, vm.propertyNames->calendar, { }, { }, { });
RETURN_IF_EXCEPTION(scope, void());
if (!calendar.isNull()) {
if (!isUnicodeLocaleIdentifierType(calendar)) {
@@ -614,7 +614,7 @@
localeOptions[static_cast<unsigned>(RelevantExtensionKey::Ca)] = calendar;
}
- String numberingSystem = intlStringOption(globalObject, options, vm.propertyNames->numberingSystem, { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String numberingSystem = intlStringOption(globalObject, options, vm.propertyNames->numberingSystem, { }, { }, { });
RETURN_IF_EXCEPTION(scope, void());
if (!numberingSystem.isNull()) {
if (!isUnicodeLocaleIdentifierType(numberingSystem)) {
@@ -1019,10 +1019,10 @@
return "h24"_s;
case HourCycle::None:
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlDateTimeFormat::weekdayString(Weekday weekday)
@@ -1036,10 +1036,10 @@
return "long"_s;
case Weekday::None:
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlDateTimeFormat::eraString(Era era)
@@ -1053,10 +1053,10 @@
return "long"_s;
case Era::None:
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlDateTimeFormat::yearString(Year year)
@@ -1068,10 +1068,10 @@
return "numeric"_s;
case Year::None:
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlDateTimeFormat::monthString(Month month)
@@ -1089,10 +1089,10 @@
return "long"_s;
case Month::None:
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlDateTimeFormat::dayString(Day day)
@@ -1104,10 +1104,10 @@
return "numeric"_s;
case Day::None:
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlDateTimeFormat::dayPeriodString(DayPeriod dayPeriod)
@@ -1121,10 +1121,10 @@
return "long"_s;
case DayPeriod::None:
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlDateTimeFormat::hourString(Hour hour)
@@ -1136,10 +1136,10 @@
return "numeric"_s;
case Hour::None:
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlDateTimeFormat::minuteString(Minute minute)
@@ -1151,10 +1151,10 @@
return "numeric"_s;
case Minute::None:
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlDateTimeFormat::secondString(Second second)
@@ -1166,10 +1166,10 @@
return "numeric"_s;
case Second::None:
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlDateTimeFormat::timeZoneNameString(TimeZoneName timeZoneName)
@@ -1189,10 +1189,10 @@
return "longGeneric"_s;
case TimeZoneName::None:
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlDateTimeFormat::formatStyleString(DateTimeStyle style)
@@ -1208,10 +1208,10 @@
return "short"_s;
case DateTimeStyle::None:
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
// https://tc39.es/ecma402/#sec-intl.datetimeformat.prototype.resolvedoptions
Modified: trunk/Source/_javascript_Core/runtime/IntlDisplayNames.cpp (292271 => 292272)
--- trunk/Source/_javascript_Core/runtime/IntlDisplayNames.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/runtime/IntlDisplayNames.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -377,7 +377,7 @@
return "long"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlDisplayNames::typeString(Type type)
@@ -397,7 +397,7 @@
return "dateTimeField"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlDisplayNames::fallbackString(Fallback fallback)
@@ -409,7 +409,7 @@
return "none"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlDisplayNames::languageDisplayString(LanguageDisplay languageDisplay)
@@ -421,7 +421,7 @@
return "standard"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
} // namespace JSC
Modified: trunk/Source/_javascript_Core/runtime/IntlListFormat.cpp (292271 => 292272)
--- trunk/Source/_javascript_Core/runtime/IntlListFormat.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/runtime/IntlListFormat.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -353,7 +353,7 @@
return "narrow"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlListFormat::typeString(Type type)
@@ -367,7 +367,7 @@
return "unit"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
} // namespace JSC
Modified: trunk/Source/_javascript_Core/runtime/IntlLocale.cpp (292271 => 292272)
--- trunk/Source/_javascript_Core/runtime/IntlLocale.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/runtime/IntlLocale.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -251,7 +251,7 @@
return;
}
- String language = intlStringOption(globalObject, options, vm.propertyNames->language, { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String language = intlStringOption(globalObject, options, vm.propertyNames->language, { }, { }, { });
RETURN_IF_EXCEPTION(scope, void());
if (!language.isNull() && !isUnicodeLanguageSubtag(language)) {
throwRangeError(globalObject, scope, "language is not a well-formed language value"_s);
@@ -258,7 +258,7 @@
return;
}
- String script = intlStringOption(globalObject, options, vm.propertyNames->script, { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String script = intlStringOption(globalObject, options, vm.propertyNames->script, { }, { }, { });
RETURN_IF_EXCEPTION(scope, void());
if (!script.isNull() && !isUnicodeScriptSubtag(script)) {
throwRangeError(globalObject, scope, "script is not a well-formed script value"_s);
@@ -265,7 +265,7 @@
return;
}
- String region = intlStringOption(globalObject, options, vm.propertyNames->region, { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String region = intlStringOption(globalObject, options, vm.propertyNames->region, { }, { }, { });
RETURN_IF_EXCEPTION(scope, void());
if (!region.isNull() && !isUnicodeRegionSubtag(region)) {
throwRangeError(globalObject, scope, "region is not a well-formed region value"_s);
@@ -275,7 +275,7 @@
if (!language.isNull() || !script.isNull() || !region.isNull())
localeID.overrideLanguageScriptRegion(language, script, region);
- String calendar = intlStringOption(globalObject, options, vm.propertyNames->calendar, { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String calendar = intlStringOption(globalObject, options, vm.propertyNames->calendar, { }, { }, { });
RETURN_IF_EXCEPTION(scope, void());
if (!calendar.isNull()) {
if (!isUnicodeLocaleIdentifierType(calendar)) {
@@ -285,7 +285,7 @@
localeID.setKeywordValue("calendar"_s, calendar);
}
- String collation = intlStringOption(globalObject, options, vm.propertyNames->collation, { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String collation = intlStringOption(globalObject, options, vm.propertyNames->collation, { }, { }, { });
RETURN_IF_EXCEPTION(scope, void());
if (!collation.isNull()) {
if (!isUnicodeLocaleIdentifierType(collation)) {
@@ -295,12 +295,12 @@
localeID.setKeywordValue("collation"_s, collation);
}
- String hourCycle = intlStringOption(globalObject, options, vm.propertyNames->hourCycle, { "h11", "h12", "h23", "h24" }, "hourCycle must be \"h11\", \"h12\", \"h23\", or \"h24\""_s, ASCIILiteral::null());
+ String hourCycle = intlStringOption(globalObject, options, vm.propertyNames->hourCycle, { "h11", "h12", "h23", "h24" }, "hourCycle must be \"h11\", \"h12\", \"h23\", or \"h24\""_s, { });
RETURN_IF_EXCEPTION(scope, void());
if (!hourCycle.isNull())
localeID.setKeywordValue("hours"_s, hourCycle);
- String caseFirst = intlStringOption(globalObject, options, vm.propertyNames->caseFirst, { "upper", "lower", "false" }, "caseFirst must be either \"upper\", \"lower\", or \"false\""_s, ASCIILiteral::null());
+ String caseFirst = intlStringOption(globalObject, options, vm.propertyNames->caseFirst, { "upper", "lower", "false" }, "caseFirst must be either \"upper\", \"lower\", or \"false\""_s, { });
RETURN_IF_EXCEPTION(scope, void());
if (!caseFirst.isNull())
localeID.setKeywordValue("colcasefirst"_s, caseFirst);
@@ -310,7 +310,7 @@
if (numeric != TriState::Indeterminate)
localeID.setKeywordValue("colnumeric"_s, numeric == TriState::True ? "yes" : "no");
- String numberingSystem = intlStringOption(globalObject, options, vm.propertyNames->numberingSystem, { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String numberingSystem = intlStringOption(globalObject, options, vm.propertyNames->numberingSystem, { }, { }, { });
RETURN_IF_EXCEPTION(scope, void());
if (!numberingSystem.isNull()) {
if (!isUnicodeLocaleIdentifierType(numberingSystem)) {
Modified: trunk/Source/_javascript_Core/runtime/IntlNumberFormat.cpp (292271 => 292272)
--- trunk/Source/_javascript_Core/runtime/IntlNumberFormat.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/runtime/IntlNumberFormat.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -304,7 +304,7 @@
LocaleMatcher localeMatcher = intlOption<LocaleMatcher>(globalObject, options, vm.propertyNames->localeMatcher, { { "lookup"_s, LocaleMatcher::Lookup }, { "best fit"_s, LocaleMatcher::BestFit } }, "localeMatcher must be either \"lookup\" or \"best fit\""_s, LocaleMatcher::BestFit);
RETURN_IF_EXCEPTION(scope, void());
- String numberingSystem = intlStringOption(globalObject, options, vm.propertyNames->numberingSystem, { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String numberingSystem = intlStringOption(globalObject, options, vm.propertyNames->numberingSystem, { }, { }, { });
RETURN_IF_EXCEPTION(scope, void());
if (!numberingSystem.isNull()) {
if (!isUnicodeLocaleIdentifierType(numberingSystem)) {
@@ -328,7 +328,7 @@
m_style = intlOption<Style>(globalObject, options, vm.propertyNames->style, { { "decimal"_s, Style::Decimal }, { "percent"_s, Style::Percent }, { "currency"_s, Style::Currency }, { "unit"_s, Style::Unit } }, "style must be either \"decimal\", \"percent\", \"currency\", or \"unit\""_s, Style::Decimal);
RETURN_IF_EXCEPTION(scope, void());
- String currency = intlStringOption(globalObject, options, Identifier::fromString(vm, "currency"_s), { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String currency = intlStringOption(globalObject, options, Identifier::fromString(vm, "currency"_s), { }, { }, { });
RETURN_IF_EXCEPTION(scope, void());
if (!currency.isNull()) {
if (!isWellFormedCurrencyCode(currency)) {
@@ -355,7 +355,7 @@
m_currencySign = intlOption<CurrencySign>(globalObject, options, Identifier::fromString(vm, "currencySign"_s), { { "standard"_s, CurrencySign::Standard }, { "accounting"_s, CurrencySign::Accounting } }, "currencySign must be either \"standard\" or \"accounting\""_s, CurrencySign::Standard);
RETURN_IF_EXCEPTION(scope, void());
- String unit = intlStringOption(globalObject, options, Identifier::fromString(vm, "unit"_s), { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String unit = intlStringOption(globalObject, options, Identifier::fromString(vm, "unit"_s), { }, { }, { });
RETURN_IF_EXCEPTION(scope, void());
std::optional<WellFormedUnit> wellFormedUnit;
if (!unit.isNull()) {
@@ -1258,7 +1258,7 @@
return "unit"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlNumberFormat::currencyDisplayString(CurrencyDisplay currencyDisplay)
@@ -1274,7 +1274,7 @@
return "name"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlNumberFormat::notationString(IntlNotation notation)
@@ -1290,7 +1290,7 @@
return "compact"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlNumberFormat::currencySignString(CurrencySign currencySign)
@@ -1302,7 +1302,7 @@
return "accounting"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlNumberFormat::unitDisplayString(UnitDisplay unitDisplay)
@@ -1316,7 +1316,7 @@
return "long"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlNumberFormat::compactDisplayString(CompactDisplay compactDisplay)
@@ -1328,7 +1328,7 @@
return "long"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlNumberFormat::signDisplayString(SignDisplay signDisplay)
@@ -1346,7 +1346,7 @@
return "negative"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlNumberFormat::roundingModeString(RoundingMode roundingMode)
@@ -1372,7 +1372,7 @@
return "halfEven"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlNumberFormat::trailingZeroDisplayString(TrailingZeroDisplay trailingZeroDisplay)
@@ -1384,7 +1384,7 @@
return "stripIfInteger"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
ASCIILiteral IntlNumberFormat::roundingPriorityString(IntlRoundingType roundingType)
@@ -1399,7 +1399,7 @@
return "lessPrecision"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
JSValue IntlNumberFormat::useGroupingValue(VM& vm, UseGrouping useGrouping)
Modified: trunk/Source/_javascript_Core/runtime/IntlObject.cpp (292271 => 292272)
--- trunk/Source/_javascript_Core/runtime/IntlObject.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/runtime/IntlObject.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -896,7 +896,7 @@
JSC_INTL_RELEVANT_EXTENSION_KEYS(JSC_RETURN_INTL_RELEVANT_EXTENSION_KEYS)
#undef JSC_RETURN_INTL_RELEVANT_EXTENSION_KEYS
}
- return ASCIILiteral::null();
+ return { };
}
ResolvedLocale resolveLocale(JSGlobalObject* globalObject, const LocaleSet& availableLocales, const Vector<String>& requestedLocales, LocaleMatcher localeMatcher, const ResolveLocaleOptions& options, std::initializer_list<RelevantExtensionKey> relevantExtensionKeys, Vector<String> (*localeData)(const String&, RelevantExtensionKey))
Modified: trunk/Source/_javascript_Core/runtime/IntlRelativeTimeFormat.cpp (292271 => 292272)
--- trunk/Source/_javascript_Core/runtime/IntlRelativeTimeFormat.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/runtime/IntlRelativeTimeFormat.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -96,7 +96,7 @@
LocaleMatcher localeMatcher = intlOption<LocaleMatcher>(globalObject, options, vm.propertyNames->localeMatcher, { { "lookup"_s, LocaleMatcher::Lookup }, { "best fit"_s, LocaleMatcher::BestFit } }, "localeMatcher must be either \"lookup\" or \"best fit\""_s, LocaleMatcher::BestFit);
RETURN_IF_EXCEPTION(scope, void());
- String numberingSystem = intlStringOption(globalObject, options, vm.propertyNames->numberingSystem, { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String numberingSystem = intlStringOption(globalObject, options, vm.propertyNames->numberingSystem, { }, { }, { });
RETURN_IF_EXCEPTION(scope, void());
if (!numberingSystem.isNull()) {
if (!isUnicodeLocaleIdentifierType(numberingSystem)) {
@@ -185,7 +185,7 @@
return "narrow"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
// https://tc39.es/ecma402/#sec-intl.relativetimeformat.prototype.resolvedoptions
Modified: trunk/Source/_javascript_Core/runtime/IntlSegmenter.cpp (292271 => 292272)
--- trunk/Source/_javascript_Core/runtime/IntlSegmenter.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/runtime/IntlSegmenter.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -161,7 +161,7 @@
return "sentence"_s;
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
JSObject* IntlSegmenter::createSegmentDataObject(JSGlobalObject* globalObject, JSString* string, int32_t startIndex, int32_t endIndex, UBreakIterator& segmenter, Granularity granularity)
Modified: trunk/Source/_javascript_Core/runtime/JSObjectInlines.h (292271 => 292272)
--- trunk/Source/_javascript_Core/runtime/JSObjectInlines.h 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/runtime/JSObjectInlines.h 2022-04-03 03:56:21 UTC (rev 292272)
@@ -348,7 +348,7 @@
slot.setExistingProperty(this, offset);
}
- return ASCIILiteral::null();
+ return { };
}
if ((mode == PutModePut || mode == PutModeDefineOwnProperty) && !isStructureExtensible(vm))
@@ -360,7 +360,7 @@
slot.setNewProperty(this, offset);
if (attributes & PropertyAttribute::ReadOnly)
this->structure(vm)->setContainsReadOnlyProperties();
- return ASCIILiteral::null();
+ return { };
}
PropertyOffset offset;
@@ -384,7 +384,7 @@
putDirect(vm, offset, value);
setStructure(vm, newStructure);
slot.setNewProperty(this, offset);
- return ASCIILiteral::null();
+ return { };
}
unsigned currentAttributes;
@@ -408,7 +408,7 @@
slot.setExistingProperty(this, offset);
}
- return ASCIILiteral::null();
+ return { };
}
if ((mode == PutModePut || mode == PutModeDefineOwnProperty) && !isStructureExtensible(vm))
@@ -437,7 +437,7 @@
slot.setNewProperty(this, offset);
if (attributes & PropertyAttribute::ReadOnly)
newStructure->setContainsReadOnlyProperties();
- return ASCIILiteral::null();
+ return { };
}
inline bool JSObject::mayBePrototype() const
Modified: trunk/Source/_javascript_Core/runtime/TemporalDuration.cpp (292271 => 292272)
--- trunk/Source/_javascript_Core/runtime/TemporalDuration.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/runtime/TemporalDuration.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -515,7 +515,7 @@
JSObject* options = intlGetOptionsObject(globalObject, optionsValue);
RETURN_IF_EXCEPTION(scope, 0);
- String unitString = intlStringOption(globalObject, options, vm.propertyNames->unit, { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String unitString = intlStringOption(globalObject, options, vm.propertyNames->unit, { }, { }, { });
RETURN_IF_EXCEPTION(scope, 0);
auto unitType = temporalUnitType(unitString);
Modified: trunk/Source/_javascript_Core/runtime/TemporalObject.cpp (292271 => 292272)
--- trunk/Source/_javascript_Core/runtime/TemporalObject.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/runtime/TemporalObject.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -230,7 +230,7 @@
VM& vm = globalObject->vm();
auto scope = DECLARE_THROW_SCOPE(vm);
- String largestUnit = intlStringOption(globalObject, options, vm.propertyNames->largestUnit, { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String largestUnit = intlStringOption(globalObject, options, vm.propertyNames->largestUnit, { }, { }, { });
RETURN_IF_EXCEPTION(scope, std::nullopt);
if (!largestUnit)
@@ -260,7 +260,7 @@
VM& vm = globalObject->vm();
auto scope = DECLARE_THROW_SCOPE(vm);
- String smallestUnit = intlStringOption(globalObject, options, vm.propertyNames->smallestUnit, { }, ASCIILiteral::null(), ASCIILiteral::null());
+ String smallestUnit = intlStringOption(globalObject, options, vm.propertyNames->smallestUnit, { }, { }, { });
RETURN_IF_EXCEPTION(scope, std::nullopt);
if (!smallestUnit)
Modified: trunk/Source/_javascript_Core/yarr/YarrErrorCode.cpp (292271 => 292272)
--- trunk/Source/_javascript_Core/yarr/YarrErrorCode.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/_javascript_Core/yarr/YarrErrorCode.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -35,7 +35,7 @@
#define REGEXP_ERROR_PREFIX "Invalid regular _expression_: "
// The order of this array must match the ErrorCode enum.
static const ASCIILiteral errorMessages[] = {
- ASCIILiteral::null(), // NoError
+ { }, // NoError
REGEXP_ERROR_PREFIX "regular _expression_ too large"_s, // PatternTooLarge
REGEXP_ERROR_PREFIX "numbers out of order in {} quantifier"_s, // QuantifierOutOfOrder
REGEXP_ERROR_PREFIX "nothing to repeat"_s, // QuantifierWithoutAtom
Modified: trunk/Source/WTF/ChangeLog (292271 => 292272)
--- trunk/Source/WTF/ChangeLog 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/WTF/ChangeLog 2022-04-03 03:56:21 UTC (rev 292272)
@@ -1,3 +1,16 @@
+2022-04-02 Chris Dumez <cdu...@apple.com>
+
+ Add default constructor to ASCIILiteral
+ https://bugs.webkit.org/show_bug.cgi?id=238700
+
+ Reviewed by Geoffrey Garen.
+
+ Add default constructor to ASCIILiteral, to replace the more verbose ASCIILiteral::null().
+
+ * wtf/cocoa/ResourceUsageCocoa.cpp:
+ (WTF::displayNameForVMTag):
+ * wtf/text/ASCIILiteral.h:
+
2022-04-01 Chris Dumez <cdu...@apple.com>
Unreviewed, drop unnecessary WTF_EXPORT_PRIVATE on String(ASCIILiteral)
Modified: trunk/Source/WTF/wtf/cocoa/ResourceUsageCocoa.cpp (292271 => 292272)
--- trunk/Source/WTF/wtf/cocoa/ResourceUsageCocoa.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/WTF/wtf/cocoa/ResourceUsageCocoa.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -98,7 +98,7 @@
case VM_MEMORY_STACK: return "Stack"_s;
case VM_MEMORY_TCMALLOC: return "bmalloc"_s;
case VM_MEMORY_UNSHARED_PMAP: return "pmap (unshared)"_s;
- default: return ASCIILiteral::null();
+ default: return { };
}
}
Modified: trunk/Source/WTF/wtf/text/ASCIILiteral.h (292271 => 292272)
--- trunk/Source/WTF/wtf/text/ASCIILiteral.h 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/WTF/wtf/text/ASCIILiteral.h 2022-04-03 03:56:21 UTC (rev 292272)
@@ -44,10 +44,7 @@
WTF_EXPORT_PRIVATE void dump(PrintStream& out) const;
- static constexpr ASCIILiteral null()
- {
- return ASCIILiteral { nullptr };
- }
+ ASCIILiteral() = default;
constexpr bool isNull() const { return !m_characters; }
@@ -65,7 +62,7 @@
private:
constexpr explicit ASCIILiteral(const char* characters) : m_characters(characters) { }
- const char* m_characters;
+ const char* m_characters { nullptr };
};
inline bool operator==(ASCIILiteral a, const char* b)
Modified: trunk/Source/WebCore/ChangeLog (292271 => 292272)
--- trunk/Source/WebCore/ChangeLog 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/WebCore/ChangeLog 2022-04-03 03:56:21 UTC (rev 292272)
@@ -1,3 +1,20 @@
+2022-04-02 Chris Dumez <cdu...@apple.com>
+
+ Add default constructor to ASCIILiteral
+ https://bugs.webkit.org/show_bug.cgi?id=238700
+
+ Reviewed by Geoffrey Garen.
+
+ Add default constructor to ASCIILiteral, to replace the more verbose ASCIILiteral::null().
+
+ * css/makevalues.pl:
+ * dom/DOMException.cpp:
+ (WebCore::DOMException::description const):
+ * platform/cocoa/PasteboardCocoa.mm:
+ (WebCore::imageTypeToFakeFilename):
+ * platform/graphics/ca/GraphicsLayerCA.cpp:
+ (WebCore::propertyIdToString):
+
2022-04-02 Alan Bujtas <za...@apple.com>
[Ruby] Remove incorrect implicit integral floor in RenderRubyText::adjustInlineDirectionLineBounds
Modified: trunk/Source/WebCore/css/makevalues.pl (292271 => 292272)
--- trunk/Source/WebCore/css/makevalues.pl 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/WebCore/css/makevalues.pl 2022-04-03 03:56:21 UTC (rev 292272)
@@ -120,7 +120,7 @@
}
print GPERF << "EOF";
- ASCIILiteral::null()
+ ASCIILiteral()
};
const Value* findValue(const char* str, unsigned int len)
@@ -131,7 +131,7 @@
ASCIILiteral getValueName(unsigned short id)
{
if (id > lastCSSValueKeyword)
- return ASCIILiteral::null();
+ return { };
return valueList[id];
}
Modified: trunk/Source/WebCore/dom/DOMException.cpp (292271 => 292272)
--- trunk/Source/WebCore/dom/DOMException.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/WebCore/dom/DOMException.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -77,7 +77,7 @@
if (ec < WTF_ARRAY_LENGTH(descriptions))
return descriptions[ec];
- static const Description emptyDescription { ASCIILiteral::null(), ASCIILiteral::null(), 0 };
+ static const Description emptyDescription { { }, { }, 0 };
return emptyDescription;
}
Modified: trunk/Source/WebCore/platform/cocoa/PasteboardCocoa.mm (292271 => 292272)
--- trunk/Source/WebCore/platform/cocoa/PasteboardCocoa.mm 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/WebCore/platform/cocoa/PasteboardCocoa.mm 2022-04-03 03:56:21 UTC (rev 292272)
@@ -109,13 +109,13 @@
switch (type) {
case ImageType::Invalid:
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
case ImageType::TIFF:
#if PLATFORM(MAC)
return "image.png"_s; // For Web compatibility, we pretend to have PNG instead.
#else
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
#endif
case ImageType::PNG:
return "image.png"_s;
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (292271 => 292272)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -274,7 +274,7 @@
ASSERT_NOT_REACHED();
}
ASSERT_NOT_REACHED();
- return ASCIILiteral::null();
+ return { };
}
static bool animationHasStepsTimingFunction(const KeyframeValueList& valueList, const Animation* anim)
Modified: trunk/Source/WebKit/ChangeLog (292271 => 292272)
--- trunk/Source/WebKit/ChangeLog 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/WebKit/ChangeLog 2022-04-03 03:56:21 UTC (rev 292272)
@@ -1,3 +1,19 @@
+2022-04-02 Chris Dumez <cdu...@apple.com>
+
+ Add default constructor to ASCIILiteral
+ https://bugs.webkit.org/show_bug.cgi?id=238700
+
+ Reviewed by Geoffrey Garen.
+
+ Add default constructor to ASCIILiteral, to replace the more verbose ASCIILiteral::null().
+
+ * NetworkProcess/WebStorage/LocalStorageDatabase.cpp:
+ (WebKit::LocalStorageDatabase::migrateItemTableIfNeeded):
+ * UIProcess/AuxiliaryProcessProxy.cpp:
+ (WebKit::AuxiliaryProcessProxy::sendMessage):
+ * WebProcess/Inspector/WebInspectorUI.cpp:
+ (WebKit::WebInspectorUI::setDockSide):
+
2022-04-02 Myles C. Maxfield <mmaxfi...@apple.com>
[Cocoa] semaphore_timedwait() can return KERN_ABORTED
Modified: trunk/Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.cpp (292271 => 292272)
--- trunk/Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -138,7 +138,7 @@
"INSERT INTO ItemTable2 SELECT * from ItemTable"_s,
"DROP TABLE ItemTable"_s,
"ALTER TABLE ItemTable2 RENAME TO ItemTable"_s,
- ASCIILiteral::null(),
+ { },
};
SQLiteTransaction transaction(m_database);
Modified: trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp (292271 => 292272)
--- trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -191,7 +191,7 @@
if (asyncReplyInfo && canSendMessage() && shouldStartProcessThrottlerActivity == ShouldStartProcessThrottlerActivity::Yes) {
auto completionHandler = std::exchange(asyncReplyInfo->first, nullptr);
- asyncReplyInfo->first = [activity = throttler().backgroundActivity(ASCIILiteral::null()), completionHandler = WTFMove(completionHandler)](IPC::Decoder* decoder) mutable {
+ asyncReplyInfo->first = [activity = throttler().backgroundActivity({ }), completionHandler = WTFMove(completionHandler)](IPC::Decoder* decoder) mutable {
completionHandler(decoder);
};
}
Modified: trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp (292271 => 292272)
--- trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -229,7 +229,7 @@
void WebInspectorUI::setDockSide(DockSide dockSide)
{
- ASCIILiteral dockSideString { ASCIILiteral::null() };
+ ASCIILiteral dockSideString;
switch (dockSide) {
case DockSide::Undocked:
Modified: trunk/Source/WebKitLegacy/ChangeLog (292271 => 292272)
--- trunk/Source/WebKitLegacy/ChangeLog 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/WebKitLegacy/ChangeLog 2022-04-03 03:56:21 UTC (rev 292272)
@@ -1,3 +1,15 @@
+2022-04-02 Chris Dumez <cdu...@apple.com>
+
+ Add default constructor to ASCIILiteral
+ https://bugs.webkit.org/show_bug.cgi?id=238700
+
+ Reviewed by Geoffrey Garen.
+
+ Add default constructor to ASCIILiteral, to replace the more verbose ASCIILiteral::null().
+
+ * Storage/StorageAreaSync.cpp:
+ (WebKit::StorageAreaSync::migrateItemTableIfNeeded):
+
2022-03-31 Chris Dumez <cdu...@apple.com>
Prepare WebKit/ & WebKitLegacy/ for making the String(const char*) constructor explicit
Modified: trunk/Source/WebKitLegacy/Storage/StorageAreaSync.cpp (292271 => 292272)
--- trunk/Source/WebKitLegacy/Storage/StorageAreaSync.cpp 2022-04-02 21:52:58 UTC (rev 292271)
+++ trunk/Source/WebKitLegacy/Storage/StorageAreaSync.cpp 2022-04-03 03:56:21 UTC (rev 292272)
@@ -291,7 +291,7 @@
"INSERT INTO ItemTable2 SELECT * from ItemTable"_s,
"DROP TABLE ItemTable"_s,
"ALTER TABLE ItemTable2 RENAME TO ItemTable"_s,
- ASCIILiteral::null(),
+ { },
};
SQLiteTransaction transaction(m_database, false);
