Title: [292744] trunk/Source/WebGPU
- Revision
- 292744
- Author
- mmaxfi...@apple.com
- Date
- 2022-04-11 17:14:49 -0700 (Mon, 11 Apr 2022)
Log Message
[WebGPU] Implement missing validity checks
https://bugs.webkit.org/show_bug.cgi?id=238722
Reviewed by Kimmo Kinnunen.
Now that WebGPU objects have a notion of validity, we can implement all the
FIXMEs for validity checks.
* WebGPU/Buffer.mm:
(WebGPU::validateCreateBuffer):
(WebGPU::Buffer::validateMapAsync const):
* WebGPU/CommandEncoder.h:
(WebGPU::CommandEncoder::makeInvalid):
* WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::validateCopyBufferToBuffer):
(WebGPU::validateImageCopyBuffer):
(WebGPU::CommandEncoder::validateClearBuffer):
(WebGPU::CommandEncoder::validateFinish const):
(WebGPU::CommandEncoder::finish):
(WebGPU::CommandEncoder::popDebugGroup):
(WebGPU::validateCopyBufferToBuffer): Deleted.
(WebGPU::validateClearBuffer): Deleted.
* WebGPU/ComputePassEncoder.h:
(WebGPU::ComputePassEncoder::makeInvalid):
* WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::popDebugGroup):
* WebGPU/ObjectBase.h:
(WebGPU::ObjectBase::isValidToUseWith const):
(WebGPU::ObjectBase::device const):
* WebGPU/Queue.h:
(WebGPU::Queue::device const):
* WebGPU/Queue.mm:
(WebGPU::Queue::validateSubmit const):
(WebGPU::Queue::submit):
(WebGPU::Queue::validateWriteBuffer const):
* WebGPU/RenderBundleEncoder.h:
(WebGPU::RenderBundleEncoder::makeInvalid):
* WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::popDebugGroup):
* WebGPU/RenderPassEncoder.h:
(WebGPU::RenderPassEncoder::makeInvalid):
* WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::popDebugGroup):
* WebGPU/Sampler.mm:
(WebGPU::validateCreateSampler):
* WebGPU/Texture.mm:
(WebGPU::Device::validateCreateTexture):
(WebGPU::Device::createTexture):
(WebGPU::Texture::validateCreateView const):
(WebGPU::Texture::createView):
(WebGPU::Texture::validateImageCopyTexture):
Modified Paths
Diff
Modified: trunk/Source/WebGPU/ChangeLog (292743 => 292744)
--- trunk/Source/WebGPU/ChangeLog 2022-04-12 00:10:17 UTC (rev 292743)
+++ trunk/Source/WebGPU/ChangeLog 2022-04-12 00:14:49 UTC (rev 292744)
@@ -52,6 +52,18 @@
(WebGPU::Texture::createView):
(WebGPU::Texture::validateImageCopyTexture):
+2022-04-11 Myles C. Maxfield <mmaxfi...@apple.com>
+
+ [WebGPU] RGB9E5Ufloat textures should not be multisamplable
+ https://bugs.webkit.org/show_bug.cgi?id=239053
+
+ Reviewed by Kimmo Kinnunen.
+
+ It's classified as a "packed format" rather than a "mixed component width format."
+
+ * WebGPU/Texture.mm:
+ (WebGPU::supportsMultisampling):
+
2022-04-08 Myles C. Maxfield <mmaxfi...@apple.com>
[WebGPU] Fix the release build
Modified: trunk/Source/WebGPU/WebGPU/Texture.mm (292743 => 292744)
--- trunk/Source/WebGPU/WebGPU/Texture.mm 2022-04-12 00:10:17 UTC (rev 292743)
+++ trunk/Source/WebGPU/WebGPU/Texture.mm 2022-04-12 00:14:49 UTC (rev 292744)
@@ -868,7 +868,6 @@
case WGPUTextureFormat_BGRA8UnormSrgb:
case WGPUTextureFormat_RGB10A2Unorm:
case WGPUTextureFormat_RG11B10Ufloat:
- case WGPUTextureFormat_RGB9E5Ufloat:
case WGPUTextureFormat_RGBA16Uint:
case WGPUTextureFormat_RGBA16Sint:
case WGPUTextureFormat_RGBA16Float:
@@ -889,6 +888,7 @@
case WGPUTextureFormat_RGBA32Float:
case WGPUTextureFormat_RGBA32Uint:
case WGPUTextureFormat_RGBA32Sint:
+ case WGPUTextureFormat_RGB9E5Ufloat:
case WGPUTextureFormat_BC1RGBAUnorm:
case WGPUTextureFormat_BC1RGBAUnormSrgb:
case WGPUTextureFormat_BC2RGBAUnorm:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
