Title: [292989] branches/safari-613-branch/Source/WebCore
Revision
292989
Author
alanc...@apple.com
Date
2022-04-18 17:49:38 -0700 (Mon, 18 Apr 2022)

Log Message

Cherry-pick r292418. rdar://problem/91312118

    Avoid unnecessary traversal when updating list markers
    https://bugs.webkit.org/show_bug.cgi?id=238795

    Reviewed by Anders Carlsson.

    This code could use a full rewrite but there are also some simple optimizations that can be done.

    * rendering/RenderListItem.cpp:
    (WebCore::nextListItemHelper):

    Don't advance into non-rendered subtrees. We won't find any renderers there.

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-613-branch/Source/WebCore/ChangeLog (292988 => 292989)


--- branches/safari-613-branch/Source/WebCore/ChangeLog	2022-04-19 00:49:35 UTC (rev 292988)
+++ branches/safari-613-branch/Source/WebCore/ChangeLog	2022-04-19 00:49:38 UTC (rev 292989)
@@ -1,5 +1,38 @@
 2022-04-18  Kocsen Chung  <kocsen_ch...@apple.com>
 
+        Cherry-pick r292418. rdar://problem/91312118
+
+    Avoid unnecessary traversal when updating list markers
+    https://bugs.webkit.org/show_bug.cgi?id=238795
+    
+    Reviewed by Anders Carlsson.
+    
+    This code could use a full rewrite but there are also some simple optimizations that can be done.
+    
+    * rendering/RenderListItem.cpp:
+    (WebCore::nextListItemHelper):
+    
+    Don't advance into non-rendered subtrees. We won't find any renderers there.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2022-04-05  Antti Koivisto  <an...@apple.com>
+
+            Avoid unnecessary traversal when updating list markers
+            https://bugs.webkit.org/show_bug.cgi?id=238795
+
+            Reviewed by Anders Carlsson.
+
+            This code could use a full rewrite but there are also some simple optimizations that can be done.
+
+            * rendering/RenderListItem.cpp:
+            (WebCore::nextListItemHelper):
+
+            Don't advance into non-rendered subtrees. We won't find any renderers there.
+
+2022-04-18  Kocsen Chung  <kocsen_ch...@apple.com>
+
         Cherry-pick r292400. rdar://problem/89382543
 
     [macOS][selectors] :focus-visible matching on button focused via script (after clicking on a different button)

Modified: branches/safari-613-branch/Source/WebCore/rendering/RenderListItem.cpp (292988 => 292989)


--- branches/safari-613-branch/Source/WebCore/rendering/RenderListItem.cpp	2022-04-19 00:49:35 UTC (rev 292988)
+++ branches/safari-613-branch/Source/WebCore/rendering/RenderListItem.cpp	2022-04-19 00:49:38 UTC (rev 292989)
@@ -124,7 +124,10 @@
 {
     auto* current = &element;
     auto advance = [&] {
-        current = ElementTraversal::nextIncludingPseudo(*current, &list);
+        if (!current->renderOrDisplayContentsStyle())
+            current = ElementTraversal::nextIncludingPseudoSkippingChildren(*current, &list);
+        else
+            current = ElementTraversal::nextIncludingPseudo(*current, &list);
     };
     advance();
     while (current) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to