Title: [293858] trunk/Source/_javascript_Core
- Revision
- 293858
- Author
- ysuz...@apple.com
- Date
- 2022-05-05 12:44:58 -0700 (Thu, 05 May 2022)
Log Message
Unreviewed, partial revert of r293813 because of proposal's issue.
https://bugs.webkit.org/show_bug.cgi?id=240102
* runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::initializeNumberFormat):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (293857 => 293858)
--- trunk/Source/_javascript_Core/ChangeLog 2022-05-05 18:58:04 UTC (rev 293857)
+++ trunk/Source/_javascript_Core/ChangeLog 2022-05-05 19:44:58 UTC (rev 293858)
@@ -1,5 +1,13 @@
2022-05-05 Yusuke Suzuki <ysuz...@apple.com>
+ Unreviewed, partial revert of r293813 because of proposal's issue.
+ https://bugs.webkit.org/show_bug.cgi?id=240102
+
+ * runtime/IntlNumberFormat.cpp:
+ (JSC::IntlNumberFormat::initializeNumberFormat):
+
+2022-05-05 Yusuke Suzuki <ysuz...@apple.com>
+
[JSC] Clean up StructureID related data
https://bugs.webkit.org/show_bug.cgi?id=240114
Modified: trunk/Source/_javascript_Core/runtime/IntlNumberFormat.cpp (293857 => 293858)
--- trunk/Source/_javascript_Core/runtime/IntlNumberFormat.cpp 2022-05-05 18:58:04 UTC (rev 293857)
+++ trunk/Source/_javascript_Core/runtime/IntlNumberFormat.cpp 2022-05-05 19:44:58 UTC (rev 293858)
@@ -399,10 +399,9 @@
throwTypeError(globalObject, scope, "rounding type is not fraction-digits while roundingIncrement is specified"_s);
return;
}
- if (m_maximumFractionDigits != m_minimumFractionDigits) {
- throwRangeError(globalObject, scope, "maximum and minimum fraction-digits are not equal while roundingIncrement is specified"_s);
- return;
- }
+ // FIXME: The proposal has m_maximumFractionDigits != m_minimumFractionDigits check here, but it breaks the use case.
+ // We intentionally do not follow to that here until the issue is fixed.
+ // https://github.com/tc39/proposal-intl-numberformat-v3/issues/97
}
m_trailingZeroDisplay = intlOption<TrailingZeroDisplay>(globalObject, options, vm.propertyNames->trailingZeroDisplay, { { "auto"_s, TrailingZeroDisplay::Auto }, { "stripIfInteger"_s, TrailingZeroDisplay::StripIfInteger } }, "trailingZeroDisplay must be either \"auto\" or \"stripIfInteger\""_s, TrailingZeroDisplay::Auto);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
