Title: [294267] trunk
- Revision
- 294267
- Author
- n...@apple.com
- Date
- 2022-05-16 15:25:02 -0700 (Mon, 16 May 2022)
Log Message
[css-ui] Unexpose attachment and borderless-attachment appearance values
https://bugs.webkit.org/show_bug.cgi?id=240447
Reviewed by Tim Horton.
Hide them behind the attachmentElementEnabled setting.
Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
LayoutTests:
* imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
Source/WebCore:
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
Canonical link: https://commits.webkit.org/250615@main
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (294266 => 294267)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-16 22:18:15 UTC (rev 294266)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-05-16 22:25:02 UTC (rev 294267)
@@ -1,5 +1,18 @@
2022-05-16 Tim Nguyen <n...@apple.com>
+ [css-ui] Unexpose attachment and borderless-attachment appearance values
+ https://bugs.webkit.org/show_bug.cgi?id=240447
+
+ Reviewed by Tim Horton.
+
+ Hide them behind the attachmentElementEnabled setting.
+
+ Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
+
+ * web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt:
+
+2022-05-16 Tim Nguyen <n...@apple.com>
+
[css-ui] Make inner-spin-button/sliderthumb-horizontal/sliderthumb-vertical appearance values internal
https://bugs.webkit.org/show_bug.cgi?id=240448
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt (294266 => 294267)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-16 22:18:15 UTC (rev 294266)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001-expected.txt 2022-05-16 22:25:02 UTC (rev 294267)
@@ -17,9 +17,9 @@
PASS -webkit-appearance: textarea
PASS -webkit-appearance: textfield
PASS -webkit-appearance: bogus-button (invalid)
-FAIL -webkit-appearance: attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "attachment"
+PASS -webkit-appearance: attachment (invalid)
PASS -webkit-appearance: button-bevel (invalid)
-FAIL -webkit-appearance: borderless-attachment (invalid) assert_equals: style.WebkitAppearance (uppercase W) expected "" but got "borderless-attachment"
+PASS -webkit-appearance: borderless-attachment (invalid)
PASS -webkit-appearance: button-arrow-down (invalid)
PASS -webkit-appearance: button-arrow-next (invalid)
PASS -webkit-appearance: button-arrow-previous (invalid)
@@ -180,9 +180,9 @@
PASS appearance: textarea
PASS appearance: textfield
PASS appearance: bogus-button (invalid)
-FAIL appearance: attachment (invalid) assert_equals: style.appearance expected "" but got "attachment"
+PASS appearance: attachment (invalid)
PASS appearance: button-bevel (invalid)
-FAIL appearance: borderless-attachment (invalid) assert_equals: style.appearance expected "" but got "borderless-attachment"
+PASS appearance: borderless-attachment (invalid)
PASS appearance: button-arrow-down (invalid)
PASS appearance: button-arrow-next (invalid)
PASS appearance: button-arrow-previous (invalid)
Modified: trunk/Source/WebCore/ChangeLog (294266 => 294267)
--- trunk/Source/WebCore/ChangeLog 2022-05-16 22:18:15 UTC (rev 294266)
+++ trunk/Source/WebCore/ChangeLog 2022-05-16 22:25:02 UTC (rev 294267)
@@ -1,5 +1,19 @@
2022-05-16 Tim Nguyen <n...@apple.com>
+ [css-ui] Unexpose attachment and borderless-attachment appearance values
+ https://bugs.webkit.org/show_bug.cgi?id=240447
+
+ Reviewed by Tim Horton.
+
+ Hide them behind the attachmentElementEnabled setting.
+
+ Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html
+
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
+
+2022-05-16 Tim Nguyen <n...@apple.com>
+
[css-ui] Update documentation for appearance CSS property
https://bugs.webkit.org/show_bug.cgi?id=240481
Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (294266 => 294267)
--- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2022-05-16 22:18:15 UTC (rev 294266)
+++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2022-05-16 22:25:02 UTC (rev 294267)
@@ -750,8 +750,13 @@
return valueID == CSSValueNone || valueID == CSSValueNonScalingStroke;
case CSSPropertyVisibility: // visible | hidden | collapse
return valueID == CSSValueVisible || valueID == CSSValueHidden || valueID == CSSValueCollapse;
- case CSSPropertyAppearance:
+ case CSSPropertyAppearance: {
+#if ENABLE(ATTACHMENT_ELEMENT)
+ if (valueID == CSSValueAttachment || valueID == CSSValueBorderlessAttachment)
+ return context.attachmentEnabled;
+#endif
return (valueID >= CSSValueCheckbox && valueID <= CSSValueTextfield) || valueID == CSSValueNone || valueID == CSSValueAuto;
+ }
case CSSPropertyBackfaceVisibility:
return valueID == CSSValueVisible || valueID == CSSValueHidden;
#if ENABLE(CSS_COMPOSITING)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
