Title: [294389] trunk/Source
Revision
294389
Author
commit-qu...@webkit.org
Date
2022-05-18 04:23:11 -0700 (Wed, 18 May 2022)

Log Message

ENABLE_LAYER_BASED_SVG_ENGINE needs to match for iOS and macOS 
https://bugs.webkit.org/show_bug.cgi?id=239877
<rdar://problem/92829309>

Patch by Nikolas Zimmermann <nzimmerm...@igalia.com> on 2022-05-18
Reviewed by Simon Fraser.

Switch on ENABLE_LAYER_BASED_SVG_ENGINE for all Cocoa based platforms.

This only works after fixing one build issue:
hasTransform() now needs hasSVGTransform(), when in turn uses rareData(), which
is not exported by WebCore at present breaking tvOS/watchOS/iOS builds, fix that.

Covered by existing tests, no change in behaviour.

* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WebCore/rendering/RenderObject.h:

Modified Paths

Diff

Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (294388 => 294389)


--- trunk/Source/WTF/wtf/PlatformEnableCocoa.h	2022-05-18 10:43:54 UTC (rev 294388)
+++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h	2022-05-18 11:23:11 UTC (rev 294389)
@@ -340,7 +340,7 @@
 #define ENABLE_IOS_TOUCH_EVENTS 1
 #endif
 
-#if !defined(ENABLE_LAYER_BASED_SVG_ENGINE) && PLATFORM(MAC)
+#if !defined(ENABLE_LAYER_BASED_SVG_ENGINE)
 #define ENABLE_LAYER_BASED_SVG_ENGINE 1
 #endif
 

Modified: trunk/Source/WebCore/rendering/RenderObject.h (294388 => 294389)


--- trunk/Source/WebCore/rendering/RenderObject.h	2022-05-18 10:43:54 UTC (rev 294388)
+++ trunk/Source/WebCore/rendering/RenderObject.h	2022-05-18 11:23:11 UTC (rev 294389)
@@ -975,7 +975,7 @@
         WeakPtr<RenderBlockFlow> backdropRenderer;
     };
     
-    const RenderObject::RenderObjectRareData& rareData() const;
+    WEBCORE_EXPORT const RenderObject::RenderObjectRareData& rareData() const;
     RenderObjectRareData& ensureRareData();
     void removeRareData();
     
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to