Title: [295144] trunk
- Revision
- 295144
- Author
- hironori.fu...@sony.com
- Date
- 2022-06-02 14:06:09 -0700 (Thu, 02 Jun 2022)
Log Message
REGRESSION(r286765): [Cairo][GTK][WPE] Various SVG tests that use filters fail
https://bugs.webkit.org/show_bug.cgi?id=234118
Reviewed by Don Olmstead.
Cairo doesn't support color space yet. Turned
ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB off for all non-Cocoa
ports.
* LayoutTests/platform/glib/TestExpectations: Unmarked tests. But,
some tests are still failing due to different reasons. Re-marked them as
other bugs.
* Source/WTF/wtf/PlatformEnable.h:
* Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp:
(WebCore::ImageBufferCairoBackend::transformToColorSpace):
Canonical link: https://commits.webkit.org/251234@main
Modified Paths
Diff
Modified: trunk/LayoutTests/platform/glib/TestExpectations (295143 => 295144)
--- trunk/LayoutTests/platform/glib/TestExpectations 2022-06-02 20:53:20 UTC (rev 295143)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2022-06-02 21:06:09 UTC (rev 295144)
@@ -1323,39 +1323,13 @@
webkit.org/b/98653 svg/text/lengthAdjust-text-metrics.html [ Failure ]
-webkit.org/b/234118 fast/filter-image/filter-image-blur.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/blink/svg/filters/big-viewbox.svg [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/blink/svg/filters/feColorMatrix-subregion.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/blink/svg/filters/feDropShadow-flood-opacity-1.svg [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/blink/svg/filters/feOffset-nonuniform-scale.svg [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/blink/svg/filters/filter-huge-clamping.svg [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/mozilla/svg/filter-scaled-02.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/mozilla/svg/image/image-filter-01.svg [ ImageOnlyFailure ]
-webkit.org/b/234118 svg/custom/filter-update-different-root.html [ ImageOnlyFailure ]
-webkit.org/b/234118 svg/filters/color-space-conversion.svg [ ImageOnlyFailure ]
-webkit.org/b/234118 svg/filters/container-with-filters.svg [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/css-filters-animation-opacity.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/effect-reference-on-span.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/morphology-mirrored.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/root-element-with-opacity-filter-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/svg-sourcegraphic-currentcolor-dynamic-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/svg-sourcegraphic-invalidation-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/tainting-feblend-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/tainting-fecomponenttransfer-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/tainting-fecomposite-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/tainting-feconvolvematrix-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/tainting-fediffuselighting-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/tainting-fedisplacementmap-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/tainting-fedropshadow-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/tainting-feflood-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/tainting-fegaussianblur-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/tainting-femorphology-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/tainting-feoffset-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/tainting-fespecularlighting-001.html [ ImageOnlyFailure ]
-webkit.org/b/234118 imported/w3c/web-platform-tests/css/filter-effects/tainting-fetile-001.html [ ImageOnlyFailure ]
-
webkit.org/b/234709 svg/filters/feImage-element-primitive-subregion.svg [ ImageOnlyFailure ]
+webkit.org/b/240934 imported/w3c/web-platform-tests/css/filter-effects/effect-reference-on-span.html [ ImageOnlyFailure ]
+webkit.org/b/240934 imported/w3c/web-platform-tests/css/filter-effects/root-element-with-opacity-filter-001.html [ ImageOnlyFailure ]
+
+imported/w3c/web-platform-tests/css/filter-effects/css-filters-animation-opacity.html [ ImageOnlyFailure ]
+
#////////////////////////////////////////////////////////////////////////////////////////
# End of SVG-related bugs
#////////////////////////////////////////////////////////////////////////////////////////
@@ -2584,10 +2558,14 @@
webkit.org/b/225423 fast/canvas/canvas-composite-text-alpha.html [ Failure ]
# Non-sRGB color spaces are not currently supported by the glib ports.
+css3/color-filters/svg/color-filter-inline-svg.html [ ImageOnlyFailure ]
+css3/filters/reference-filter-color-space.html [ ImageOnlyFailure ]
fast/canvas/canvas-color-space-display-p3.html [ Skip ]
fast/canvas/canvas-color-space-display-p3-ImageData.html [ Skip ]
imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas/ [ Skip ]
imported/w3c/web-platform-tests/html/canvas/offscreen/wide-gamut-canvas/ [ Skip ]
+svg/filters/feCompositeOpaque.html [ ImageOnlyFailure ]
+svg/filters/feDiffuseLighting-bottomRightPixel.html [ ImageOnlyFailure ]
storage/indexeddb/structured-clone-image-data-display-p3.html [ Skip ]
Modified: trunk/Source/WTF/wtf/PlatformEnable.h (295143 => 295144)
--- trunk/Source/WTF/wtf/PlatformEnable.h 2022-06-02 20:53:20 UTC (rev 295143)
+++ trunk/Source/WTF/wtf/PlatformEnable.h 2022-06-02 21:06:09 UTC (rev 295144)
@@ -245,7 +245,7 @@
#endif
#if !defined(ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB)
-#define ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB 1
+#define ENABLE_DESTINATION_COLOR_SPACE_LINEAR_SRGB 0
#endif
#if !defined(ENABLE_DOWNLOAD_ATTRIBUTE)
Modified: trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp (295143 => 295144)
--- trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp 2022-06-02 20:53:20 UTC (rev 295143)
+++ trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairoBackend.cpp 2022-06-02 21:06:09 UTC (rev 295144)
@@ -59,6 +59,7 @@
void ImageBufferCairoBackend::transformToColorSpace(const DestinationColorSpace& newColorSpace)
{
+#if ENABLE(DESTINATION_COLOR_SPACE_LINEAR_SRGB)
if (m_parameters.colorSpace == newColorSpace)
return;
@@ -92,6 +93,10 @@
}();
platformTransformColorSpace(deviceRgbLUT);
}
+#else
+ ASSERT(newColorSpace == DestinationColorSpace::SRGB());
+ ASSERT(m_parameters.colorSpace == DestinationColorSpace::SRGB());
+#endif
}
String ImageBufferCairoBackend::toDataURL(const String& mimeType, std::optional<double> quality, PreserveResolution) const
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
