Title: [295273] trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
- Revision
- 295273
- Author
- za...@apple.com
- Date
- 2022-06-05 17:04:13 -0700 (Sun, 05 Jun 2022)
Log Message
column-reverse content should take resolved flex box height into account when computing visual position
https://bugs.webkit.org/show_bug.cgi?id=241313
Reviewed by Antti Koivisto.
When the flex box has resolvable height, use it as the anchor point to compute the column-reverse content's visual vertical position.
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):
Canonical link: https://commits.webkit.org/251319@main
Modified Paths
Diff
Modified: trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp (295272 => 295273)
--- trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp 2022-06-05 21:53:00 UTC (rev 295272)
+++ trunk/Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp 2022-06-06 00:04:13 UTC (rev 295273)
@@ -264,12 +264,14 @@
};
break;
}
- case FlexDirection::ColumnReverse:
+ case FlexDirection::ColumnReverse: {
+ auto visualBottom = constraints.logicalTop() + constraints.availableVerticalSpace().value_or(logicalWidth);
borderBoxTopLeft = {
constraints.horizontal().logicalLeft + logicalFlexItem.top(),
- constraints.logicalTop() + logicalWidth - logicalFlexItem.right() + flexItemGeometry.marginBefore()
+ visualBottom - logicalFlexItem.right() + flexItemGeometry.marginBefore()
};
break;
+ }
default:
ASSERT_NOT_REACHED();
break;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
