Title: [295399] trunk/Source/WebCore/rendering/RenderBox.h
- Revision
- 295399
- Author
- mattwood...@apple.com
- Date
- 2022-06-08 16:16:27 -0700 (Wed, 08 Jun 2022)
Log Message
Handle a disconnected view during applyTopLeftLocationOffset
https://bugs.webkit.org/show_bug.cgi?id=241355
<rdar://92432637>
Reviewed by Alan Bujtas.
It appears that we can sometimes end up in a state where the document's
view is disconnected during didLayout, which calls applyTopleftLocationOffset.
This just adds a null check to handle this case for now.
* Source/WebCore/rendering/RenderBox.h:
(WebCore::RenderBox::applyTopLeftLocationOffset const):
Canonical link: https://commits.webkit.org/251405@main
Modified Paths
Diff
Modified: trunk/Source/WebCore/rendering/RenderBox.h (295398 => 295399)
--- trunk/Source/WebCore/rendering/RenderBox.h 2022-06-08 23:05:21 UTC (rev 295398)
+++ trunk/Source/WebCore/rendering/RenderBox.h 2022-06-08 23:16:27 UTC (rev 295399)
@@ -592,7 +592,7 @@
void applyTopLeftLocationOffset(LayoutPoint& point) const
{
// This is inlined for speed, since it is used by updateLayerPosition() during scrolling.
- if (!document().view()->hasFlippedBlockRenderers())
+ if (!document().view() || !document().view()->hasFlippedBlockRenderers())
point.move(m_frameRect.x(), m_frameRect.y());
else
applyTopLeftLocationOffsetWithFlipping(point);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes