Skip to site navigation (Press enter)

[webkit-changes] [94335] trunk/Tools

timothy_horton Thu, 01 Sep 2011 12:55:49 -0700

Title: [94335] trunk/Tools

Revision: 94335
Author: timothy_hor...@apple.com
Date: 2011-09-01 12:56:45 -0700 (Thu, 01 Sep 2011)

Log Message

Fix TestWebKitAPI build on clang-2.0

* TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:


Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp

Diff

Modified: trunk/Tools/ChangeLog (94334 => 94335)


--- trunk/Tools/ChangeLog	2011-09-01 19:51:52 UTC (rev 94334)
+++ trunk/Tools/ChangeLog	2011-09-01 19:56:45 UTC (rev 94335)
@@ -1,3 +1,9 @@
+2011-09-01  Tim Horton  <hortont...@gmail.com>
+
+        Fix TestWebKitAPI build on clang-2.0
+
+        * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
+
 2011-09-01  Adam Barth  <aba...@webkit.org>
 
         Remove unused "extension" parameter from rebaseline gardeningserver handler

Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp (94334 => 94335)


--- trunk/Tools/TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp	2011-09-01 19:51:52 UTC (rev 94334)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp	2011-09-01 19:56:45 UTC (rev 94335)
@@ -58,12 +58,12 @@
         EXPECT_EQ(coerceLiteral(10), value.unsafeGet()); \
         value = std::numeric_limits<type>::min(); \
         EXPECT_EQ(true, (Checked<type, RecordOverflow>(value - coerceLiteral(1))).hasOverflowed()); \
-        EXPECT_EQ(false, (value--).hasOverflowed()); \
+        EXPECT_EQ(true, !((value--).hasOverflowed())); \
         EXPECT_EQ(true, value.hasOverflowed()); \
         value = std::numeric_limits<type>::max(); \
-        EXPECT_EQ(false, value.hasOverflowed()); \
+        EXPECT_EQ(true, !value.hasOverflowed()); \
         EXPECT_EQ(true, (Checked<type, RecordOverflow>(value + coerceLiteral(1))).hasOverflowed()); \
-        EXPECT_EQ(false, (value++).hasOverflowed()); \
+        EXPECT_EQ(true, !(value++).hasOverflowed()); \
         EXPECT_EQ(true, value.hasOverflowed()); \
         value = std::numeric_limits<type>::max(); \
         EXPECT_EQ(true, (value += coerceLiteral(1)).hasOverflowed()); \
@@ -75,24 +75,24 @@
         MixedSignednessTest(EXPECT_EQ(0U, (10U - value).unsafeGet())); \
         value = std::numeric_limits<type>::min(); \
         MixedSignednessTest(EXPECT_EQ(true, (Checked<type, RecordOverflow>(value - 1)).hasOverflowed())); \
-        MixedSignednessTest(EXPECT_EQ(false, (value--).hasOverflowed())); \
+        MixedSignednessTest(EXPECT_EQ(true, !(value--).hasOverflowed())); \
         MixedSignednessTest(EXPECT_EQ(true, value.hasOverflowed())); \
         value = std::numeric_limits<type>::max(); \
-        MixedSignednessTest(EXPECT_EQ(false, value.hasOverflowed())); \
+        MixedSignednessTest(EXPECT_EQ(true, !value.hasOverflowed())); \
         MixedSignednessTest(EXPECT_EQ(true, (Checked<type, RecordOverflow>(value + 1)).hasOverflowed())); \
-        MixedSignednessTest(EXPECT_EQ(false, (value++).hasOverflowed())); \
+        MixedSignednessTest(EXPECT_EQ(true, !(value++).hasOverflowed())); \
         MixedSignednessTest(EXPECT_EQ(true, value.hasOverflowed())); \
         value = std::numeric_limits<type>::max(); \
         MixedSignednessTest(EXPECT_EQ(true, (value += 1).hasOverflowed())); \
         MixedSignednessTest(EXPECT_EQ(true, value.hasOverflowed())); \
         value = std::numeric_limits<type>::min(); \
         MixedSignednessTest(EXPECT_EQ(true, (value - 1U).hasOverflowed())); \
-        MixedSignednessTest(EXPECT_EQ(false, (value--).hasOverflowed())); \
+        MixedSignednessTest(EXPECT_EQ(true, !(value--).hasOverflowed())); \
         MixedSignednessTest(EXPECT_EQ(true, value.hasOverflowed())); \
         value = std::numeric_limits<type>::max(); \
-        MixedSignednessTest(EXPECT_EQ(false, value.hasOverflowed())); \
+        MixedSignednessTest(EXPECT_EQ(true, !value.hasOverflowed())); \
         MixedSignednessTest(EXPECT_EQ(true, (Checked<type, RecordOverflow>(value + 1U)).hasOverflowed())); \
-        MixedSignednessTest(EXPECT_EQ(false, (value++).hasOverflowed())); \
+        MixedSignednessTest(EXPECT_EQ(true, !(value++).hasOverflowed())); \
         MixedSignednessTest(EXPECT_EQ(true, value.hasOverflowed())); \
         value = std::numeric_limits<type>::max(); \
         MixedSignednessTest(EXPECT_EQ(true, (value += 1U).hasOverflowed())); \

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes