Title: [96937] trunk/Source/WebCore
- Revision
- 96937
- Author
- podivi...@chromium.org
- Date
- 2011-10-07 07:56:12 -0700 (Fri, 07 Oct 2011)
Log Message
Unreviewed, rolling out r96892.
http://trac.webkit.org/changeset/96892
https://bugs.webkit.org/show_bug.cgi?id=69626
it broke windows canary bots (Requested by podivilov on
#webkit).
Patch by Sheriff Bot <webkit.review....@gmail.com> on 2011-10-07
* WebCore.gyp/scripts/rule_binding.py:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (96936 => 96937)
--- trunk/Source/WebCore/ChangeLog 2011-10-07 14:49:45 UTC (rev 96936)
+++ trunk/Source/WebCore/ChangeLog 2011-10-07 14:56:12 UTC (rev 96937)
@@ -1,3 +1,14 @@
+2011-10-07 Sheriff Bot <webkit.review....@gmail.com>
+
+ Unreviewed, rolling out r96892.
+ http://trac.webkit.org/changeset/96892
+ https://bugs.webkit.org/show_bug.cgi?id=69626
+
+ it broke windows canary bots (Requested by podivilov on
+ #webkit).
+
+ * WebCore.gyp/scripts/rule_binding.py:
+
2011-10-07 Andreas Kling <kl...@webkit.org>
Shrink StyleInheritedData.
Modified: trunk/Source/WebCore/WebCore.gyp/scripts/rule_binding.py (96936 => 96937)
--- trunk/Source/WebCore/WebCore.gyp/scripts/rule_binding.py 2011-10-07 14:49:45 UTC (rev 96936)
+++ trunk/Source/WebCore/WebCore.gyp/scripts/rule_binding.py 2011-10-07 14:56:12 UTC (rev 96937)
@@ -49,6 +49,7 @@
import os
import shlex
import shutil
+import subprocess
import sys
@@ -123,9 +124,13 @@
command.extend(['--outputHeadersDir', hdir])
command.extend(['--outputDir', cppdir, input])
- # Do it.
- os.execvp('perl', command)
+ # Do it. check_call is new in 2.5, so simulate its behavior with call and
+ # assert.
+ returnCode = subprocess.call(command)
+ assert returnCode == 0
+ return returnCode
+
if __name__ == '__main__':
- main(sys.argv)
+ sys.exit(main(sys.argv))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes