Title: [97966] trunk/Source/WebCore
- Revision
- 97966
- Author
- pfeld...@chromium.org
- Date
- 2011-10-20 04:55:35 -0700 (Thu, 20 Oct 2011)
Log Message
Not reviewed: follow up to 97961 - dispatching of hide on detach was missing.
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype.show):
* inspector/front-end/View.js:
(WebInspector.View.prototype.detach):
* inspector/front-end/utilities.js:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (97965 => 97966)
--- trunk/Source/WebCore/ChangeLog 2011-10-20 11:37:26 UTC (rev 97965)
+++ trunk/Source/WebCore/ChangeLog 2011-10-20 11:55:35 UTC (rev 97966)
@@ -1,3 +1,13 @@
+2011-10-20 Pavel Feldman <pfeld...@google.com>
+
+ Not reviewed: follow up to 97961 - dispatching of hide on detach was missing.
+
+ * inspector/front-end/AuditsPanel.js:
+ (WebInspector.AuditsPanel.prototype.show):
+ * inspector/front-end/View.js:
+ (WebInspector.View.prototype.detach):
+ * inspector/front-end/utilities.js:
+
2011-10-20 Kenneth Rohde Christiansen <kenn...@webkit.org>
Properly suspend/resume Geolocation/DeviceMotion/DeviceOrientation objects
Modified: trunk/Source/WebCore/inspector/front-end/AuditsPanel.js (97965 => 97966)
--- trunk/Source/WebCore/inspector/front-end/AuditsPanel.js 2011-10-20 11:37:26 UTC (rev 97965)
+++ trunk/Source/WebCore/inspector/front-end/AuditsPanel.js 2011-10-20 11:55:35 UTC (rev 97966)
@@ -247,8 +247,8 @@
show: function()
{
WebInspector.Panel.prototype.show.call(this);
-
- this.auditsItemTreeElement.select();
+ if (!this._visibleView)
+ this.auditsItemTreeElement.select();
},
updateMainViewWidth: function(width)
Modified: trunk/Source/WebCore/inspector/front-end/View.js (97965 => 97966)
--- trunk/Source/WebCore/inspector/front-end/View.js 2011-10-20 11:37:26 UTC (rev 97965)
+++ trunk/Source/WebCore/inspector/front-end/View.js 2011-10-20 11:55:35 UTC (rev 97966)
@@ -99,6 +99,11 @@
detach: function()
{
+ if (this._visible) {
+ this.dispatchToSelfAndChildren("willHide", true);
+ this._visible = false;
+ }
+
this.dispatchToSelfAndChildren("willDetach", false);
if (this.element.parentElement)
Modified: trunk/Source/WebCore/inspector/front-end/utilities.js (97965 => 97966)
--- trunk/Source/WebCore/inspector/front-end/utilities.js 2011-10-20 11:37:26 UTC (rev 97965)
+++ trunk/Source/WebCore/inspector/front-end/utilities.js 2011-10-20 11:55:35 UTC (rev 97966)
@@ -977,7 +977,7 @@
/**
* @param {string} query
- * @param {boolean} ignoreCase
+ * @param {boolean} caseSensitive
* @param {boolean} isRegex
* @return {RegExp}
*/
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
