Title: [97983] trunk/Tools
- Revision
- 97983
- Author
- ph...@webkit.org
- Date
- 2011-10-20 08:47:57 -0700 (Thu, 20 Oct 2011)
Log Message
[style] Allow usage of NULL in gst_*
https://bugs.webkit.org/show_bug.cgi?id=70498
Reviewed by David Levin.
* Scripts/webkitpy/style/checkers/cpp.py: Simplified the detection
of gst_ calls. Now just ignore NULL in all of them.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Test for above change.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (97982 => 97983)
--- trunk/Tools/ChangeLog 2011-10-20 15:30:34 UTC (rev 97982)
+++ trunk/Tools/ChangeLog 2011-10-20 15:47:57 UTC (rev 97983)
@@ -1,3 +1,14 @@
+2011-10-20 Philippe Normand <pnorm...@igalia.com>
+
+ [style] Allow usage of NULL in gst_*
+ https://bugs.webkit.org/show_bug.cgi?id=70498
+
+ Reviewed by David Levin.
+
+ * Scripts/webkitpy/style/checkers/cpp.py: Simplified the detection
+ of gst_ calls. Now just ignore NULL in all of them.
+ * Scripts/webkitpy/style/checkers/cpp_unittest.py: Test for above change.
+
2011-10-20 Leandro Pereira <lean...@profusion.mobi>
[EFL] Unreviewed. Build fix after r97043.
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (97982 => 97983)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-10-20 15:30:34 UTC (rev 97982)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2011-10-20 15:47:57 UTC (rev 97983)
@@ -2377,26 +2377,10 @@
if search(r'\bg(_[a-z]+)+\b', line):
return
- # Don't warn about NULL usage in gst_*_many(). See Bug 39740
- if search(r'\bgst_\w+_many\b', line):
+ # Don't warn about NULL usage in gst_*(). See Bug 70498.
+ if search(r'\bgst(_[a-z]+)+\b', line):
return
- # Don't warn about NULL usage in some gst_structure_*(). See Bug 67194.
- if search(r'\bgst_structure_[sg]et\b', line):
- return
- if search(r'\bgst_structure_remove_fields\b', line):
- return
- if search(r'\bgst_structure_new\b', line):
- return
- if search(r'\bgst_structure_id_new\b', line):
- return
- if search(r'\bgst_structure_id_[sg]et\b', line):
- return
-
- # Don't warn about NULL usage in g_str{join,concat}(). See Bug 34834
- if search(r'\bg_str(join|concat)\b', line):
- return
-
# Don't warn about NULL usage in gdk_pixbuf_save_to_*{join,concat}(). See Bug 43090.
if search(r'\bgdk_pixbuf_save_to\w+\b', line):
return
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (97982 => 97983)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-10-20 15:30:34 UTC (rev 97982)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2011-10-20 15:47:57 UTC (rev 97983)
@@ -4128,6 +4128,12 @@
'gst_structure_id_get(FOO, VALUE, G_TYPE_INT, &value, NULL);',
'')
self.assert_lint(
+ 'gst_caps_new_simple(mime, "value", G_TYPE_INT, &value, NULL);',
+ '')
+ self.assert_lint(
+ 'gst_caps_new_full(structure1, structure2, NULL);',
+ '')
+ self.assert_lint(
'gchar* result = g_strconcat("part1", "part2", "part3", NULL);',
'')
self.assert_lint(
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
